Commit b6afcb94 authored by Ding Xiang's avatar Ding Xiang Committed by Andrew Morton

selftests/mm: gup_longterm: fix a resource leak

The opened file should be closed in run_with_tmpfile(), otherwise resource
leak will occur

Link: https://lkml.kernel.org/r/20230831093144.7520-1-dingxiang@cmss.chinamobile.comSigned-off-by: default avatarDing Xiang <dingxiang@cmss.chinamobile.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent e19a3f59
...@@ -265,10 +265,11 @@ static void run_with_tmpfile(test_fn fn, const char *desc) ...@@ -265,10 +265,11 @@ static void run_with_tmpfile(test_fn fn, const char *desc)
fd = fileno(file); fd = fileno(file);
if (fd < 0) { if (fd < 0) {
ksft_test_result_fail("fileno() failed\n"); ksft_test_result_fail("fileno() failed\n");
return; goto close;
} }
fn(fd, pagesize); fn(fd, pagesize);
close:
fclose(file); fclose(file);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment