Commit b75a80f4 authored by Mike Snitzer's avatar Mike Snitzer

dm bufio: don't bug for clear developer oversight

Reasonable to relax to WARN_ON because these are easily avoided but do
offer some assurance future coding mistakes won't occur (if changes
tested properly).
Signed-off-by: default avatarMike Snitzer <snitzer@kernel.org>
parent 05112287
...@@ -378,8 +378,10 @@ static void adjust_total_allocated(struct dm_buffer *b, bool unlink) ...@@ -378,8 +378,10 @@ static void adjust_total_allocated(struct dm_buffer *b, bool unlink)
*/ */
static void __cache_size_refresh(void) static void __cache_size_refresh(void)
{ {
BUG_ON(!mutex_is_locked(&dm_bufio_clients_lock)); if (WARN_ON(!mutex_is_locked(&dm_bufio_clients_lock)))
BUG_ON(dm_bufio_client_count < 0); return;
if (WARN_ON(dm_bufio_client_count < 0))
return;
dm_bufio_cache_size_latch = READ_ONCE(dm_bufio_cache_size); dm_bufio_cache_size_latch = READ_ONCE(dm_bufio_cache_size);
...@@ -1536,7 +1538,8 @@ static void drop_buffers(struct dm_bufio_client *c) ...@@ -1536,7 +1538,8 @@ static void drop_buffers(struct dm_bufio_client *c)
int i; int i;
bool warned = false; bool warned = false;
BUG_ON(dm_bufio_in_request()); if (WARN_ON(dm_bufio_in_request()))
return; /* should never happen */
/* /*
* An optimization so that the buffers are not written one-by-one. * An optimization so that the buffers are not written one-by-one.
...@@ -1556,7 +1559,7 @@ static void drop_buffers(struct dm_bufio_client *c) ...@@ -1556,7 +1559,7 @@ static void drop_buffers(struct dm_bufio_client *c)
(unsigned long long)b->block, b->hold_count, i); (unsigned long long)b->block, b->hold_count, i);
#ifdef CONFIG_DM_DEBUG_BLOCK_STACK_TRACING #ifdef CONFIG_DM_DEBUG_BLOCK_STACK_TRACING
stack_trace_print(b->stack_entries, b->stack_len, 1); stack_trace_print(b->stack_entries, b->stack_len, 1);
/* mark unclaimed to avoid BUG_ON below */ /* mark unclaimed to avoid WARN_ON below */
b->hold_count = 0; b->hold_count = 0;
#endif #endif
} }
...@@ -1567,7 +1570,7 @@ static void drop_buffers(struct dm_bufio_client *c) ...@@ -1567,7 +1570,7 @@ static void drop_buffers(struct dm_bufio_client *c)
#endif #endif
for (i = 0; i < LIST_SIZE; i++) for (i = 0; i < LIST_SIZE; i++)
BUG_ON(!list_empty(&c->lru[i])); WARN_ON(!list_empty(&c->lru[i]));
dm_bufio_unlock(c); dm_bufio_unlock(c);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment