Commit bbef56d8 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

bonding: 3ad: pass parameter bond_params by reference

The parameter bond_params is a relatively large 192 byte sized
struct so pass it by reference rather than by value to reduce
copying.

Addresses-Coverity: ("Big parameter passed by value")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1c990729
...@@ -96,7 +96,7 @@ static int ad_marker_send(struct port *port, struct bond_marker *marker); ...@@ -96,7 +96,7 @@ static int ad_marker_send(struct port *port, struct bond_marker *marker);
static void ad_mux_machine(struct port *port, bool *update_slave_arr); static void ad_mux_machine(struct port *port, bool *update_slave_arr);
static void ad_rx_machine(struct lacpdu *lacpdu, struct port *port); static void ad_rx_machine(struct lacpdu *lacpdu, struct port *port);
static void ad_tx_machine(struct port *port); static void ad_tx_machine(struct port *port);
static void ad_periodic_machine(struct port *port, struct bond_params bond_params); static void ad_periodic_machine(struct port *port, struct bond_params *bond_params);
static void ad_port_selection_logic(struct port *port, bool *update_slave_arr); static void ad_port_selection_logic(struct port *port, bool *update_slave_arr);
static void ad_agg_selection_logic(struct aggregator *aggregator, static void ad_agg_selection_logic(struct aggregator *aggregator,
bool *update_slave_arr); bool *update_slave_arr);
...@@ -1298,7 +1298,7 @@ static void ad_tx_machine(struct port *port) ...@@ -1298,7 +1298,7 @@ static void ad_tx_machine(struct port *port)
* *
* Turn ntt flag on priodically to perform periodic transmission of lacpdu's. * Turn ntt flag on priodically to perform periodic transmission of lacpdu's.
*/ */
static void ad_periodic_machine(struct port *port, struct bond_params bond_params) static void ad_periodic_machine(struct port *port, struct bond_params *bond_params)
{ {
periodic_states_t last_state; periodic_states_t last_state;
...@@ -1308,7 +1308,7 @@ static void ad_periodic_machine(struct port *port, struct bond_params bond_param ...@@ -1308,7 +1308,7 @@ static void ad_periodic_machine(struct port *port, struct bond_params bond_param
/* check if port was reinitialized */ /* check if port was reinitialized */
if (((port->sm_vars & AD_PORT_BEGIN) || !(port->sm_vars & AD_PORT_LACP_ENABLED) || !port->is_enabled) || if (((port->sm_vars & AD_PORT_BEGIN) || !(port->sm_vars & AD_PORT_LACP_ENABLED) || !port->is_enabled) ||
(!(port->actor_oper_port_state & LACP_STATE_LACP_ACTIVITY) && !(port->partner_oper.port_state & LACP_STATE_LACP_ACTIVITY)) || (!(port->actor_oper_port_state & LACP_STATE_LACP_ACTIVITY) && !(port->partner_oper.port_state & LACP_STATE_LACP_ACTIVITY)) ||
!bond_params.lacp_active) { !bond_params->lacp_active) {
port->sm_periodic_state = AD_NO_PERIODIC; port->sm_periodic_state = AD_NO_PERIODIC;
} }
/* check if state machine should change state */ /* check if state machine should change state */
...@@ -2342,7 +2342,7 @@ void bond_3ad_state_machine_handler(struct work_struct *work) ...@@ -2342,7 +2342,7 @@ void bond_3ad_state_machine_handler(struct work_struct *work)
} }
ad_rx_machine(NULL, port); ad_rx_machine(NULL, port);
ad_periodic_machine(port, bond->params); ad_periodic_machine(port, &bond->params);
ad_port_selection_logic(port, &update_slave_arr); ad_port_selection_logic(port, &update_slave_arr);
ad_mux_machine(port, &update_slave_arr); ad_mux_machine(port, &update_slave_arr);
ad_tx_machine(port); ad_tx_machine(port);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment