Commit bcbccad6 authored by Stanislav Fomichev's avatar Stanislav Fomichev Committed by Daniel Borkmann

selftests/bpf: bring back (void *) cast to set_ipv4_csum in test_tc_tunnel

It was removed in commit 166b5a7f ("selftests_bpf: extend
test_tc_tunnel for UDP encap") without any explanation.

Otherwise I see:
progs/test_tc_tunnel.c:160:17: warning: taking address of packed member 'ip' of class or structure
      'v4hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
        set_ipv4_csum(&h_outer.ip);
                       ^~~~~~~~~~
1 warning generated.

Cc: Alan Maguire <alan.maguire@oracle.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Fixes: 166b5a7f ("selftests_bpf: extend test_tc_tunnel for UDP encap")
Signed-off-by: default avatarStanislav Fomichev <sdf@google.com>
Acked-by: default avatarSong Liu <songliubraving@fb.com>
Reviewed-by: default avatarAlan Maguire <alan.maguire@oracle.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
parent efb2ddc4
...@@ -157,7 +157,7 @@ static __always_inline int encap_ipv4(struct __sk_buff *skb, __u8 encap_proto, ...@@ -157,7 +157,7 @@ static __always_inline int encap_ipv4(struct __sk_buff *skb, __u8 encap_proto,
bpf_ntohs(h_outer.ip.tot_len)); bpf_ntohs(h_outer.ip.tot_len));
h_outer.ip.protocol = encap_proto; h_outer.ip.protocol = encap_proto;
set_ipv4_csum(&h_outer.ip); set_ipv4_csum((void *)&h_outer.ip);
/* store new outer network header */ /* store new outer network header */
if (bpf_skb_store_bytes(skb, ETH_HLEN, &h_outer, olen, if (bpf_skb_store_bytes(skb, ETH_HLEN, &h_outer, olen,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment