Commit c56c81ab authored by Dan Williams's avatar Dan Williams

dmatest: fix max channels handling

The check for reaching max_channels is short circuited by 'continuing'
after successfully adding a channel.

[ Impact: make the 'max_channels' module parameter actually have an effect ]

Cc: <stable@kernel.org>
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 577c9c45
...@@ -531,9 +531,7 @@ static int __init dmatest_init(void) ...@@ -531,9 +531,7 @@ static int __init dmatest_init(void)
chan = dma_request_channel(mask, filter, NULL); chan = dma_request_channel(mask, filter, NULL);
if (chan) { if (chan) {
err = dmatest_add_channel(chan); err = dmatest_add_channel(chan);
if (err == 0) if (err) {
continue;
else {
dma_release_channel(chan); dma_release_channel(chan);
break; /* add_channel failed, punt */ break; /* add_channel failed, punt */
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment