Commit c685af11 authored by Gabriel Matni's avatar Gabriel Matni Committed by Greg Kroah-Hartman

serial: mvebu-uart: fix tx lost characters

Fixes missing characters on kernel console at low baud rates (i.e.9600).
The driver should poll TX_RDY or TX_FIFO_EMP instead of TX_EMP to ensure
that the transmitter holding register (THR) is ready to receive a new byte.

TX_EMP tells us when it is possible to send a break sequence via
SND_BRK_SEQ. While this also indicates that both the THR and the TSR are
empty, it does not guarantee that a new byte can be written just yet.

Fixes: 30530791 ("serial: mvebu-uart: initial support for Armada-3700 serial port")
Reviewed-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Acked-by: default avatarGregory CLEMENT <gregory.clement@bootlin.com>
Signed-off-by: default avatarGabriel Matni <gabriel.matni@exfo.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7693b331
...@@ -618,7 +618,7 @@ static void wait_for_xmitr(struct uart_port *port) ...@@ -618,7 +618,7 @@ static void wait_for_xmitr(struct uart_port *port)
u32 val; u32 val;
readl_poll_timeout_atomic(port->membase + UART_STAT, val, readl_poll_timeout_atomic(port->membase + UART_STAT, val,
(val & STAT_TX_EMP), 1, 10000); (val & STAT_TX_RDY(port)), 1, 10000);
} }
static void mvebu_uart_console_putchar(struct uart_port *port, int ch) static void mvebu_uart_console_putchar(struct uart_port *port, int ch)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment