Commit c94ccf9e authored by Stefan Richter's avatar Stefan Richter

ieee1394: csr1212: warn on unreachable code

We want bugs to show themselves.
Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent a1c6250c
...@@ -772,6 +772,7 @@ csr1212_generate_positions(struct csr1212_csr_rom_cache *cache, ...@@ -772,6 +772,7 @@ csr1212_generate_positions(struct csr1212_csr_rom_cache *cache,
default: default:
/* Should never get here */ /* Should never get here */
WARN_ON(1);
break; break;
} }
...@@ -852,7 +853,8 @@ csr1212_generate_tree_subdir(struct csr1212_keyval *dir, u32 *data_buffer) ...@@ -852,7 +853,8 @@ csr1212_generate_tree_subdir(struct csr1212_keyval *dir, u32 *data_buffer)
break; break;
default: default:
/* Should never get here */ /* Should never get here */
break; /* GDB breakpoint */ WARN_ON(1);
break;
} }
value |= (a->key.id & CSR1212_KV_KEY_ID_MASK) << value |= (a->key.id & CSR1212_KV_KEY_ID_MASK) <<
...@@ -889,7 +891,8 @@ static void csr1212_fill_cache(struct csr1212_csr_rom_cache *cache) ...@@ -889,7 +891,8 @@ static void csr1212_fill_cache(struct csr1212_csr_rom_cache *cache)
case CSR1212_KV_TYPE_IMMEDIATE: case CSR1212_KV_TYPE_IMMEDIATE:
case CSR1212_KV_TYPE_CSR_OFFSET: case CSR1212_KV_TYPE_CSR_OFFSET:
/* Should never get here */ /* Should never get here */
break; /* GDB breakpoint */ WARN_ON(1);
break;
case CSR1212_KV_TYPE_LEAF: case CSR1212_KV_TYPE_LEAF:
/* Don't copy over Extended ROM areas, they are /* Don't copy over Extended ROM areas, they are
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment