Commit cba45900 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Mark Brown

ASoC: codecs: aw88399: Fix -Wuninitialized in aw_dev_set_vcalb()

Clang warns (or errors with CONFIG_WERROR=y):

  sound/soc/codecs/aw88399.c:441:18: error: variable 'vsense_select' is uninitialized when used here [-Werror,-Wuninitialized]
    441 |         vsense_select = vsense_select & (~AW88399_VDSEL_MASK);
        |                         ^~~~~~~~~~~~~
  sound/soc/codecs/aw88399.c:431:28: note: initialize the variable 'vsense_select' to silence this warning
    431 |         unsigned int vsense_select, vsense_value;
        |                                   ^
        |                                    = 0
  1 error generated.

This clearly should have been using the value received from
regmap_read(). Use the correct variable to resolve the warning.

Closes: https://github.com/ClangBuiltLinux/linux/issues/1952
Fixes: 8ade6cc7 ("ASoC: codecs: Add aw88399 amplifier driver")
Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Reviewed-by: default avatarWeidong Wang <wangweidong.a@awinic.com>
Link: https://lore.kernel.org/r/20231027-asoc-aw88399-fix-wuninitialized-v1-1-b1044493e4cd@kernel.orgSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1a3b7eab
...@@ -438,7 +438,7 @@ static int aw_dev_set_vcalb(struct aw88399 *aw88399) ...@@ -438,7 +438,7 @@ static int aw_dev_set_vcalb(struct aw88399 *aw88399)
if (ret) if (ret)
return ret; return ret;
vsense_select = vsense_select & (~AW88399_VDSEL_MASK); vsense_select = vsense_value & (~AW88399_VDSEL_MASK);
ret = aw88399_dev_get_icalk(aw88399, &icalk); ret = aw88399_dev_get_icalk(aw88399, &icalk);
if (ret) { if (ret) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment