Commit cbb325e7 authored by Alex Williamson's avatar Alex Williamson

vfio/pci: Restore zero affected bus reset devices warning

Yi notes relative to commit f6944d4a ("vfio/pci: Collect hot-reset
devices to local buffer") that we previously tested the resulting
device count with a WARN_ON, which was removed when we switched to
the in-loop user copy in commit b56b7aab ("vfio/pci: Copy hot-reset
device info to userspace in the devices loop").  Finding no devices in
the bus/slot would be an unexpected condition, so let's restore the
warning and trigger a -ERANGE error here as success with no devices
would be an unexpected result to userspace as well.
Suggested-by: default avatarYi Liu <yi.l.liu@intel.com>
Reviewed-by: default avatarCédric Le Goater <clg@redhat.com>
Reviewed-by: default avatarYi Liu <yi.l.liu@intel.com>
Link: https://lore.kernel.org/r/20240516174831.2257970-1-alex.williamson@redhat.comSigned-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent dda057ad
...@@ -1281,6 +1281,9 @@ static int vfio_pci_ioctl_get_pci_hot_reset_info( ...@@ -1281,6 +1281,9 @@ static int vfio_pci_ioctl_get_pci_hot_reset_info(
if (ret) if (ret)
return ret; return ret;
if (WARN_ON(!count)) /* Should always be at least one */
return -ERANGE;
if (count > (hdr.argsz - sizeof(hdr)) / sizeof(*devices)) { if (count > (hdr.argsz - sizeof(hdr)) / sizeof(*devices)) {
hdr.count = count; hdr.count = count;
ret = -ENOSPC; ret = -ENOSPC;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment