Commit cc687c2e authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba

btrfs: remove redundant log root tree index assignment during log sync

During log syncing, when we start updating the log root tree we compute
an index value, stored in variable 'index2', once we lock the log root
tree's mutex. This value depends on the log root's log_transid. And
shortly after we compute again the same value for 'index2' - the value
is exactly the same since we haven't released the mutex and therefore
the log_transid of the log root is the same as before.

This second 'index2' computation became pointless after commit
a93e0168 ("btrfs: remove no longer needed use of log_writers for the
log root tree"). So remove it.
Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent a666ce9b
...@@ -3016,7 +3016,6 @@ int btrfs_sync_log(struct btrfs_trans_handle *trans, ...@@ -3016,7 +3016,6 @@ int btrfs_sync_log(struct btrfs_trans_handle *trans,
goto out; goto out;
} }
index2 = root_log_ctx.log_transid % 2;
if (atomic_read(&log_root_tree->log_commit[index2])) { if (atomic_read(&log_root_tree->log_commit[index2])) {
blk_finish_plug(&plug); blk_finish_plug(&plug);
ret = btrfs_wait_tree_log_extents(log, mark); ret = btrfs_wait_tree_log_extents(log, mark);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment