Commit d5657ec9 authored by Takashi Iwai's avatar Takashi Iwai

ALSA: hda - Disable the sanity check in snd_hda_add_pincfg()

When pin default configs are overridden via patch option, these are
evaluated before fixups are applied.  Since some fixups change the
whole codec trees and/or add pins dynamically, this sanity check might
not pass when pins aren't present at the time the function is called.

We may reorder the execution, but an easier fix is simply to disable
this sanity check.
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 6134b1a2
...@@ -1065,8 +1065,14 @@ int snd_hda_add_pincfg(struct hda_codec *codec, struct snd_array *list, ...@@ -1065,8 +1065,14 @@ int snd_hda_add_pincfg(struct hda_codec *codec, struct snd_array *list,
{ {
struct hda_pincfg *pin; struct hda_pincfg *pin;
/* the check below may be invalid when pins are added by a fixup
* dynamically (e.g. via snd_hda_codec_update_widgets()), so disabled
* for now
*/
/*
if (get_wcaps_type(get_wcaps(codec, nid)) != AC_WID_PIN) if (get_wcaps_type(get_wcaps(codec, nid)) != AC_WID_PIN)
return -EINVAL; return -EINVAL;
*/
pin = look_up_pincfg(codec, list, nid); pin = look_up_pincfg(codec, list, nid);
if (!pin) { if (!pin) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment