Commit ddeacc4f authored by Rafał Miłecki's avatar Rafał Miłecki Committed by David S. Miller

net: broadcom: bcm4908_enet: reset DMA rings sw indexes properly

Resetting software indexes in bcm4908_dma_alloc_buf_descs() is not
enough as it's called during device probe only. Driver resets DMA on
every .ndo_open callback and it's required to reset indexes then.

This fixes inconsistent rings state and stalled traffic after interface
down & up sequence.

Fixes: 4feffead ("net: broadcom: bcm4908enet: add BCM4908 controller driver")
Signed-off-by: default avatarRafał Miłecki <rafal@milecki.pl>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c69f114d
...@@ -174,9 +174,6 @@ static int bcm4908_dma_alloc_buf_descs(struct bcm4908_enet *enet, ...@@ -174,9 +174,6 @@ static int bcm4908_dma_alloc_buf_descs(struct bcm4908_enet *enet,
if (!ring->slots) if (!ring->slots)
goto err_free_buf_descs; goto err_free_buf_descs;
ring->read_idx = 0;
ring->write_idx = 0;
return 0; return 0;
err_free_buf_descs: err_free_buf_descs:
...@@ -304,6 +301,9 @@ static void bcm4908_enet_dma_ring_init(struct bcm4908_enet *enet, ...@@ -304,6 +301,9 @@ static void bcm4908_enet_dma_ring_init(struct bcm4908_enet *enet,
enet_write(enet, ring->st_ram_block + ENET_DMA_CH_STATE_RAM_BASE_DESC_PTR, enet_write(enet, ring->st_ram_block + ENET_DMA_CH_STATE_RAM_BASE_DESC_PTR,
(uint32_t)ring->dma_addr); (uint32_t)ring->dma_addr);
ring->read_idx = 0;
ring->write_idx = 0;
} }
static void bcm4908_enet_dma_uninit(struct bcm4908_enet *enet) static void bcm4908_enet_dma_uninit(struct bcm4908_enet *enet)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment