Commit df73757c authored by Shuah Khan's avatar Shuah Khan Committed by Steven Rostedt (Google)

tools/latency-collector: Fix -Wformat-security compile warns

Fix the following -Wformat-security compile warnings adding missing
format arguments:

latency-collector.c: In function ‘show_available’:
latency-collector.c:938:17: warning: format not a string literal and
no format arguments [-Wformat-security]
  938 |                 warnx(no_tracer_msg);
      |                 ^~~~~

latency-collector.c:943:17: warning: format not a string literal and
no format arguments [-Wformat-security]
  943 |                 warnx(no_latency_tr_msg);
      |                 ^~~~~

latency-collector.c: In function ‘find_default_tracer’:
latency-collector.c:986:25: warning: format not a string literal and
no format arguments [-Wformat-security]
  986 |                         errx(EXIT_FAILURE, no_tracer_msg);
      |
                         ^~~~
latency-collector.c: In function ‘scan_arguments’:
latency-collector.c:1881:33: warning: format not a string literal and
no format arguments [-Wformat-security]
 1881 |                                 errx(EXIT_FAILURE, no_tracer_msg);
      |                                 ^~~~

Link: https://lore.kernel.org/linux-trace-kernel/20240404011009.32945-1-skhan@linuxfoundation.org

Cc: stable@vger.kernel.org
Fixes: e23db805 ("tracing/tools: Add the latency-collector to tools directory")
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 59c22f70
...@@ -935,12 +935,12 @@ static void show_available(void) ...@@ -935,12 +935,12 @@ static void show_available(void)
} }
if (!tracers) { if (!tracers) {
warnx(no_tracer_msg); warnx("%s", no_tracer_msg);
return; return;
} }
if (!found) { if (!found) {
warnx(no_latency_tr_msg); warnx("%s", no_latency_tr_msg);
tracefs_list_free(tracers); tracefs_list_free(tracers);
return; return;
} }
...@@ -983,7 +983,7 @@ static const char *find_default_tracer(void) ...@@ -983,7 +983,7 @@ static const char *find_default_tracer(void)
for (i = 0; relevant_tracers[i]; i++) { for (i = 0; relevant_tracers[i]; i++) {
valid = tracer_valid(relevant_tracers[i], &notracer); valid = tracer_valid(relevant_tracers[i], &notracer);
if (notracer) if (notracer)
errx(EXIT_FAILURE, no_tracer_msg); errx(EXIT_FAILURE, "%s", no_tracer_msg);
if (valid) if (valid)
return relevant_tracers[i]; return relevant_tracers[i];
} }
...@@ -1878,7 +1878,7 @@ static void scan_arguments(int argc, char *argv[]) ...@@ -1878,7 +1878,7 @@ static void scan_arguments(int argc, char *argv[])
} }
valid = tracer_valid(current_tracer, &notracer); valid = tracer_valid(current_tracer, &notracer);
if (notracer) if (notracer)
errx(EXIT_FAILURE, no_tracer_msg); errx(EXIT_FAILURE, "%s", no_tracer_msg);
if (!valid) if (!valid)
errx(EXIT_FAILURE, errx(EXIT_FAILURE,
"The tracer %s is not supported by your kernel!\n", current_tracer); "The tracer %s is not supported by your kernel!\n", current_tracer);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment