Commit e4c397ee authored by Jan Sokolowski's avatar Jan Sokolowski Committed by Doug Ledford

IB/hfi1: Remove unnecessary if check

A for loop condition of data_iovs in user_sdma_free_request
is unnecessarily repeated before the loop as an if check.

Remove the if enveloping the loop.
Reviewed-by: default avatarJakub Byczkowski <jakub.byczkowski@intel.com>
Signed-off-by: default avatarJan Sokolowski <jan.sokolowski@intel.com>
Signed-off-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent d61ea075
...@@ -1428,6 +1428,8 @@ static inline void pq_update(struct hfi1_user_sdma_pkt_q *pq) ...@@ -1428,6 +1428,8 @@ static inline void pq_update(struct hfi1_user_sdma_pkt_q *pq)
static void user_sdma_free_request(struct user_sdma_request *req, bool unpin) static void user_sdma_free_request(struct user_sdma_request *req, bool unpin)
{ {
int i;
if (!list_empty(&req->txps)) { if (!list_empty(&req->txps)) {
struct sdma_txreq *t, *p; struct sdma_txreq *t, *p;
...@@ -1439,22 +1441,20 @@ static void user_sdma_free_request(struct user_sdma_request *req, bool unpin) ...@@ -1439,22 +1441,20 @@ static void user_sdma_free_request(struct user_sdma_request *req, bool unpin)
kmem_cache_free(req->pq->txreq_cache, tx); kmem_cache_free(req->pq->txreq_cache, tx);
} }
} }
if (req->data_iovs) {
struct sdma_mmu_node *node; for (i = 0; i < req->data_iovs; i++) {
int i; struct sdma_mmu_node *node = req->iovs[i].node;
for (i = 0; i < req->data_iovs; i++) { if (!node)
node = req->iovs[i].node; continue;
if (!node)
continue; if (unpin)
hfi1_mmu_rb_remove(req->pq->handler,
if (unpin) &node->rb);
hfi1_mmu_rb_remove(req->pq->handler, else
&node->rb); atomic_dec(&node->refcount);
else
atomic_dec(&node->refcount);
}
} }
kfree(req->tids); kfree(req->tids);
clear_bit(req->info.comp_idx, req->pq->req_in_use); clear_bit(req->info.comp_idx, req->pq->req_in_use);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment