Commit e5467359 authored by Brian Norris's avatar Brian Norris Committed by Heiko Stuebner

arm64: dts: rockchip: Pull up wlan wake# on Gru-Bob

The Gru-Bob board does not have a pull-up resistor on its
WLAN_HOST_WAKE# pin, but Kevin does. The production/vendor kernel
specified the pin configuration correctly as a pull-up, but this didn't
get ported correctly to upstream.

This means Bob's WLAN_HOST_WAKE# pin is floating, causing inconsistent
wakeup behavior.

Note that bt_host_wake_l has a similar dynamic, but apparently the
upstream choice was to redundantly configure both internal and external
pull-up on Kevin (see the "Kevin has an external pull up" comment in
rk3399-gru.dtsi). This doesn't cause any functional problem, although
it's perhaps wasteful.

Fixes: 8559bbee ("arm64: dts: rockchip: add Google Bob")
Signed-off-by: default avatarBrian Norris <briannorris@chromium.org>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20220822164453.1.I75c57b48b0873766ec993bdfb7bc1e63da5a1637@changeidSigned-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
parent 1ea90b2d
...@@ -88,3 +88,8 @@ h1_int_od_l: h1-int-od-l { ...@@ -88,3 +88,8 @@ h1_int_od_l: h1-int-od-l {
}; };
}; };
}; };
&wlan_host_wake_l {
/* Kevin has an external pull up, but Bob does not. */
rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
};
...@@ -578,6 +578,7 @@ wifi_perst_l: wifi-perst-l { ...@@ -578,6 +578,7 @@ wifi_perst_l: wifi-perst-l {
}; };
wlan_host_wake_l: wlan-host-wake-l { wlan_host_wake_l: wlan-host-wake-l {
/* Kevin has an external pull up, but Bob does not */
rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
}; };
}; };
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment