Commit e90285e0 authored by Philipp Reisner's avatar Philipp Reisner

drbd: Fixed conn_lowest_minor

It actually returned the lowest volume number. While doing that
renamed a few wrongly named variables.
Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
parent f399002e
...@@ -434,7 +434,7 @@ void tl_clear(struct drbd_tconn *tconn) ...@@ -434,7 +434,7 @@ void tl_clear(struct drbd_tconn *tconn)
struct drbd_conf *mdev; struct drbd_conf *mdev;
struct list_head *le, *tle; struct list_head *le, *tle;
struct drbd_request *r; struct drbd_request *r;
int minor; int vnr;
spin_lock_irq(&tconn->req_lock); spin_lock_irq(&tconn->req_lock);
...@@ -453,7 +453,7 @@ void tl_clear(struct drbd_tconn *tconn) ...@@ -453,7 +453,7 @@ void tl_clear(struct drbd_tconn *tconn)
} }
/* ensure bit indicating barrier is required is clear */ /* ensure bit indicating barrier is required is clear */
idr_for_each_entry(&tconn->volumes, mdev, minor) idr_for_each_entry(&tconn->volumes, mdev, vnr)
clear_bit(CREATE_BARRIER, &mdev->flags); clear_bit(CREATE_BARRIER, &mdev->flags);
spin_unlock_irq(&tconn->req_lock); spin_unlock_irq(&tconn->req_lock);
...@@ -634,11 +634,13 @@ char *drbd_task_to_thread_name(struct drbd_tconn *tconn, struct task_struct *tas ...@@ -634,11 +634,13 @@ char *drbd_task_to_thread_name(struct drbd_tconn *tconn, struct task_struct *tas
int conn_lowest_minor(struct drbd_tconn *tconn) int conn_lowest_minor(struct drbd_tconn *tconn)
{ {
int minor = 0; int vnr = 0;
struct drbd_conf *mdev;
if (!idr_get_next(&tconn->volumes, &minor)) mdev = idr_get_next(&tconn->volumes, &vnr);
if (!mdev)
return -1; return -1;
return minor; return mdev_to_minor(mdev);
} }
#ifdef CONFIG_SMP #ifdef CONFIG_SMP
......
...@@ -326,9 +326,9 @@ int drbd_khelper(struct drbd_conf *mdev, char *cmd) ...@@ -326,9 +326,9 @@ int drbd_khelper(struct drbd_conf *mdev, char *cmd)
static void conn_md_sync(struct drbd_tconn *tconn) static void conn_md_sync(struct drbd_tconn *tconn)
{ {
struct drbd_conf *mdev; struct drbd_conf *mdev;
int minor; int vnr;
idr_for_each_entry(&tconn->volumes, mdev, minor) idr_for_each_entry(&tconn->volumes, mdev, vnr)
drbd_md_sync(mdev); drbd_md_sync(mdev);
} }
......
...@@ -50,9 +50,9 @@ static union drbd_state sanitize_state(struct drbd_conf *mdev, union drbd_state ...@@ -50,9 +50,9 @@ static union drbd_state sanitize_state(struct drbd_conf *mdev, union drbd_state
bool conn_all_vols_unconf(struct drbd_tconn *tconn) bool conn_all_vols_unconf(struct drbd_tconn *tconn)
{ {
struct drbd_conf *mdev; struct drbd_conf *mdev;
int minor; int vnr;
idr_for_each_entry(&tconn->volumes, mdev, minor) { idr_for_each_entry(&tconn->volumes, mdev, vnr) {
if (mdev->state.disk != D_DISKLESS || if (mdev->state.disk != D_DISKLESS ||
mdev->state.conn != C_STANDALONE || mdev->state.conn != C_STANDALONE ||
mdev->state.role != R_SECONDARY) mdev->state.role != R_SECONDARY)
...@@ -332,9 +332,9 @@ static void print_state_change(struct drbd_conf *mdev, union drbd_state os, unio ...@@ -332,9 +332,9 @@ static void print_state_change(struct drbd_conf *mdev, union drbd_state os, unio
static bool vol_has_primary_peer(struct drbd_tconn *tconn) static bool vol_has_primary_peer(struct drbd_tconn *tconn)
{ {
struct drbd_conf *mdev; struct drbd_conf *mdev;
int minor; int vnr;
idr_for_each_entry(&tconn->volumes, mdev, minor) { idr_for_each_entry(&tconn->volumes, mdev, vnr) {
if (mdev->state.peer == R_PRIMARY) if (mdev->state.peer == R_PRIMARY)
return true; return true;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment