Commit e9ddb1ad authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Vinod Koul

phy: cadence: phy-cadence-sierra: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-5-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 7b23fd5c
...@@ -1513,7 +1513,7 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev) ...@@ -1513,7 +1513,7 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int cdns_sierra_phy_remove(struct platform_device *pdev) static void cdns_sierra_phy_remove(struct platform_device *pdev)
{ {
struct cdns_sierra_phy *phy = platform_get_drvdata(pdev); struct cdns_sierra_phy *phy = platform_get_drvdata(pdev);
int i; int i;
...@@ -1533,8 +1533,6 @@ static int cdns_sierra_phy_remove(struct platform_device *pdev) ...@@ -1533,8 +1533,6 @@ static int cdns_sierra_phy_remove(struct platform_device *pdev)
} }
cdns_sierra_clk_unregister(phy); cdns_sierra_clk_unregister(phy);
return 0;
} }
/* QSGMII PHY PMA lane configuration */ /* QSGMII PHY PMA lane configuration */
...@@ -2520,7 +2518,7 @@ MODULE_DEVICE_TABLE(of, cdns_sierra_id_table); ...@@ -2520,7 +2518,7 @@ MODULE_DEVICE_TABLE(of, cdns_sierra_id_table);
static struct platform_driver cdns_sierra_driver = { static struct platform_driver cdns_sierra_driver = {
.probe = cdns_sierra_phy_probe, .probe = cdns_sierra_phy_probe,
.remove = cdns_sierra_phy_remove, .remove_new = cdns_sierra_phy_remove,
.driver = { .driver = {
.name = "cdns-sierra-phy", .name = "cdns-sierra-phy",
.of_match_table = cdns_sierra_id_table, .of_match_table = cdns_sierra_id_table,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment