Commit eb55b5b4 authored by Kristina Martšenko's avatar Kristina Martšenko Committed by Greg Kroah-Hartman

staging: sbe-2t3e3: remove t3e3_resp_t typedef

Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_resp_t typedef.

Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/ctrl.h:123: WARNING: do not add new typedefs
Signed-off-by: default avatarKristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c6a297bc
...@@ -760,8 +760,7 @@ void t3e3_init(struct channel *); ...@@ -760,8 +760,7 @@ void t3e3_init(struct channel *);
void t3e3_if_up(struct channel *); void t3e3_if_up(struct channel *);
void t3e3_if_down(struct channel *); void t3e3_if_down(struct channel *);
int t3e3_if_start_xmit(struct sk_buff *skb, struct net_device *dev); int t3e3_if_start_xmit(struct sk_buff *skb, struct net_device *dev);
void t3e3_if_config(struct channel *, u32, char *, void t3e3_if_config(struct channel *, u32, char *, struct t3e3_resp *, int *);
t3e3_resp_t *, int *);
void t3e3_set_frame_type(struct channel *, u32); void t3e3_set_frame_type(struct channel *, u32);
u32 t3e3_eeprom_read_word(struct channel *, u32); u32 t3e3_eeprom_read_word(struct channel *, u32);
void t3e3_read_card_serial_number(struct channel *); void t3e3_read_card_serial_number(struct channel *);
......
...@@ -287,7 +287,7 @@ static void t3e3_port_del_stats(struct channel *sc) ...@@ -287,7 +287,7 @@ static void t3e3_port_del_stats(struct channel *sc)
} }
void t3e3_if_config(struct channel *sc, u32 cmd, char *set, void t3e3_if_config(struct channel *sc, u32 cmd, char *set,
t3e3_resp_t *ret, int *rlen) struct t3e3_resp *ret, int *rlen)
{ {
struct t3e3_param *param = (struct t3e3_param *)set; struct t3e3_param *param = (struct t3e3_param *)set;
u32 *data = (u32 *)set; u32 *data = (u32 *)set;
......
...@@ -120,12 +120,12 @@ struct t3e3_stats { ...@@ -120,12 +120,12 @@ struct t3e3_stats {
}; };
typedef struct t3e3_resp { struct t3e3_resp {
union { union {
struct t3e3_param param; struct t3e3_param param;
struct t3e3_stats stats; struct t3e3_stats stats;
u32 data; u32 data;
} u; } u;
} t3e3_resp_t; };
#endif /* CTRL_H */ #endif /* CTRL_H */
...@@ -26,7 +26,7 @@ static int t3e3_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) ...@@ -26,7 +26,7 @@ static int t3e3_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
struct channel *sc = dev_to_priv(dev); struct channel *sc = dev_to_priv(dev);
int cmd_2t3e3, len, rlen; int cmd_2t3e3, len, rlen;
struct t3e3_param param; struct t3e3_param param;
t3e3_resp_t resp; struct t3e3_resp resp;
void __user *data = ifr->ifr_data + sizeof(cmd_2t3e3) + sizeof(len); void __user *data = ifr->ifr_data + sizeof(cmd_2t3e3) + sizeof(len);
if (cmd == SIOCWANDEV) if (cmd == SIOCWANDEV)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment