Commit ece68db9 authored by Damien Le Moal's avatar Damien Le Moal

ata: pata_parport: Fix ktti module code indentation and style

Fix the header, indentation and coding style in the ktti pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.

No functional changes.
Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
parent 65db10ca
/* // SPDX-License-Identifier: GPL-2.0-or-later
ktti.c (c) 1998 Grant R. Guenther <grant@torque.net> /*
Under the terms of the GNU General Public License. * (c) 1998 Grant R. Guenther <grant@torque.net>
*
ktti.c is a low-level protocol driver for the KT Technology * ktti.c is a low-level protocol driver for the KT Technology
parallel port adapter. This adapter is used in the "PHd" * parallel port adapter. This adapter is used in the "PHd"
portable hard-drives. As far as I can tell, this device * portable hard-drives. As far as I can tell, this device
supports 4-bit mode _only_. * supports 4-bit mode _only_.
*/ */
#include <linux/module.h> #include <linux/module.h>
...@@ -18,80 +17,76 @@ ...@@ -18,80 +17,76 @@
#include <asm/io.h> #include <asm/io.h>
#include "pata_parport.h" #include "pata_parport.h"
#define j44(a,b) (((a>>4)&0x0f)|(b&0xf0)) #define j44(a, b) (((a >> 4) & 0x0f) | (b & 0xf0))
/* cont = 0 - access the IDE register file /*
cont = 1 - access the IDE command set * cont = 0 - access the IDE register file
*/ * cont = 1 - access the IDE command set
*/
static int cont_map[2] = { 0x10, 0x08 }; static int cont_map[2] = { 0x10, 0x08 };
static void ktti_write_regr(struct pi_adapter *pi, int cont, int regr, int val) static void ktti_write_regr(struct pi_adapter *pi, int cont, int regr, int val)
{
int r = regr + cont_map[cont];
{ int r; w0(r); w2(0xb); w2(0xa); w2(3); w2(6);
r = regr + cont_map[cont];
w0(r); w2(0xb); w2(0xa); w2(3); w2(6);
w0(val); w2(3); w0(0); w2(6); w2(0xb); w0(val); w2(3); w0(0); w2(6); w2(0xb);
} }
static int ktti_read_regr(struct pi_adapter *pi, int cont, int regr) static int ktti_read_regr(struct pi_adapter *pi, int cont, int regr)
{
{ int a, b, r; int a, b, r;
r = regr + cont_map[cont]; r = regr + cont_map[cont];
w0(r); w2(0xb); w2(0xa); w2(9); w2(0xc); w2(9); w0(r); w2(0xb); w2(0xa); w2(9); w2(0xc); w2(9);
a = r1(); w2(0xc); b = r1(); w2(9); w2(0xc); w2(9); a = r1(); w2(0xc); b = r1(); w2(9); w2(0xc); w2(9);
return j44(a,b); return j44(a, b);
} }
static void ktti_read_block(struct pi_adapter *pi, char *buf, int count) static void ktti_read_block(struct pi_adapter *pi, char *buf, int count)
{
int k, a, b;
{ int k, a, b; for (k = 0; k < count / 2; k++) {
for (k=0;k<count/2;k++) {
w0(0x10); w2(0xb); w2(0xa); w2(9); w2(0xc); w2(9); w0(0x10); w2(0xb); w2(0xa); w2(9); w2(0xc); w2(9);
a = r1(); w2(0xc); b = r1(); w2(9); a = r1(); w2(0xc); b = r1(); w2(9);
buf[2*k] = j44(a,b); buf[2*k] = j44(a, b);
a = r1(); w2(0xc); b = r1(); w2(9); a = r1(); w2(0xc); b = r1(); w2(9);
buf[2*k+1] = j44(a,b); buf[2*k+1] = j44(a, b);
} }
} }
static void ktti_write_block(struct pi_adapter *pi, char *buf, int count) static void ktti_write_block(struct pi_adapter *pi, char *buf, int count)
{
int k;
{ int k; for (k = 0; k < count / 2; k++) {
for (k=0;k<count/2;k++) {
w0(0x10); w2(0xb); w2(0xa); w2(3); w2(6); w0(0x10); w2(0xb); w2(0xa); w2(3); w2(6);
w0(buf[2*k]); w2(3); w0(buf[2 * k]); w2(3);
w0(buf[2*k+1]); w2(6); w0(buf[2 * k + 1]); w2(6);
w2(0xb); w2(0xb);
} }
} }
static void ktti_connect(struct pi_adapter *pi) static void ktti_connect(struct pi_adapter *pi)
{
{ pi->saved_r0 = r0(); pi->saved_r0 = r0();
pi->saved_r2 = r2(); pi->saved_r2 = r2();
w2(0xb); w2(0xa); w0(0); w2(3); w2(6); w2(0xb); w2(0xa); w0(0); w2(3); w2(6);
} }
static void ktti_disconnect(struct pi_adapter *pi) static void ktti_disconnect(struct pi_adapter *pi)
{
{ w2(0xb); w2(0xa); w0(0xa0); w2(3); w2(4); w2(0xb); w2(0xa); w0(0xa0); w2(3); w2(4);
w0(pi->saved_r0); w0(pi->saved_r0);
w2(pi->saved_r2); w2(pi->saved_r2);
} }
static void ktti_log_adapter(struct pi_adapter *pi) static void ktti_log_adapter(struct pi_adapter *pi)
{ {
dev_info(&pi->dev, "KT adapter at 0x%x, delay %d\n", dev_info(&pi->dev, "KT adapter at 0x%x, delay %d\n",
pi->port, pi->delay); pi->port, pi->delay);
} }
static struct pi_protocol ktti = { static struct pi_protocol ktti = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment