Commit edd66086 authored by Takashi Iwai's avatar Takashi Iwai Committed by Rafael J. Wysocki

ACPI: PCI: Use scnprintf() for avoiding potential buffer overflow

Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit.  Fix it by replacing with scnprintf().
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 2c523b34
...@@ -153,7 +153,7 @@ static void decode_osc_bits(struct acpi_pci_root *root, char *msg, u32 word, ...@@ -153,7 +153,7 @@ static void decode_osc_bits(struct acpi_pci_root *root, char *msg, u32 word,
buf[0] = '\0'; buf[0] = '\0';
for (i = 0, entry = table; i < size; i++, entry++) for (i = 0, entry = table; i < size; i++, entry++)
if (word & entry->bit) if (word & entry->bit)
len += snprintf(buf + len, sizeof(buf) - len, "%s%s", len += scnprintf(buf + len, sizeof(buf) - len, "%s%s",
len ? " " : "", entry->desc); len ? " " : "", entry->desc);
dev_info(&root->device->dev, "_OSC: %s [%s]\n", msg, buf); dev_info(&root->device->dev, "_OSC: %s [%s]\n", msg, buf);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment