Commit ee7860cd authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Neil Armstrong

drm/panel: ilitek-ili9881c: Fix warning with GPIO controllers that sleep

The ilitek-ili9881c controls the reset GPIO using the non-sleeping
gpiod_set_value() function. This complains loudly when the GPIO
controller needs to sleep. As the caller can sleep, use
gpiod_set_value_cansleep() to fix the issue.
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20240317154839.21260-1-laurent.pinchart@ideasonboard.comSigned-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240317154839.21260-1-laurent.pinchart@ideasonboard.com
parent 9fb8aaff
...@@ -1276,10 +1276,10 @@ static int ili9881c_prepare(struct drm_panel *panel) ...@@ -1276,10 +1276,10 @@ static int ili9881c_prepare(struct drm_panel *panel)
msleep(5); msleep(5);
/* And reset it */ /* And reset it */
gpiod_set_value(ctx->reset, 1); gpiod_set_value_cansleep(ctx->reset, 1);
msleep(20); msleep(20);
gpiod_set_value(ctx->reset, 0); gpiod_set_value_cansleep(ctx->reset, 0);
msleep(20); msleep(20);
for (i = 0; i < ctx->desc->init_length; i++) { for (i = 0; i < ctx->desc->init_length; i++) {
...@@ -1334,7 +1334,7 @@ static int ili9881c_unprepare(struct drm_panel *panel) ...@@ -1334,7 +1334,7 @@ static int ili9881c_unprepare(struct drm_panel *panel)
mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); mipi_dsi_dcs_enter_sleep_mode(ctx->dsi);
regulator_disable(ctx->power); regulator_disable(ctx->power);
gpiod_set_value(ctx->reset, 1); gpiod_set_value_cansleep(ctx->reset, 1);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment