Commit f34fd6ee authored by Emil Renner Berthing's avatar Emil Renner Berthing Committed by Bartosz Golaszewski

gpio: dwapb: Use generic request, free and set_config

This way GPIO will be denied on pins already claimed by other devices
and basic pin configuration (pull-up, pull-down etc.) can be done
through the userspace GPIO API.
Signed-off-by: default avatarEmil Renner Berthing <emil.renner.berthing@canonical.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 513246a3
...@@ -416,11 +416,12 @@ static int dwapb_gpio_set_config(struct gpio_chip *gc, unsigned offset, ...@@ -416,11 +416,12 @@ static int dwapb_gpio_set_config(struct gpio_chip *gc, unsigned offset,
{ {
u32 debounce; u32 debounce;
if (pinconf_to_config_param(config) != PIN_CONFIG_INPUT_DEBOUNCE) if (pinconf_to_config_param(config) == PIN_CONFIG_INPUT_DEBOUNCE) {
return -ENOTSUPP;
debounce = pinconf_to_config_argument(config); debounce = pinconf_to_config_argument(config);
return dwapb_gpio_set_debounce(gc, offset, debounce); return dwapb_gpio_set_debounce(gc, offset, debounce);
}
return gpiochip_generic_config(gc, offset, config);
} }
static int dwapb_convert_irqs(struct dwapb_gpio_port_irqchip *pirq, static int dwapb_convert_irqs(struct dwapb_gpio_port_irqchip *pirq,
...@@ -530,10 +531,14 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio, ...@@ -530,10 +531,14 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
port->gc.fwnode = pp->fwnode; port->gc.fwnode = pp->fwnode;
port->gc.ngpio = pp->ngpio; port->gc.ngpio = pp->ngpio;
port->gc.base = pp->gpio_base; port->gc.base = pp->gpio_base;
port->gc.request = gpiochip_generic_request;
port->gc.free = gpiochip_generic_free;
/* Only port A support debounce */ /* Only port A support debounce */
if (pp->idx == 0) if (pp->idx == 0)
port->gc.set_config = dwapb_gpio_set_config; port->gc.set_config = dwapb_gpio_set_config;
else
port->gc.set_config = gpiochip_generic_config;
/* Only port A can provide interrupts in all configurations of the IP */ /* Only port A can provide interrupts in all configurations of the IP */
if (pp->idx == 0) if (pp->idx == 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment