Commit f53d77e1 authored by Xin Long's avatar Xin Long Committed by David S. Miller

sctp: reset ret in again path in sctp_for_each_transport

Commit 97a6ec4a ("rhashtable: Change rhashtable_walk_start to
return void") only initialized ret for the first time, when going
to again path, the next tsp could be NULL. Without resetting ret,
cb_done would be called with tsp as NULL.

A kernel crash was caused by this when running sctpdiag testcase
in sctp-tests.

Note that this issue doesn't affect net.git yet.

Fixes: 97a6ec4a ("rhashtable: Change rhashtable_walk_start to return void")
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Acked-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: default avatarNeil Horman <nhorman@tuxdriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 196709f4
...@@ -4860,9 +4860,10 @@ int sctp_for_each_transport(int (*cb)(struct sctp_transport *, void *), ...@@ -4860,9 +4860,10 @@ int sctp_for_each_transport(int (*cb)(struct sctp_transport *, void *),
struct net *net, int *pos, void *p) { struct net *net, int *pos, void *p) {
struct rhashtable_iter hti; struct rhashtable_iter hti;
struct sctp_transport *tsp; struct sctp_transport *tsp;
int ret = 0; int ret;
again: again:
ret = 0;
sctp_transport_walk_start(&hti); sctp_transport_walk_start(&hti);
tsp = sctp_transport_get_idx(net, &hti, *pos + 1); tsp = sctp_transport_get_idx(net, &hti, *pos + 1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment