Commit f69a10f8 authored by Shuming Fan's avatar Shuming Fan Committed by Mark Brown

ASoC: rt711-sdca: fix kernel NULL pointer dereference when IO error

The initial settings will be written before the codec probe function.
But, the rt711->component doesn't be assigned yet.
If IO error happened during initial settings operations, it will cause the kernel panic.
This patch changed component->dev to slave->dev to fix this issue.
Signed-off-by: default avatarShuming Fan <shumingf@realtek.com>
Link: https://lore.kernel.org/r/20220621090719.30558-1-shumingf@realtek.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 87912e97
...@@ -34,7 +34,7 @@ static int rt711_sdca_index_write(struct rt711_sdca_priv *rt711, ...@@ -34,7 +34,7 @@ static int rt711_sdca_index_write(struct rt711_sdca_priv *rt711,
ret = regmap_write(regmap, addr, value); ret = regmap_write(regmap, addr, value);
if (ret < 0) if (ret < 0)
dev_err(rt711->component->dev, dev_err(&rt711->slave->dev,
"Failed to set private value: %06x <= %04x ret=%d\n", "Failed to set private value: %06x <= %04x ret=%d\n",
addr, value, ret); addr, value, ret);
...@@ -50,7 +50,7 @@ static int rt711_sdca_index_read(struct rt711_sdca_priv *rt711, ...@@ -50,7 +50,7 @@ static int rt711_sdca_index_read(struct rt711_sdca_priv *rt711,
ret = regmap_read(regmap, addr, value); ret = regmap_read(regmap, addr, value);
if (ret < 0) if (ret < 0)
dev_err(rt711->component->dev, dev_err(&rt711->slave->dev,
"Failed to get private value: %06x => %04x ret=%d\n", "Failed to get private value: %06x => %04x ret=%d\n",
addr, *value, ret); addr, *value, ret);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment