Commit f7d62366 authored by Linus Walleij's avatar Linus Walleij Committed by Lee Jones

mfd: htc-egpio: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Philipp Zabel <philipp.zabel@gmail.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 2d5f72b8
...@@ -163,7 +163,7 @@ static int egpio_get(struct gpio_chip *chip, unsigned offset) ...@@ -163,7 +163,7 @@ static int egpio_get(struct gpio_chip *chip, unsigned offset)
value = egpio_readw(ei, reg); value = egpio_readw(ei, reg);
pr_debug("readw(%p + %x) = %x\n", pr_debug("readw(%p + %x) = %x\n",
ei->base_addr, reg << ei->bus_shift, value); ei->base_addr, reg << ei->bus_shift, value);
return value & bit; return !!(value & bit);
} }
static int egpio_direction_input(struct gpio_chip *chip, unsigned offset) static int egpio_direction_input(struct gpio_chip *chip, unsigned offset)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment