Commit f9fc28a8 authored by Amol Grover's avatar Amol Grover Committed by David S. Miller

net: caif: Add lockdep expression to RCU traversal primitive

caifdevs->list is traversed using list_for_each_entry_rcu()
outside an RCU read-side critical section but under the
protection of rtnl_mutex. Hence, add the corresponding lockdep
expression to silence the following false-positive warning:

[   10.868467] =============================
[   10.869082] WARNING: suspicious RCU usage
[   10.869817] 5.6.0-rc1-00177-g06ec0a154aae4 #1 Not tainted
[   10.870804] -----------------------------
[   10.871557] net/caif/caif_dev.c:115 RCU-list traversed in non-reader section!!
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarAmol Grover <frextrite@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent eecba79e
...@@ -112,7 +112,8 @@ static struct caif_device_entry *caif_get(struct net_device *dev) ...@@ -112,7 +112,8 @@ static struct caif_device_entry *caif_get(struct net_device *dev)
caif_device_list(dev_net(dev)); caif_device_list(dev_net(dev));
struct caif_device_entry *caifd; struct caif_device_entry *caifd;
list_for_each_entry_rcu(caifd, &caifdevs->list, list) { list_for_each_entry_rcu(caifd, &caifdevs->list, list,
lockdep_rtnl_is_held()) {
if (caifd->netdev == dev) if (caifd->netdev == dev)
return caifd; return caifd;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment