Commit fb50aacd authored by Vardan Mikayelyan's avatar Vardan Mikayelyan Committed by Felipe Balbi

usb: dwc2: pci: Move devm_kzalloc() before platform_device_add()

After platform_device_add(), if we error out, we must do
platform_device_unregister(), which also does the put. So lets move
devm_kzalloc() to simplify error handling and avoid calling of
platform_device_unregister().
Acked-by: default avatarJohn Youn <johnyoun@synopsys.com>
Signed-off-by: default avatarVardan Mikayelyan <mvardan@synopsys.com>
Signed-off-by: default avatarJohn Youn <johnyoun@synopsys.com>
Signed-off-by: default avatarGrigor Tovmasyan <tovmasya@synopsys.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent a127cccd
...@@ -140,16 +140,16 @@ static int dwc2_pci_probe(struct pci_dev *pci, ...@@ -140,16 +140,16 @@ static int dwc2_pci_probe(struct pci_dev *pci,
if (ret) if (ret)
goto err; goto err;
glue = devm_kzalloc(dev, sizeof(*glue), GFP_KERNEL);
if (!glue)
return -ENOMEM;
ret = platform_device_add(dwc2); ret = platform_device_add(dwc2);
if (ret) { if (ret) {
dev_err(dev, "failed to register dwc2 device\n"); dev_err(dev, "failed to register dwc2 device\n");
goto err; goto err;
} }
glue = devm_kzalloc(dev, sizeof(*glue), GFP_KERNEL);
if (!glue)
return -ENOMEM;
glue->phy = phy; glue->phy = phy;
glue->dwc2 = dwc2; glue->dwc2 = dwc2;
pci_set_drvdata(pci, glue); pci_set_drvdata(pci, glue);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment