1. 02 Apr, 2024 4 commits
    • Luke D. Jones's avatar
      ALSA: hda/realtek: cs35l41: Support ASUS ROG G634JYR · 0bfe1050
      Luke D. Jones authored
      Fixes the realtek quirk to initialise the Cirrus amp correctly and adds
      related quirk for missing DSD properties. This model laptop has slightly
      updated internals compared to the previous version with Realtek Codec
      ID of 0x1caf.
      Signed-off-by: default avatarLuke D. Jones <luke@ljones.dev>
      Cc: <stable@vger.kernel.org>
      Message-ID: <20240402015126.21115-1-luke@ljones.dev>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      0bfe1050
    • I Gede Agastya Darma Laksana's avatar
      ALSA: hda/realtek: Update Panasonic CF-SZ6 quirk to support headset with microphone · 1576f263
      I Gede Agastya Darma Laksana authored
      This patch addresses an issue with the Panasonic CF-SZ6's existing quirk,
      specifically its headset microphone functionality. Previously, the quirk
      used ALC269_FIXUP_HEADSET_MODE, which does not support the CF-SZ6's design
      of a single 3.5mm jack for both mic and audio output effectively. The
      device uses pin 0x19 for the headset mic without jack detection.
      
      Following verification on the CF-SZ6 and discussions with the original
      patch author, i determined that the update to
      ALC269_FIXUP_ASPIRE_HEADSET_MIC is the appropriate solution. This change
      is custom-designed for the CF-SZ6's unique hardware setup, which includes
      a single 3.5mm jack for both mic and audio output, connecting the headset
      microphone to pin 0x19 without the use of jack detection.
      
      Fixes: 0fca97a2 ("ALSA: hda/realtek - Add Panasonic CF-SZ6 headset jack quirk")
      Signed-off-by: default avatarI Gede Agastya Darma Laksana <gedeagas22@gmail.com>
      Cc: <stable@vger.kernel.org>
      Message-ID: <20240401174602.14133-1-gedeagas22@gmail.com>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      1576f263
    • Christian Bendiksen's avatar
      ALSA: hda/realtek: Add sound quirks for Lenovo Legion slim 7 16ARHA7 models · b67a7dc4
      Christian Bendiksen authored
      This fixes the sound not working from internal speakers on
      Lenovo Legion Slim 7 16ARHA7 models. The correct subsystem ID
      have been added to cs35l41_hda_property.c and patch_realtek.c.
      Signed-off-by: default avatarChristian Bendiksen <christian@bendiksen.me>
      Cc: <stable@vger.kernel.org>
      Message-ID: <20240401122603.6634-1-christian@bendiksen.me>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      b67a7dc4
    • Oswald Buddenhagen's avatar
      Revert "ALSA: emu10k1: fix synthesizer sample playback position and caching" · 03f56ed4
      Oswald Buddenhagen authored
      As already anticipated in the original commit, playback was broken for
      very short samples. I just didn't expect it to be an actual problem,
      because we're talking about less than 1.5 milliseconds here. But clearly
      such wavetable samples do actually exist.
      
      The problem was that for such short samples we'd set the current
      position beyond the end of the loop, so we'd run off the end of the
      sample and play garbage.
      This is a bigger (more audible) problem than the original one, which was
      that we'd start playback with garbage (whatever was still in the cache),
      which would be mostly masked by the note's attack phase.
      
      So revert to the old behavior for now. We'll subsequently fix it
      properly with a bigger patch series.
      Note that this isn't a full revert - the dead code is not re-introduced,
      because that would be silly.
      
      Fixes: df335e9a ("ALSA: emu10k1: fix synthesizer sample playback position and caching")
      Link: https://bugzilla.kernel.org/show_bug.cgi?id=218625Signed-off-by: default avatarOswald Buddenhagen <oswald.buddenhagen@gmx.de>
      Message-ID: <20240401145805.528794-1-oswald.buddenhagen@gmx.de>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      03f56ed4
  2. 01 Apr, 2024 1 commit
  3. 30 Mar, 2024 1 commit
  4. 29 Mar, 2024 1 commit
  5. 28 Mar, 2024 2 commits
  6. 27 Mar, 2024 5 commits
    • Gergo Koteles's avatar
      ALSA: hda/tas2781: remove useless dev_dbg from playback_hook · 1506d961
      Gergo Koteles authored
      The debug message "Playback action not supported: action" is not useful,
      because the action was previously printed, and the list of supported
      actions are intentional.
      
      Remove the debug statement from the default switch case.
      Signed-off-by: default avatarGergo Koteles <soyer@irl.hu>
      Message-ID: <8b9546db6c92dea4476a7247a88d56248c2ba8c2.1711469583.git.soyer@irl.hu>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      1506d961
    • Gergo Koteles's avatar
      ALSA: hda/tas2781: add debug statements to kcontrols · 26c04a8a
      Gergo Koteles authored
      Sometimes it is useful to examine the timing of kcontrol events.
      
      Add debug statements to each kcontrol.
      Signed-off-by: default avatarGergo Koteles <soyer@irl.hu>
      Message-ID: <18ff4b0caab90a2dacf907e62346fd5079a9eb1a.1711469583.git.soyer@irl.hu>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      26c04a8a
    • Gergo Koteles's avatar
      ALSA: hda/tas2781: add locks to kcontrols · 15bc3066
      Gergo Koteles authored
      The rcabin.profile_cfg_id, cur_prog, cur_conf, force_fwload_status
      variables are acccessible from multiple threads and therefore require
      locking.
      
      Fixes: 5be27f1e ("ALSA: hda/tas2781: Add tas2781 HDA driver")
      CC: stable@vger.kernel.org
      Signed-off-by: default avatarGergo Koteles <soyer@irl.hu>
      Message-ID: <e35b867f6fe5fa1f869dd658a0a1f2118b737f57.1711469583.git.soyer@irl.hu>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      15bc3066
    • Gergo Koteles's avatar
      ALSA: hda/tas2781: remove digital gain kcontrol · ae065d0c
      Gergo Koteles authored
      The "Speaker Digital Gain" kcontrol controls the TAS2781_DVC_LVL (0x1A)
      register. Unfortunately the tas2563 does not have DVC_LVL, but has
      INT_MASK0 in 0x1A, which has been misused so far.
      
      Since commit c1947ce6 ("ALSA: hda/realtek: tas2781: enable subwoofer
      volume control") the volume of the tas2781 amplifiers can be controlled
      by the master volume, so this digital gain kcontrol is not needed.
      
      Remove it.
      
      Fixes: 5be27f1e ("ALSA: hda/tas2781: Add tas2781 HDA driver")
      CC: stable@vger.kernel.org
      Signed-off-by: default avatarGergo Koteles <soyer@irl.hu>
      Message-ID: <741fc21db994efd58f83e7aef38931204961e5b2.1711469583.git.soyer@irl.hu>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      ae065d0c
    • Arnd Bergmann's avatar
      ALSA: aoa: avoid false-positive format truncation warning · 7590ac22
      Arnd Bergmann authored
      clang warns about what it interprets as a truncated snprintf:
      
      sound/aoa/soundbus/i2sbus/core.c:171:6: error: 'snprintf' will always be truncated; specified size is 6, but format string expands to at least 7 [-Werror,-Wformat-truncation-non-kprintf]
      
      The actual problem here is that it does not understand the special
      %pOFn format string and assumes that it is a pointer followed by
      the string "OFn", which would indeed not fit.
      
      Slightly increasing the size of the buffer to its natural alignment
      avoids the warning, as it is now long enough for the correct and
      the incorrect interprations.
      
      Fixes: b917d58d ("ALSA: aoa: Convert to using %pOFn instead of device_node.name")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Message-ID: <20240326223825.4084412-9-arnd@kernel.org>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      7590ac22
  7. 26 Mar, 2024 1 commit
    • Duoming Zhou's avatar
      ALSA: sh: aica: reorder cleanup operations to avoid UAF bugs · 051e0840
      Duoming Zhou authored
      The dreamcastcard->timer could schedule the spu_dma_work and the
      spu_dma_work could also arm the dreamcastcard->timer.
      
      When the snd_pcm_substream is closing, the aica_channel will be
      deallocated. But it could still be dereferenced in the worker
      thread. The reason is that del_timer() will return directly
      regardless of whether the timer handler is running or not and
      the worker could be rescheduled in the timer handler. As a result,
      the UAF bug will happen. The racy situation is shown below:
      
            (Thread 1)                 |      (Thread 2)
      snd_aicapcm_pcm_close()          |
       ...                             |  run_spu_dma() //worker
                                       |    mod_timer()
        flush_work()                   |
        del_timer()                    |  aica_period_elapsed() //timer
        kfree(dreamcastcard->channel)  |    schedule_work()
                                       |  run_spu_dma() //worker
        ...                            |    dreamcastcard->channel-> //USE
      
      In order to mitigate this bug and other possible corner cases,
      call mod_timer() conditionally in run_spu_dma(), then implement
      PCM sync_stop op to cancel both the timer and worker. The sync_stop
      op will be called from PCM core appropriately when needed.
      
      Fixes: 198de43d ("[ALSA] Add ALSA support for the SEGA Dreamcast PCM device")
      Suggested-by: default avatarTakashi Iwai <tiwai@suse.de>
      Signed-off-by: default avatarDuoming Zhou <duoming@zju.edu.cn>
      Message-ID: <20240326094238.95442-1-duoming@zju.edu.cn>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      051e0840
  8. 25 Mar, 2024 2 commits
  9. 22 Mar, 2024 2 commits
  10. 21 Mar, 2024 1 commit
  11. 20 Mar, 2024 2 commits
  12. 19 Mar, 2024 1 commit
  13. 18 Mar, 2024 2 commits
  14. 17 Mar, 2024 3 commits
    • Takashi Sakamoto's avatar
      ALSA: core: add kunitconfig · 585f5bf9
      Takashi Sakamoto authored
      It is helpful to add .kunitconfig if we work with the tools provided by
      KUnit project. The file describes the series of kernel configurations to
      satisfy the dependency to build the target test.
      
      For example:
      
      $ ./tools/testing/kunit/kunit.py run --arch=arm64 --cross_compile=aarch64-linux-gnu- --kunitconfig=sound/core/
      [11:35:13] Configuring KUnit Kernel ...
      Regenerating .config ...
      Populating config with:
      $ make ARCH=arm64 O=.kunit olddefconfig CROSS_COMPILE=aarch64-linux-gnu-
      [11:35:19] Building KUnit Kernel ...
      Populating config with:
      $ make ARCH=arm64 O=.kunit olddefconfig CROSS_COMPILE=aarch64-linux-gnu-
      Building with:
      $ make ARCH=arm64 O=.kunit --jobs=8 CROSS_COMPILE=aarch64-linux-gnu-
      [11:37:35] Starting KUnit Kernel (1/1)...
      [11:37:35] ============================================================
      Running tests with:
      $ qemu-system-aarch64 -nodefaults -m 1024 -kernel .kunit/arch/arm64/boot/Image.gz -append 'kunit.enable=1 console=ttyAMA0 kunit_shutdown=reboot' -no-reboot -nographic -serial stdio -machine virt -cpu max,pauth-impdef=on
      [11:37:35] ============== sound-core-test (10 subtests) ===============
      [11:37:35] [PASSED] test_phys_format_size
      [11:37:35] [PASSED] test_format_width
      [11:37:35] [PASSED] test_format_endianness
      [11:37:35] [PASSED] test_format_signed
      [11:37:35] [PASSED] test_format_fill_silence
      [11:37:35] [PASSED] test_playback_avail
      [11:37:35] [PASSED] test_capture_avail
      [11:37:35] [PASSED] test_card_set_id
      [11:37:35] [PASSED] test_pcm_format_name
      [11:37:35] [PASSED] test_card_add_component
      [11:37:35] ================= [PASSED] sound-core-test =================
      [11:37:35] ============================================================
      [11:37:35] Testing complete. Ran 10 tests: passed: 10
      [11:37:35] Elapsed time: 142.333s total, 5.617s configuring, 136.047s building, 0.630s running
      Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
      Message-ID: <20240317024050.588370-1-o-takashi@sakamocchi.jp>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      585f5bf9
    • Ian Murphy's avatar
      ALSA: hda/realtek: add in quirk for Acer Swift Go 16 - SFG16-71 · bd2d8305
      Ian Murphy authored
      Keyboard has an LED that is ON/OFF when mic is muted/active
       - LED is controlled by GPIO pin
       - Patch enables led to appear in /sys/class/leds/ as hda::micmute
       - Enables LED when mic is MUTED
       - Disables LED when mic is active
      
      [ fixed white spaces by tiwai ]
      Signed-off-by: default avatarIan Murphy <iano200@gmail.com>
      Message-ID: <20240316094157.13890-1-iano200@gmail.com>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      bd2d8305
    • Takashi Iwai's avatar
      Revert "ALSA: usb-audio: Name feature ctl using output if input is PCM" · c53898eb
      Takashi Iwai authored
      This reverts commit 1601cd53.
      
      This fix is applied globally to all devices, and it may change the
      existing control names.  When the devices are managed with the fixed
      configuration like UCM, such control name mismatch may lead to
      significant regressions.
      
      For avoiding that kind of regression, we would need to apply such
      changes conditionally, but it'd take time to settle down.
      While the original fix is a good thing in general, in order to address
      the regression, let's revert the change for now.
      
      Link: https://bugzilla.kernel.org/show_bug.cgi?id=218605Reported-and-tested-by: default avatarNiklāvs Koļesņikovs <pinkflames.linux@gmail.com>
      Message-ID: <20240316083744.28126-1-tiwai@suse.de>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      c53898eb
  15. 15 Mar, 2024 5 commits
    • Mark Brown's avatar
      ASoC: SOF: amd: Skip IRAM/DRAM size modification · f107ffca
      Mark Brown authored
      Merge series from Cristian Ciocaltea <cristian.ciocaltea@collabora.com>:
      
      This patch series restores audio support on Valve's Steam Deck OLED model, which
      broke after the recent introduction of ACP/PSP communication for IRAM/DRAM fence
      register programming.
      f107ffca
    • Cristian Ciocaltea's avatar
      ASoC: SOF: amd: Skip IRAM/DRAM size modification for Steam Deck OLED · 094d1176
      Cristian Ciocaltea authored
      The recent introduction of the ACP/PSP communication for IRAM/DRAM fence
      register modification breaks the audio support on Valve's Steam Deck
      OLED device.
      
      It causes IPC timeout errors when trying to load DSP topology during
      probing:
      
      1707255557.688176 kernel: snd_sof_amd_vangogh 0000:04:00.5: ipc tx timed out for 0x30100000 (msg/reply size: 48/0)
      1707255557.689035 kernel: snd_sof_amd_vangogh 0000:04:00.5: ------------[ IPC dump start ]------------
      1707255557.689421 kernel: snd_sof_amd_vangogh 0000:04:00.5: dsp_msg = 0x0 dsp_ack = 0x91d14f6f host_msg = 0x1 host_ack = 0xead0f1a4 irq_stat >
      1707255557.689730 kernel: snd_sof_amd_vangogh 0000:04:00.5: ------------[ IPC dump end ]------------
      1707255557.690074 kernel: snd_sof_amd_vangogh 0000:04:00.5: ------------[ DSP dump start ]------------
      1707255557.690376 kernel: snd_sof_amd_vangogh 0000:04:00.5: IPC timeout
      1707255557.690744 kernel: snd_sof_amd_vangogh 0000:04:00.5: fw_state: SOF_FW_BOOT_COMPLETE (7)
      1707255557.691037 kernel: snd_sof_amd_vangogh 0000:04:00.5: invalid header size 0xdb43fe7. FW oops is bogus
      1707255557.694824 kernel: snd_sof_amd_vangogh 0000:04:00.5: unexpected fault 0x6942d3b3 trace 0x6942d3b3
      1707255557.695392 kernel: snd_sof_amd_vangogh 0000:04:00.5: ------------[ DSP dump end ]------------
      1707255557.695755 kernel: snd_sof_amd_vangogh 0000:04:00.5: Failed to setup widget PIPELINE.6.ACPHS1.IN
      1707255557.696069 kernel: snd_sof_amd_vangogh 0000:04:00.5: error: tplg component load failed -110
      1707255557.696374 kernel: snd_sof_amd_vangogh 0000:04:00.5: error: failed to load DSP topology -22
      1707255557.697904 kernel: snd_sof_amd_vangogh 0000:04:00.5: ASoC: error at snd_soc_component_probe on 0000:04:00.5: -22
      1707255557.698405 kernel: sof_mach nau8821-max: ASoC: failed to instantiate card -22
      1707255557.701061 kernel: sof_mach nau8821-max: error -EINVAL: Failed to register card(sof-nau8821-max)
      1707255557.701624 kernel: sof_mach: probe of nau8821-max failed with error -22
      
      Introduce a new member skip_iram_dram_size_mod to struct acp_quirk_entry and
      use it to skip IRAM/DRAM size modification for Vangogh Galileo device.
      
      Fixes: 55d7bbe4 ("ASoC: SOF: amd: Add acp-psp mailbox interface for iram-dram fence register modification")
      Signed-off-by: default avatarCristian Ciocaltea <cristian.ciocaltea@collabora.com>
      Link: https://msgid.link/r/20240220201623.438944-3-cristian.ciocaltea@collabora.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      094d1176
    • Cristian Ciocaltea's avatar
      ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry · 33c3d813
      Cristian Ciocaltea authored
      The signed_fw_image member of struct sof_amd_acp_desc is used to enable
      signed firmware support in the driver via the acp_sof_quirk_table.
      
      In preparation to support additional use cases of the quirk table (i.e.
      adding new flags), move signed_fw_image to a new struct acp_quirk_entry
      and update all references to it accordingly.
      
      No functional changes intended.
      Signed-off-by: default avatarCristian Ciocaltea <cristian.ciocaltea@collabora.com>
      Link: https://msgid.link/r/20240220201623.438944-2-cristian.ciocaltea@collabora.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      33c3d813
    • Takashi Iwai's avatar
      ALSA: timer: Fix missing irq-disable at closing · 587d67fd
      Takashi Iwai authored
      The conversion to guard macro dropped the irq-disablement at closing
      mistakenly, which may lead to a race.  Fix it.
      
      Fixes: beb45974 ("ALSA: timer: Use guard() for locking")
      Reported-by: syzbot+28c1a5a5b041a754b947@syzkaller.appspotmail.com
      Closes: http://lore.kernel.org/r/0000000000000b9a510613b0145f@google.com
      Message-ID: <20240315101447.18395-1-tiwai@suse.de>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      587d67fd
    • Jichi Zhang's avatar
      ALSA: hda/realtek: Add quirk for Lenovo Yoga 9 14IMH9 · 9b714a59
      Jichi Zhang authored
      The speakers on the Lenovo Yoga 9 14IMH9 are similar to previous generations
      such as the 14IAP7, and the bass speakers can be fixed using similar methods
      with one caveat: 14IMH9 uses CS35L41 amplifiers which need to be activated
      separately.
      Signed-off-by: default avatarJichi Zhang <i@jichi.ca>
      Message-ID: <20240315081954.45470-3-i@jichi.ca>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      9b714a59
  16. 14 Mar, 2024 2 commits
  17. 13 Mar, 2024 5 commits
    • Mark Brown's avatar
      Add support for the internal RK3308 audio codec · c7c12024
      Mark Brown authored
      Merge series from Luca Ceresoli <luca.ceresoli@bootlin.com>:
      
      This series adds a driver for the internal audio codec of the Rockchip
      RK3308 SoC, along with some related patches. This codec is internally
      connected to the I2S peripherals on the same chip, and it has some
      peculiarities arising from that interconnection.
      
      For proper bidirectional operation with the internal codec at any possible
      combination of sampling rates, the I2S peripheral needs two clock sources
      (tx and rx), while connection with an external codec commonly needs only
      one.
      
      Since v5.16 there is a driver for the I2S in
      sound/soc/rockchip/rockchip_i2s_tdm.c, but in some cases it does not
      configure correctly the clocks, resulting in an unnecessarily inaccurate
      rate. Patch 1 fixes this.
      
      Patches 2-4 add the codec driver along with the bindings and a new helper
      macro.
      
      Patches 5-7 add to the SoC DT file two I2S controllers (those which are
      internally connected to the internal codec) and the codec itself and enable
      the driver in the ARM64 defconfig.
      
      Luca
      Signed-off-by: default avatarLuca Ceresoli <luca.ceresoli@bootlin.com>
      ---
      Changes in v4:
      - several cleanups in the codec probe function
      - Link to v3: https://lore.kernel.org/r/20240221-rk3308-audio-codec-v3-0-dfa34abfcef6@bootlin.com
      
      Changes in v3:
      - Add the I2S clock fix patch and remove a previous fix which is now superseded
      - Codec driver: fix silent playback until a given amplitude of sigital
        value, seen at >= 96 kHz rate
      - various other changes, listed per-patch
      - Link to v2: https://lore.kernel.org/r/20231219-rk3308-audio-codec-v2-0-c70d06021946@bootlin.com
      
      Changes in v2:
      - largely rewrote the codec driver to use DAPM and lots of improvements
        and cleanups
      - removed the RK3308 audio card and related patches
      - various other changes, listed per-patch
      - Link to v1: https://lore.kernel.org/all/20220907142124.2532620-1-luca.ceresoli@bootlin.com/
      
      ---
      Luca Ceresoli (7):
            ASoC: rockchip: i2s-tdm: Fix inaccurate sampling rates
            ASoC: dt-bindings: Add Rockchip RK3308 internal audio codec
            ASoC: core: add SOC_DOUBLE_RANGE_TLV() helper macro
            ASoC: codecs: Add RK3308 internal audio codec driver
            arm64: defconfig: enable Rockchip RK3308 internal audio codec driver
            arm64: dts: rockchip: add i2s_8ch_2 and i2s_8ch_3
            arm64: dts: rockchip: add the internal audio codec
      
       .../bindings/sound/rockchip,rk3308-codec.yaml      |  98 +++
       MAINTAINERS                                        |   7 +
       arch/arm64/boot/dts/rockchip/rk3308.dtsi           |  56 ++
       arch/arm64/configs/defconfig                       |   1 +
       include/sound/soc.h                                |  12 +
       sound/soc/codecs/Kconfig                           |  11 +
       sound/soc/codecs/Makefile                          |   2 +
       sound/soc/codecs/rk3308_codec.c                    | 974 +++++++++++++++++++++
       sound/soc/codecs/rk3308_codec.h                    | 579 ++++++++++++
       sound/soc/rockchip/rockchip_i2s_tdm.c              | 352 +-------
       10 files changed, 1746 insertions(+), 346 deletions(-)
      ---
      base-commit: dfda120c512b3edca1436f770924e91b14f93a98
      change-id: 20231219-rk3308-audio-codec-a5558ba8949d
      
      Best regards,
      --
      Luca Ceresoli <luca.ceresoli@bootlin.com>
      c7c12024
    • Mark Brown's avatar
      ASoC: Merge up release · e25293d9
      Mark Brown authored
      In order to apply additional fixes that depend on the fixes merged for
      v6.8 merge up the final release.
      e25293d9
    • Johan Carlsson's avatar
      ALSA: usb-audio: Stop parsing channels bits when all channels are found. · a39d51ff
      Johan Carlsson authored
      If a usb audio device sets more bits than the amount of channels
      it could write outside of the map array.
      Signed-off-by: default avatarJohan Carlsson <johan.carlsson@teenage.engineering>
      Fixes: 04324ccc ("ALSA: usb-audio: add channel map support")
      Message-ID: <20240313081509.9801-1-johan.carlsson@teenage.engineering>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      a39d51ff
    • Pierre-Louis Bossart's avatar
      ALSA: hda/tas2781: remove unnecessary runtime_pm calls · 526d0283
      Pierre-Louis Bossart authored
      The runtime_pm handling seems to have been loosely inspired by the
      cs32l41 driver, but in this case the get_noresume/put sequence is not
      required.
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Message-ID: <20240312161217.79510-1-pierre-louis.bossart@linux.intel.com>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      526d0283
    • Valentine Altair's avatar
      ALSA: hda/realtek - ALC236 fix volume mute & mic mute LED on some HP models · 300ab0df
      Valentine Altair authored
      Some HP laptops have received revisions that altered their board IDs
      and therefore the current patches/quirks do not apply to them.
      Specifically, for my Probook 440 G8, I have a board ID of 8a74.
      It is necessary to add a line for that specific model.
      Signed-off-by: default avatarValentine Altair <faetalize@proton.me>
      Cc: <stable@vger.kernel.org>
      Message-ID: <kOqXRBcxkKt6m5kciSDCkGqMORZi_HB3ZVPTX5sD3W1pKxt83Pf-WiQ1V1pgKKI8pYr4oGvsujt3vk2zsCE-DDtnUADFG6NGBlS5N3U4xgA=@proton.me>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      300ab0df