1. 14 May, 2010 1 commit
  2. 13 May, 2010 5 commits
  3. 12 May, 2010 5 commits
  4. 07 May, 2010 1 commit
  5. 04 May, 2010 2 commits
  6. 03 May, 2010 3 commits
    • J. Bruce Fields's avatar
      nfsd: further comment typos · fb4b698f
      J. Bruce Fields authored
      Whoops, missed some more.
      
      "Reviewed-by, I guess": Chuck Lever <chuck.lever@oracle.com>
      Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      fb4b698f
    • Neil Brown's avatar
      sunrpc: centralise most calls to svc_xprt_received · b48fa6b9
      Neil Brown authored
      svc_xprt_received must be called when ->xpo_recvfrom has finished
      receiving a message, so that the XPT_BUSY flag will be cleared and
      if necessary, requeued for further work.
      
      This call is currently made in each ->xpo_recvfrom function, often
      from multiple different points.  In each case it is the earliest point
      on a particular path where it is known that the protection provided by
      XPT_BUSY is no longer needed.
      
      However there are (still) some error paths which do not call
      svc_xprt_received, and requiring each ->xpo_recvfrom to make the call
      does not encourage robustness.
      
      So: move the svc_xprt_received call to be made just after the
      call to ->xpo_recvfrom(), and move it of the various ->xpo_recvfrom
      methods.
      
      This means that it may not be called at the earliest possible instant,
      but this is unlikely to be a measurable performance issue.
      
      Note that there are still other calls to svc_xprt_received as it is
      also needed when an xprt is newly created.
      Signed-off-by: default avatarNeilBrown <neilb@suse.de>
      Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      b48fa6b9
    • J. Bruce Fields's avatar
      nfsd4: fix unlikely race in session replay case · 26c0c75e
      J. Bruce Fields authored
      In the replay case, the
      
      	renew_client(session->se_client);
      
      happens after we've droppped the sessionid_lock, and without holding a
      reference on the session; so there's nothing preventing the session
      being freed before we get here.
      
      Thanks to Benny Halevy for catching a bug in an earlier version of this
      patch.
      Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      Acked-by: default avatarBenny Halevy <bhalevy@panasas.com>
      26c0c75e
  7. 30 Apr, 2010 7 commits
  8. 29 Apr, 2010 10 commits
  9. 28 Apr, 2010 6 commits