Side effect: allow toggling of TX offloads.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

Remove be_set_flags() as it's already covered by hw_features.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Acked-by: Ajit Khaparde ajit.khaparde@emulex.com
Signed-off-by: David S. Miller <davem@davemloft.net>

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

Side effect: don't reenable RXCSUM on every ifdown/ifup.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

As a side effect, make TX offloads changeable.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

This removes some of the remnants of LRO -> GRO conversion.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

Not much of a conversion anyway - macvlan has no way to change the offload
settings independently to its base device.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

The variables 'tx_min' and 'tx_max' are set but not used in
be_set_coalesce().

Similarly for 'region' in be_do_flash().

Just kill them off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'fcr' is set but not used in isdn_tty_change_speed().

Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'flowlabel' is set but unused in ip6t_mangle_out().

The intention here was to compare this key to the header value after
mangling, and trigger a route lookup on mismatch.

Make it so.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'target' is set but unused in compat_copy_entry_from_user().

Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'ret' is set but unused in ct_seq_show().

This was obviously meant to be used to propagate error codes
to the caller, so make it so.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'tmp_uint' is set but unused in __build_packet_message().

Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'type_str' is set but unused in netlbl_cipsov4_add().

Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'ret' is set but unused in l2tp_nl_register_ops().

This was obviously meant to maintain error codes which are
returned to the caller, make it so.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'd' is set but unused in irda_proc_register().

Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'ret' is set but unused in irlap_state_sclose().

Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'caifdef' is set but unused in modemcmd().

Similarly for 'net' in receive(), and 'res' in
caif_device_notify() and caif_exit_net().

Just kill them off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'rc' is set but unused in bnx2x_timer().

Similarly for 'hc_index_p' in bnx2x_init_sb(), and 'port' in
bnx2x_get_hwinfo().

Just kill them off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'pgoff' is set but unused in bfa_nw_ioc_fwver_get()
and bfa_ioc_download_fw().

Similarly for 'cmd_h' in bna_mbox_flush_q and the entirety of
bna_rit_mod_uninit() is unused since variables are purely set but no
action is made using them.

Same for 'bna' in bna_rit_create() and 'ret' in bna_rx_create().

Just kill them off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'len' is set but unused in data_sock_getsockopt().

The code should use 'len' to validate that the user's socket option is
indeed the right size.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'unused' is set but unused in
isdn_net_ciscohdlck_slarp_in().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'ch' is set but unused in isdn_capi_rec_hl_msg().  Just
kill it off.

Similarly for 'chidx' in isdn_ioctl() and 'di' in
isdn_capi_rec_hl_msg().
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'dev' is set but unused in teles_cs_config().  Just
kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'cause' is set but unused in ni1up().  Just
kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'cause' is set but unused in dss1up().  Just
kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'i' is set but unused in JadeVersion().  Just
kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'cda2_cr' is set but unused in ctrl_complete().  Just
kill it off.

Keep the cs->readisac() call just in case the register read has side
effects.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'buf' is set but unused in
ctrl_complete().  Just kill it off.

Similarly for 'err' in hfc_usb_init().
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'bits' is set but unused in
change_speed().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'dev' is set but unused in
elsa_cs_config().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'val' is set but unused in
send_arcofi().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'buf' is set but unused in
ctrl_complete().  Just kill it off.

Similarly for the variable 'err' in setup_hfcsusb().
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'total' is set but unused in
hfcpci_empty_bfifo().  Just kill it off.

Similarly for the variable 'val' in ph_state_nt().
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'best_id' is set but unused in
diva_mnt_add_xdi_adapter().  Just kill it off.

Similarly for the variable 'CIP' in connect_req(), 'Number' in
sig_ind(), 'Info' in dtmf_confirmation() mixer_command()
fax_connect_ack_command() fax_edata_ack_command()
rtp_connect_b3_res_command() and rtp_connect_b3_res_command(), and 'a'
in mixer_indication_coefs_set(),
Signed-off-by: David S. Miller <davem@davemloft.net>

The variable 'offset' is set but unused in
write_iso_tasklet().  Just kill it off.
Signed-off-by: David S. Miller <davem@davemloft.net>

Like other virtual interfaces, e.g. br0, we don't need a transmit
queue. Packets should only be queued on real interfaces which are
underneath. In practice this patch makes little difference since the
virtual interfaces can accept packets as fast as they come, but the
patch will avoid bufferbloat questions to the mailling lists in the
future.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Sven Eckelmann <sven@narfation.org>

Add get/set wrapper functions for softif_neigh and
use rcu functions to manipulate the pointers.
Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Sven Eckelmann <sven@narfation.org>