- 08 May, 2015 1 commit
-
-
Julia Lawall authored
Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree. A simplified version of the semantic patch that makes these changes is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression ptr,size; @@ - OBD_ALLOC(ptr,size) + ptr = kzalloc(size, GFP_NOFS) @@ expression ptr, size; @@ - OBD_FREE(ptr, size); + kfree(ptr); // </smpl> Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 30 Apr, 2015 39 commits
-
-
kbuild test robot authored
drivers/staging/lustre/lustre/llite/dir.c:1440:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
Fengguang Wu <fengguang.wu@intel.com> Signed-off-by:
-
kbuild test robot authored
drivers/staging/lustre/lustre/llite/llite_lib.c:989:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. drivers/staging/lustre/lustre/llite/llite_lib.c:991:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
kbuild test robot authored
drivers/staging/lustre/lustre/lov/lov_request.c:74:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
kbuild test robot authored
drivers/staging/lustre/lustre/lov/lov_obd.c:574:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
Gbenga Adalumo authored
This is a patch to daqboard2000.c file that fixes code indent errors found by the checkpatch.pl tool Signed-off-by:
Gbenga Adalumo <gbengadev@gmail.com> Signed-off-by:
-
Gujulan Elango, Hari Prasath (H.) authored
This patch removes a few lines of code & retains the same functionality Signed-off-by:
Hari Prasath Gujulan Elango <hgujulan@visteon.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Ian Abbott authored
The `COMEDI_SRF_...` macros define flag combinations in the `runflags` member of `struct comedi_subdevice`. They are only used directly in "comedi_fops.c", so move them to there. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by:
-
Ian Abbott authored
The `COMEDI_SRF_FREE_SPRIV` flag in the `runflags` member of `struct comedi_subdevice` indicates that the memory pointed to by the `private` member can be automatically freed by the comedi core on subdevice clean-up (when the low-level comedi device is being "detached"). the flag doesn't really belong in `runflags`, but it was somewhere convenient to keep it without having to add a new member to the structure. Rather than access the `COMEDI_SRF_FREE_SPRIV` flag directly, use some new wrapper functions: * comedi_can_auto_free_spriv(s) - checks whether the subdevice's `s->private` points to memory that can be freed automatically. * comedi_set_spriv_auto_free(s) - marks the subdevice as having a `s->private` that points to memory that can be freed automatically. Export `comedi_set_spriv_auto_free()` for use by the low-level comedi driver modules, in particular the "amplc_dio200_common" module. Signed-off-by:
-
H Hartley Sweeten authored
serial2002_setup_subdevices() initializes each subdevice based on the config read from the attached serial device. Part of this initialization is to setup the subdevice range_table_list for the non digital subdevices. The range_table_list is allocated only when a 'range' is passed to the functions. Each channel of the subdevice then has it's 'range' initialized and that range is added to the range_table_list. The logic of this function works but causes Coverity complain about an Explicit null dereference of the allocated 'range_table_list'. Add a check for the 'range_table_list' to quiet the Coverity issue. Reported-by: coverity (CID 1011632) Signed-off-by:
-
H Hartley Sweeten authored
ni_write_caldac() checks the boardinfo 'caldac' array to determine what caldac is used for a given 'addr'. It then calculates the 'bitstring' and number of 'bits' used to write a value to that caldac address. After checking the caldac array, if the number of bits is 0 there is no caldac associated with the address. If this happens we shouldn't try writing to the non-existing caldac. Reported-by: coverity (CID 1192116) Signed-off-by:
-
H Hartley Sweeten authored
'b_chans' may be a valud up to 32. 'b_mask' is an unsigned int and a left shift of more than 31 bits has undefined behavior. Fix the calc so it works correctly with a 'b_chans' of 32.. Reported-by: coverity (CID 1192244) Signed-off-by:
-
Andrei Maresu authored
Fixed a coding style issue. Signed-off-by:
Andrei Maresu <andreimaresu@gmail.com> Signed-off-by:
-
Sudip Mukherjee authored
both the misc_deregister(), parport_release() and parport_unregister_device() is there in the module_exit function also. detach is called from parport_unregister_driver() and by the time detach executes misc_deregister(), parport_release() and parport_unregister_device() has already executed marking keypad_initialized and lcd.initialized as false. so this part of the code will never execute. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Aaro Koskinen authored
Update boilerplate comments to be more terse by removing redundant information. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
-
Aaro Koskinen authored
This driver has drifted away from out-of-tree versions years ago and the version string does not provide any useful information. Instead provide the kernel version string to ethtool, so that we get useful version information e.g. for bug reports. Signed-off-by:
-
Aaro Koskinen authored
This feature is not used so eliminate it. Signed-off-by:
-
Aaro Koskinen authored
We have RED always enabled, so eliminate the #define. Signed-off-by:
-
Aaro Koskinen authored
We always try to use skbuffs for packet buffers, so eliminate a redundant define. Signed-off-by:
-
Aaro Koskinen authored
HW checksum is always enabled, so delete a redundant define. Signed-off-by:
-
Aaro Koskinen authored
We have the workaround always enabled, so eliminate a redundant #define. Signed-off-by:
-
Aaro Koskinen authored
Delete references to CONFIG_CAVIUM_RESERVE32. Kernel does not have such option and the driver does not use it for anything. Signed-off-by:
-
Aaro Koskinen authored
Code for spx1 and spx0 block are identical, move it into a function. Signed-off-by:
-
Aaro Koskinen authored
Move interrupt printouts into a common function to avoid copy paste. Signed-off-by:
-
Aaro Koskinen authored
Move interrupt printouts into a common function to avoid copy paste. Signed-off-by:
-
Aaro Koskinen authored
Use a function to enable/disable HW preamble checking to avoid copy paste. Signed-off-by:
-
Aaro Koskinen authored
Code for gmx0 and gmx1 block is identical, move it into a function. Signed-off-by:
-
Aaro Koskinen authored
Make link poll generic to avoid copy paste. Signed-off-by:
-
Aaro Koskinen authored
Always use cvm_oct_note_carrier() to avoid copy-pasted code. Signed-off-by:
-
Aaro Koskinen authored
Add queue information to carrier note. Signed-off-by:
-
Aaro Koskinen authored
Delete redundant wrappers. Signed-off-by:
-
Aaro Koskinen authored
All init functions call ndo_stop if it's defined, so move it to common function. Signed-off-by:
-
Aaro Koskinen authored
All ndo_stop functions are identical. Get rid of duplicated code. Signed-off-by:
-
Aaro Koskinen authored
ndo_open for rgmii, sgmii and xaui are almost identical. Put the common code in a single function. Signed-off-by:
-
Malcolm Priestley authored
vif should never be or go null while in loop. Fixes race condition where interrupts are late and when interface is not present. Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
-
Alan authored
Shock horror, example template code that has never been used in reality is in fact a hazard. This fixes the obvious bug, probably these kind of "examples" should be deleted so real (working) examples are followed. Signed-off-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
-
Gujulan Elango, Hari Prasath (H.) authored
This patch removes few lines of commented code. Signed-off-by:
-
Gujulan Elango, Hari Prasath (H.) authored
This patch removes a stray semicolon around closing brace of an if code block. Signed-off-by:
-
Julia Lawall authored
Put NULL test on the result of the previous call instead on one of its arguments. A simplified version of the semantic match that finds this problem is as follows (http://coccinelle.lip6.fr/): // <smpl> r@ expression *e1; expression *e2; identifier f; statement S1,S2; @@ e1 = f(...,e2,...); ( if (e1 == NULL || ...) S1 else S2 | *if (e2 == NULL || ...) S1 else S2 ) // </smpl> Signed-off-by:
-
Nicolas Iooss authored
drivers/staging/fbtft/internal.h header guard tests for __LINUX_FBTFT__INTERNAL_H but then defines __LINUX_FBTFT_INTERNAL_H (only 1 underscore) and uses the same name for the #endif comment. Use the same name everywhere. Signed-off-by:
Nicolas Iooss <nicolas.iooss_linux@m4x.org> Signed-off-by:
-
