- 07 Mar, 2014 22 commits
-
-
H Hartley Sweeten authored
If an async command is not running the (*cancel) function doesn't do anything. Exit the function early if this is the case. This allows reducing the indent level in the rest of the function. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
H Hartley Sweeten authored
The DMA, FIFO, and EOC interrupt handlers all have common code that checks for channel dropout when running an async command. Factor this common code into a helper function. Only return the sample if the channel is valid. The EOC handler was previously returning the value then checking for channel dropout. Signed-off-by:
-
H Hartley Sweeten authored
To clarify the code, introduce a helper function to read the analog input data sample from the FIFO and optionally return the channel that the sample was for. The channel is used to check for dropped samples. Signed-off-by:
-
H Hartley Sweeten authored
The A/D FIFO uses two registers to get each analog data sample. PCL818_FI_DATALO is the LSB of the data and PCL818_FI_DATAHI is the MSB of the data. The current define for PCL818_FI_DATAHI is incorrect and results in the LSB getting read twice. Signed-off-by:
-
H Hartley Sweeten authored
The DMA, FIFO, and EOC interrupt handlers all have common code that bumps the counters in the private data that keep track of what channel is being sampled next and when all the data has been sampled. Factor this common code into a helper function. Make sure the COMEDI_CB_BLOCK event is set when advancing to the next channel so that when the comedi_event() is finally called the core will wake the async_queue to return the analog input data. Also, make sure the COMEDI_CB_EOS event is set at the completion of each scan. Signed-off-by:
-
H Hartley Sweeten authored
Factor out the code that bumps the counters in the private data that keep track of what channel is being samples next and when all the data has been sampled. Don't clear the events in the driver. The comedi core will clear the events at the end of the comedi_event(). Make sure the COMEDI_CB_BLOCK event is set when advancing to the next channel so that when the comedi_event() is finally called the core will wake the async_queue to return the analog input data. Also, make sure the COMEDI_CB_EOS event is set at the completion of each scan. Signed-off-by:
-
H Hartley Sweeten authored
The DMA and EOC interrupt handlers all have common code that bumps the counters in the private data that keep track of what channel is being sampled next and when all the data has been sampled. Factor this common code into a helper function. Don't clear the events in the driver. The comedi core will clear the events at the end of the comedi_event(). Make sure the COMEDI_CB_BLOCK event is set when advancing to the next channel so that when the comedi_event() is finally called the core will wake the async_queue to return the analog input data. Also, make sure the COMEDI_CB_EOS event is set at the completion of each scan. Signed-off-by:
-
H Hartley Sweeten authored
This driver only supports async commands if a DMA channel is available. Modify the subdevice init so that the command support only gets hooked up if we can do DMA. Signed-off-by:
-
H Hartley Sweeten authored
According to the users manual, when using interrupt (non-DMA) transfers this hardware generates an interrupt at the start of a conversion. This requires the interrupt routine to busywait until the end-of-conversion. It appears this was unreliable and interrupt only async command support was removed at some time. Async command support is still available when DMA is used. Remove the unreachable interrupt only handler code. Signed-off-by:
-
H Hartley Sweeten authored
The interrupt is only generated by the hardware at the completion of an A/D conversion. Because of this the sanity check to make sure that the A/D conversion is complete and data is available is probably unnecessary but it doesn't hurt anything. The busywait loop is a different issue. Interrupt routines should not busywait. That's just mean... Remove the bustwait and use pcl818_ai_eoc() to check for the end-of- conversion. Signed-off-by:
-
H Hartley Sweeten authored
The interrupt is only generated by the hardware at the completion of an A/D conversion. Because of this the sanity check to make sure that the A/D conversion is complete and data is available is probably unnecessary but it doesn't hurt anything. The busywait loop is a different issue. Interrupt routines should not busywait. That's just mean... Remove the bustwait and use pcl812_ai_eoc() to check for the end-of- conversion. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data is not used. Remove it. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data is only used in the initial dma setup. Refactor that code to not need it and remove the member. Signed-off-by:
-
H Hartley Sweeten authored
To assist in cleaning up the the rest of the driver, factor the initial dma setup and the next dma buffer setup into helper functions. Signed-off-by:
-
H Hartley Sweeten authored
To assist in cleaning up the the rest of the driver, factor the initial dma setup and the next dma buffer setup into helper functions. Signed-off-by:
-
H Hartley Sweeten authored
To assist in cleaning up the the rest of the driver, factor the initial dma setup and the next dma buffer setup into helper functions. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data is not needed. We can check the stop_src to determine this information: neverending_ai -> cmd->stop_src == TRIG_NONE !neverending_ai -> cmd->stop_src == TRIG_COUNT Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data is not needed. We can check the stop_src to determine this information: ai_neverending -> cmd->stop_src == TRIG_NONE !ai_neverending -> cmd->stop_src == TRIG_COUNT Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data is not needed. We can check the stop_src to determine this information: ai_neverending -> cmd->stop_src == TRIG_NONE !ai_neverending -> cmd->stop_src == TRIG_COUNT Signed-off-by:
-
H Hartley Sweeten authored
Some of the PCL-818 compatible boards have a FIFO that can be used when running analog input async commands. This FIFO increased the resource range used by the driver. Request the correct resources used by the board even if the FIFO is not used. This prevents another driver from trying to use the I/O space. Modify the attach so that the 'usefifo' flag is only set if we have and IRQ, the board has a FIFO, and the user wahts to use it. Fix pcl818_reset() so that the FIFO is always flushed and disabled if it exists. Signed-off-by:
-
H Hartley Sweeten authored
This function is a _very_ simplified probe that tried to verify that the driver is being attached to a PCL-818 compatible board. The function simply writes some values to specific registers then reads back the values to see if they are the same. It's possible that the user could try to attach this driver to a non- compatible board but the check would still pass depending on the register map of the board. Just remove the buggy function to simplify the attach a bit. Signed-off-by:
-
H Hartley Sweeten authored
This function is a _very_ simplified probe that tried to verify that the driver is being attached to a PCL-816 compatible board. The function simply writes some values to specific registers then reads back the values to see if they are the same. It's possible that the user could try to attach this driver to a non- compatible board but the check would still pass depending on the register map of the board. Just remove the buggy function to simplify the attach a bit. Signed-off-by:
-
- 06 Mar, 2014 18 commits
-
-
Mark Hounschell authored
This patch simplifies and cleans up the dgap_init_module function. It also fixes a possible double free condition as a result pci_unregister_driver possibly being called twice. Signed-off-by:
Mark Hounschell <markh@compro.net> Signed-off-by:
-
Mark Hounschell authored
This patch removes printks associated with sysfile creation and changes the dgap_create_driver_sysfiles function to return an int so we can check for errors in the sysfile creation process. The printk's were flagged by checkpatch but then driver_create_file was flagged by checkpatch for not checking its return. So we remove the printk's and check the return of driver_create_file. Signed-off-by:
-
Mark Hounschell authored
This patch removes more dead code and code associated with that dead code. The from_user variable in the dgap_tty_write function was never true. The code under its test was never being executed. So variables and functions supporting only that code are also dead. Signed-off-by:
-
Mark Hounschell authored
This patch fixes a few 80+ char lines as reported by checkpatch Signed-off-by:
-
Mark Hounschell authored
This patch fixes a few 80+ char lines as reported by checkpatch Signed-off-by:
-
Mark Hounschell authored
This patch fixes a few 80+ char lines as reported by checkpatch Signed-off-by:
-
Mark Hounschell authored
This patch fixes a few of the many 80+ character lines as reported by checkpatch Signed-off-by:
-
Mark Hounschell authored
This patch fixes a checkpatch warning for suspect code indent for conditional statements Signed-off-by:
-
Mark Hounschell authored
This patch fixes a checkpatch warning for not checking the return value of sscanf. Signed-off-by:
-
Mark Hounschell authored
This patch removes the rawreadok module param and sysfs var previously used to enable flip buffer bypass. Code dealing with that param was removed previously. Signed-off-by:
-
Mark Hounschell authored
dgap_global_lock is no longer required. This patch removes it. Signed-off-by:
-
Mark Hounschell authored
We should not remove a sysfs group we failed to create Signed-off-by:
-
Mark Hounschell authored
This patch fixes some pr_warns that have newline chars in the string because they mess up the output. Signed-off-by:
-
Mark Hounschell authored
Multi-line indent blocks get curly braces for readability. Signed-off-by:
-
Mark Hounschell authored
This patch replaces the DGAP_VERIFY_BOARD macro with the dgap_verify_board function because of checkpatch error. Signed-off-by:
-
Mark Hounschell authored
This patch removes more, if not all, of the debug/tracing code Signed-off-by:
-
Mark Hounschell authored
This patch fixes various small checkpatch errors I missed in patches 01-10. Remove check for kfree of brd->channels as kfree is safe. Also there is no need to set it to NULL after freeing it. Remove a useless cast for a kzalloc return value. Remove double negative test in a white space fix line. Signed-off-by:
-
Mark Hounschell authored
This patch fixes some printk related errors report by checkpatch. Signed-off-by:
-
