- 12 Jan, 2022 40 commits
-
-
Ian Rogers authored
Use perf_cpu_map__for_each_cpu() in setup_nodes. Signed-off-by:
Ian Rogers <irogers@google.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: James Clark <james.clark@arm.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: John Garry <john.garry@huawei.com> Cc: Kajol Jain <kjain@linux.ibm.com> Cc: Kan Liang <kan.liang@linux.intel.com> Cc: Leo Yan <leo.yan@linaro.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Mike Leach <mike.leach@linaro.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Clarke <pc@us.ibm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Riccardo Mancini <rickyman7@gmail.com> Cc: Stephane Eranian <eranian@google.com> Cc: Suzuki Poulouse <suzuki.poulose@arm.com> Cc: Vineet Singh <vineet.singh@intel.com> Cc: coresight@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org Cc: zhengjun.xing@intel.com Link: https://lore.kernel.org/r/20220105061351.120843-46-irogers@google.comSigned-off-by:
Arnaldo Carvalho de Melo <acme@redhat.com>
-
Ian Rogers authored
Synchronize the caller in evsel with the called function. Shorten 3 lines of code in bperf_read by using perf_cpu_map__for_each_cpu(). This code is frequently using variables named cpu as cpu map indices, which doesn't matter as all CPUs are in the CPU map. It is strange in some cases the cpumap is used at all. Committer notes: Found when building with BUILD_BPF_SKEL=1: Remove unused 'num_cpu' variable in bperf__read(). Make 'j' an 'int' as it is used in perf_cpu_map__for_each_cpu() to compare against an 'int' Signed-off-by:
-
Ian Rogers authored
cpu was renamed cpu_map_idx, for clarity. Signed-off-by:
-
Ian Rogers authored
The use of CPU is error prone, switch to cpu_map_idx. Signed-off-by:
-
Ian Rogers authored
Code was incorrectly using the cpu map index as the CPU. Signed-off-by:
-
Ian Rogers authored
Clean up variable naming to make cpu and index clearer. Signed-off-by:
-
Ian Rogers authored
Make naming less error prone. Signed-off-by:
-
Ian Rogers authored
Move to being static. Signed-off-by:
-
Ian Rogers authored
CPU is really a cpu map index, change names to make code more intention revealing. Signed-off-by:
-
Ian Rogers authored
Switch from cpu to cpu_map_idx to reduce confusion. Signed-off-by:
-
Ian Rogers authored
evsel__write_stat_event() was incorrectly passing a cpu map index rather than a CPU to perf_event__synthesize_stat(). Signed-off-by:
-
Ian Rogers authored
Previously evlist__for_each_cpu() needed to iterate over the evlist in an inner loop and call "skip" routines. Refactor this so that the iteratr is smarter and the next function can update both the current CPU and evsel. By using a cpu map index, fix apparent off-by-1 in __run_perf_stat's call to perf_evsel__close_cpu(). Signed-off-by:
-
Ian Rogers authored
Return -1, not found, if NULL is passed. Signed-off-by:
-
Ian Rogers authored
Use perf_cpu_map__for_each_cpu() to help with readability. Signed-off-by:
-
Ian Rogers authored
Correct in print_counter() where an index was being used as a cpu. Signed-off-by:
-
Ian Rogers authored
Trying to make cpu maps less error prone. Signed-off-by:
-
Ian Rogers authored
Try to reduce confusion in particular when the cpu map doesn't contain an entry for every CPU. Signed-off-by:
-
Ian Rogers authored
Fix issue where evsel's CPU map index was being used as the mmap cpu. Signed-off-by:
-
Ian Rogers authored
Modify variable names and adopt perf_cpu_map__for_each_cpu() in perf_evsel__open(). Renaming is done by looking for consistency in API usage. Signed-off-by:
-
Ian Rogers authored
Passing the number of CPUs and threads allows for an evsel's counts to be mismatched to its cpu map. To avoid this always derive the counts size from the cpu map. Change openat-syscall-all-cpus to set the cpus to allow for this to work. Signed-off-by:
-
Ian Rogers authored
Correct use of cpumap index in print_no_aggr_metric(). Signed-off-by:
-
Ian Rogers authored
With no aggregration, such as 'perf stat -A', the aggr_cpu_id lacks a way to describe per CPU aggregation and the core is set to the CPU in places like print_counter_aggrdata in stat-display.c. Setting the core to the CPU is undesirable as the CPU will exceed valid core values and lead to confusion. Add a CPU variable to address this. Signed-off-by:
-
Ian Rogers authored
If the key is already present then free the key used for lookup. Found with: $ perf stat -M IO_Read_BW /bin/true ==1749112==ERROR: LeakSanitizer: detected memory leaks Direct leak of 32 byte(s) in 4 object(s) allocated from: #0 0x7f6f6fa7d7cf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145 #1 0x55acecd9d7a6 in check_per_pkg util/stat.c:343 #2 0x55acecd9d9c5 in process_counter_values util/stat.c:365 #3 0x55acecd9e0ab in process_counter_maps util/stat.c:421 #4 0x55acecd9e292 in perf_stat_process_counter util/stat.c:443 #5 0x55aceca8553e in read_counters ./tools/perf/builtin-stat.c:470 #6 0x55aceca88fe3 in __run_perf_stat ./tools/perf/builtin-stat.c:1023 #7 0x55aceca89146 in run_perf_stat ./tools/perf/builtin-stat.c:1048 #8 0x55aceca90858 in cmd_stat ./tools/perf/builtin-stat.c:2555 #9 0x55acecc05fa5 in run_builtin ./tools/perf/perf.c:313 #10 0x55acecc064fe in handle_internal_command ./tools/perf/perf.c:365 #11 0x55acecc068bb in run_argv ./tools/perf/perf.c:409 #12 0x55acecc070aa in main ./tools/perf/perf.c:539 Reviewed-by:James Clark <james.clark@arm.com> Signed-off-by:
-
Ian Rogers authored
cpu_aggr_map__new() removes duplicates, when this happens shrink the array. Reviewed-by:
-
Ian Rogers authored
Move cpu_aggr_map__empty_new() to be with other cpu_aggr_map function. Reviewed-by:
-
Ian Rogers authored
Make the cpu map argument const for consistency with the rest of the API. Modify cpu_map__idx accordingly. Reviewed-by:
-
Ian Rogers authored
The functions don't use a cpu_map so reduce them to being like constructors of aggr_cpu_id. Reviewed-by:
-
Ian Rogers authored
Turn it into a cpu_aggr_map__new(). Pass helper functions. Refactor builtin-stat calls to manually pass function pointers. Try to reduce some copy-paste code. Reviewed-by:
-
Ian Rogers authored
Switch the remaining few users of cpu_map__cpu() to perf_cpu_map__cpu() and remove the function. Reviewed-by:
-
Ian Rogers authored
Move to the cpu name and document for consistency. Reviewed-by:
-
Ian Rogers authored
cpu_map__get_node_id() isn't used externally and merely delegates to cpu__get_node(). Reviewed-by:
-
Ian Rogers authored
Remove cpu_map from name as a cpu_map isn't used. Pass a const pointer rather than by value to avoid unnecessary copying. Reviewed-by:
-
Ian Rogers authored
Rename cpu_map__compare_aggr_cpu_id() to aggr_cpu_id__equal(), the cpu_map part of the name is misleading. Equal better describes the function than compare. Switch to const pointer rather than value as struct given the number of variables in aggr_cpu_id(). Reviewed-by:
-
Ian Rogers authored
Unused function so remove. Reviewed-by:
-
Ian Rogers authored
This code is already tested in topology.c. Reviewed-by:
-
Ian Rogers authored
Migrate final users to appropriate cpu variant. Reviewed-by:
-
Ian Rogers authored
Migrate final users to appropriate cpu variant. Reviewed-by:
-
Ian Rogers authored
Migrate final users to appropriate cpu variant. Reviewed-by:
-
Ian Rogers authored
Migrate final users to appropriate cpu variant. Reviewed-by:
-
Ian Rogers authored
Avoid error prone cpu_map + idx variant. Remove now unused functions. Committer notes: Remove by now unused perf_env__get_cpu(). Reviewed-by:
-
