1. 23 Mar, 2022 8 commits
  2. 14 Mar, 2022 1 commit
    • Gwendal Grignou's avatar
      HID: intel-ish-hid: Use dma_alloc_coherent for firmware update · f97ec5d7
      Gwendal Grignou authored
      Allocating memory with kmalloc and GPF_DMA32 is not allowed, the
      allocator will ignore the attribute.
      
      Instead, use dma_alloc_coherent() API as we allocate a small amount of
      memory to transfer firmware fragment to the ISH.
      
      On Arcada chromebook, after the patch the warning:
      "Unexpected gfp: 0x4 (GFP_DMA32). Fixing up to gfp: 0xcc0 (GFP_KERNEL).  Fix your code!"
      is gone. The ISH firmware is loaded properly and we can interact with
      the ISH:
      > ectool  --name cros_ish version
      ...
      Build info:    arcada_ish_v2.0.3661+3c1a1c1ae0 2022-02-08 05:37:47 @localhost
      Tool version:  v2.0.12300-900b03ec7f 2022-02-08 10:01:48 @localhost
      
      Fixes: commit 91b22810 ("HID: intel-ish-hid: ISH firmware loader client driver")
      Signed-off-by: default avatarGwendal Grignou <gwendal@chromium.org>
      Acked-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
      f97ec5d7
  3. 01 Mar, 2022 23 commits
  4. 21 Feb, 2022 1 commit
    • Pavel Skripkin's avatar
      HID: hid-thrustmaster: fix OOB read in thrustmaster_interrupts · fc3ef2e3
      Pavel Skripkin authored
      Syzbot reported an slab-out-of-bounds Read in thrustmaster_probe() bug.
      The root case is in missing validation check of actual number of endpoints.
      
      Code should not blindly access usb_host_interface::endpoint array, since
      it may contain less endpoints than code expects.
      
      Fix it by adding missing validaion check and print an error if
      number of endpoints do not match expected number
      
      Fixes: c49c3363 ("HID: support for initialization of some Thrustmaster wheels")
      Reported-and-tested-by: syzbot+35eebd505e97d315d01c@syzkaller.appspotmail.com
      Signed-off-by: default avatarPavel Skripkin <paskripkin@gmail.com>
      Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
      fc3ef2e3
  5. 17 Feb, 2022 2 commits
  6. 16 Feb, 2022 5 commits