- 06 Aug, 2018 40 commits
-
-
Nikolay Borisov authored
When a new extent buffer is allocated there are a few mandatory fields which need to be set in order for the buffer to be sane: level, generation, bytenr, backref_rev, owner and FSID/UUID. Currently this is open coded in the callers of btrfs_alloc_tree_block, meaning it's fairly high in the abstraction hierarchy of operations. This patch solves this by simply moving this init code in btrfs_init_new_buffer, since this is the function which initializes a newly allocated extent buffer. No functional changes. Signed-off-by:
Nikolay Borisov <nborisov@suse.com> Reviewed-by:
David Sterba <dsterba@suse.com> Signed-off-by:
-
Qu Wenruo authored
Commit f8f84b2d ("btrfs: index check-integrity state hash by a dev_t") changed how btrfsic indexes device state. Now we need to access device->bdev->bd_dev, while for degraded mount it's completely possible to have device->bdev as NULL, thus it will trigger a NULL pointer dereference at mount time. Fix it by checking if the device is degraded before accessing device->bdev->bd_dev. There are a lot of other places accessing device->bdev->bd_dev, however the other call sites have either checked device->bdev, or the device->bdev is passed from btrfsic_map_block(), so it won't cause harm. Fixes: f8f84b2d ("btrfs: index check-integrity state hash by a dev_t") Signed-off-by:
Qu Wenruo <wqu@suse.com> Reviewed-by:
-
Nikolay Borisov authored
It can be referenced from the passed transaction handle. Signed-off-by:
-
Nikolay Borisov authored
It can be referenced from the passed bg cache. Signed-off-by:
-
Nikolay Borisov authored
It can be referenced from trans since the function is always called within a valid transaction. Signed-off-by:
-
Nikolay Borisov authored
It can be referenced directly from the transaction handle since it's always valid. Signed-off-by:
-
Nikolay Borisov authored
It can be referenced from the passed transaction handle, since it's always valid. Signed-off-by:
-
Nikolay Borisov authored
It can be referenced from the passed transaction handle, since it's always valid. Signed-off-by:
-
Nikolay Borisov authored
It can be referenced from the passed block group. Signed-off-by:
-
Nikolay Borisov authored
It can be referenced from the passed block group. Signed-off-by:
-
Nikolay Borisov authored
It can be referenced from trans since the function is always called within a transaction. Signed-off-by:
-
Nikolay Borisov authored
It can be referenced from trans since the function is always called within a transaction. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction handle from where fs_info can be referenced. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
It can always be referneced from the passed transaction handle since it's always valid. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
fs_info can be refenreced from the transaction handle, since it's always valid. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
The argument is no longer used so remove it. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction handle so fs_info can be referenced from there. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction from where fs_info can be referenced. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This function already takes a transaction which holds a reference to the fs_info struct. Use that reference and remove the extra arg. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
fs_info can be referenced from the transaction handle, which is always valid. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction handle so we can reference the fs_info from there. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction handle from where we can reference fs_info. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction handle from where we can reference the fs_info. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction handle from where fs_info can be referenced. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction handle from where fs_info can be referenced. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This argument is unused. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction handle from where fs_info can be referenced. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction handle from where the fs_info can be referenced. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This function always uses the leaf's extent_buffer which already contains a reference to the fs_info. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction handle from where the fs_info can be referenced. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This argument is unused. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction from where the fs_info can be referenced. No functional change. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction handle from where fs_info can be referenced. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction handle from where fs_info can be referenced. So remove the redundant argument. No functional changes. Signed-off-by:
-
Nikolay Borisov authored
This function is always called with a valid transaction so there is no need to duplicate the fs_info, we can reference it directly from the trans handle. No functional changes. Signed-off-by:
-
Bart Van Assche authored
The C programming language does not allow to use preprocessor statements inside macro arguments (pr_info() is defined as a macro). Hence rework the pr_info() statement in btrfs_print_mod_info() such that it becomes compliant. This patch allows tools like sparse to analyze the BTRFS source code. Fixes: 62e85577 ("btrfs: convert printk(KERN_* to use pr_* calls") Signed-off-by:
Bart Van Assche <bart.vanassche@wdc.com> Reviewed-by:
-
Bart Van Assche authored
This patch avoids that the compiler complains that a fall-through annotation is missing when building with W=1. Signed-off-by:
-
Bart Van Assche authored
This patch avoids that building the BTRFS source code with smatch triggers complaints about inconsistent indenting. Signed-off-by:
-
Nikolay Borisov authored
Currently this function takes the root as an argument only to get the log_root from it. Simplify this by directly passing the log root from the caller. Also eliminate the fs_info local variable, since it's used only once, so directly reference it from the transaction handle. Signed-off-by:
-
David Sterba authored
The logic to check if the inode is already in the log can now be simplified since we always wait for the ordered extents to complete before deciding whether the inode needs to be logged. The big comment about it can go away too. CC: Filipe Manana <fdmanana@suse.com> Suggested-by:
Filipe Manana <fdmanana@suse.com> [ code and changelog copied from mail discussion ] Signed-off-by:
-
