- 23 Aug, 2011 40 commits
-
-
Franky Lin authored
One of the steps to remove global variable. gInstance will be replaced by brcmf_sdio_dev in the upcoming patch. Reviewed-by:
Roland Vossen <rvossen@broadcom.com> Signed-off-by:
Arend van Spriel <arend@broadcom.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Roland Vossen authored
Code cleanup. Removed MIPS specific 'sync' instruction since this is not required for the chips that this driver supports. MIPS specific macro's were now the same as non-MIPS register access macro's and thus have been deleted. Also added comment that makes clearer what the benefit of these macro's is. Unified big and little end register access macro's. Reported-by:
Dan Carpenter <error27@gmail.com> Reported-by:
Julian Calaby <julian.calaby@gmail.com> Reviewed-by:
Pieter-Paul Giesberts <pieterpg@broadcom.com> Signed-off-by:
-
Roland Vossen authored
Code cleanup. Replacing void * by other pointer types improves code readability and enforces stronger type checking. Reported-by:
-
Roland Vossen authored
Code cleanup. Since this driver only needs to support 64 bit DMA hardware, an unnecessary layer of abstraction could be removed. Also DMA functions that were not called have been removed. Signed-off-by:
-
Franky Lin authored
The commit "staging: brcm80211: remove code for unsupported chip" unintentionally got rid of initialization of the atomic variable brcmf_mmc_suspend. The patch restore that particular piece of code. Reported-by:
-
Arend van Spriel authored
The function dma_addrwidth() always returns the same value so it is redundant. As such it has been removed. Reviewed-by:
Henry Ptasinski <henryp@broadcom.com> Reviewed-by:
-
Arend van Spriel authored
The function wl_alloc_dma_resources() does not provide any value for the brcmsmac driver as it only returns true. It has been removed from the driver. Reviewed-by:
-
Arend van Spriel authored
Linux coding style strongly suggest to limit length of source lines to 80 characters. This commit correct this for the brcmsmac sources. Reviewed-by:
-
Arend van Spriel authored
The file pub.h contained a number of definitions that are not used in the brcmsmac driver and consequently have been removed. Reviewed-by:
-
Arend van Spriel authored
The macro PCI_DEVICE() fills in the entry in abbreviated manner. Using this removes the "lines over 80 characters" checkpatch warning on these entries. Reviewed-by:
-
Roland Vossen authored
All of them being 'line longer than 80 chars' type of warning. Reviewed-by:
-
Roland Vossen authored
Most of them being 'line longer than 80 chars' type of warning. Reviewed-by:
-
Roland Vossen authored
Most of them being 'line longer than 80 chars' type of warning. Reviewed-by:
-
Arend van Spriel authored
The usage of simple_strtoul is not preferred. Instead kstrtoul should be used. This patch fixes this for the brcmfmac driver. Reported-by:
-
Franky Lin authored
To increase code readability of brcmfmac Reviewed-by:
-
Franky Lin authored
Increase readability of brcmfmac Reviewed-by:
-
Franky Lin authored
Use unified debug macros BRCMF_* in fullmac. Reviewed-by:
-
Franky Lin authored
Use unified debug macros in fullmac Reviewed-by:
-
Franky Lin authored
Most members in sdio_hc are no longer needed anymore. And fullmac is keeping a global pointer of this structure. This patch deletes the structure and places the useful member to a new structure brcmf_sdio_dev. The pointer of brcmf_sdio_dev will be save in the private driver data during sdio_probe. Therefore, we don't need to keep the global pointer. Reviewed-by:
-
Franky Lin authored
Use BRCMF_* instead of sd_* as debug message interface Reviewed-by:
-
Franky Lin authored
Currently fullmac only support bcm4329. Remove dead code for unsupported chip. Reviewed-by:
-
Franky Lin authored
Remove global wait queue head sdioh_spinwait_sleep in fullmac. Reviewed-by:
-
Franky Lin authored
brcmf_mmc_suspend is used for sdio suspend/resume function. Hence it should be placed in sdio interface layer. Reviewed-by:
-
Franky Lin authored
Use kernel timer macros to replace current private timeout functions used in dhd_sdio.c Reviewed-by:
-
Arend van Spriel authored
The usage of simple_strtoul is not preferred. Instead kstrtoul should be used. This patch fixes this for the brcmsmac driver. Reviewed-by:
-
Roland Vossen authored
Code cleanup. bus->card is assigned in brcmf_sdbrcm_probe (before brcmf_sdbrcm_probe_attach()). Since w_sdreg32() and r_sdreg32() are called only after that assignment, they can safely use bus->card. Thus there is no instance left where brcmf_sdcard_reg_read() or brcmf_sdcard_reg_write() is called with a NULL parameter, so the mechanism in bcmsdh.c that deals with a NULL pointer could be deleted. Reviewed-by:
Franky (Zhenhui) Lin <frankyl@broadcom.com> Signed-off-by:
-
Roland Vossen authored
Code cleanup. Macro invocations have been substituted with macro expansion. Reviewed-by:
-
Roland Vossen authored
This instruction was required for the bcm4716/bcm4322, but since the fullmac driver only supports bcm4329, it could be removed. After that, the R_REG macro's were identical and thus were reduced to just 1 R_REG macro. Reviewed-by:
-
Roland Vossen authored
Driver now builds for big endian mips platform, possibly also for other big endian platforms. A change was made to the R_REG and W_REG macro's. These macro's perform an xor (^) operation for endianess swap purposes. Gcc complained because an xor operation is not allowed on a pointer type. Fixed this by casting the pointer to an unsigned long. Reviewed-by:
-
Roland Vossen authored
Code that exceeded the 80 char limit has been placed in separate functions. Checkpatch warnings for the phy dir are now reduced to 1. Reviewed-by:
-
Roland Vossen authored
Refactored code to not exceed the 80 char limit. Reviewed-by:
-
Roland Vossen authored
Most of them being 'line exceeds 80 chars'. Still checkpatch warnings for the phy dir left, these will be resolved in the subsequent commits. Reviewed-by:
-
Arend van Spriel authored
Two members vcons_in and vcons_out were declared using the volatile keyword. However, there is no reason for doing so. The member is used only to calculate the backplane address to access using offsetof. This address is passed to subsequent read function. Use of volatile is not warranted. Signed-off-by:
-
Arend van Spriel authored
The sysioc thread was triggered using a semaphore. Now it waits for a wake_up() on its wait queue and the semaphore has been removed as the semaphore serves another purpose. This removes a checkpatch warning for dhd_linux.c. Signed-off-by:
-
Franky Lin authored
Ioctl response wait is used only by bus layer in fullmac. Move the corresponding code to dhd_sdio.c Signed-off-by:
-
Franky Lin authored
In fullmac some variables are used by sdio layer declared in dhd_linux.c. Move them to dhd_sdio.c for clean up. Signed-off-by:
-
Sukesh Srikakula authored
With this patch, brcmfmac driver will pass roamed channel information to cfg80211 via cfg80211_roamed() API. Signed-off-by:
Sukesh Srikakula <sukeshs@broadcom.com> Reviewed-by:
-
Sukesh Srikakula authored
Disabling the interface doesn't terminate undergoing iscan in FW. When the interface is enabled immediately, first scan request is returning the stale scan results, which are populated during the earlier iscan. These stale scan results are causing random failures with chromium auto test cases. With this patch, iscan will be terminated in FW whenever iscan thread is terminated by the host driver. Signed-off-by:
-
Henry Ptasinski authored
Removed unnecessary braces in single-statement blocks. Used the tools 'uncrustify' and 'coccinelle' to accomplish this. Signed-off-by:
-
Arend van Spriel authored
The function brcmu_ether_atoe() does exactly the same as mac_pton(). The driver now uses the latter and brcmu_ether_atoe() has been removed as it is not used anymore. Signed-off-by:
-
