1. 28 Jan, 2021 31 commits
    • Lee Jones's avatar
      RDMA/hw/hfi1/user_exp_rcv: Demote half-documented and kernel-doc abuses · c6f2b65e
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/user_exp_rcv.c:174: warning: Function parameter or member 'fd' not described in 'unpin_rcv_pages'
       drivers/infiniband/hw/hfi1/user_exp_rcv.c:174: warning: Function parameter or member 'tidbuf' not described in 'unpin_rcv_pages'
       drivers/infiniband/hw/hfi1/user_exp_rcv.c:174: warning: Function parameter or member 'node' not described in 'unpin_rcv_pages'
       drivers/infiniband/hw/hfi1/user_exp_rcv.c:174: warning: Function parameter or member 'idx' not described in 'unpin_rcv_pages'
       drivers/infiniband/hw/hfi1/user_exp_rcv.c:174: warning: Function parameter or member 'npages' not described in 'unpin_rcv_pages'
       drivers/infiniband/hw/hfi1/user_exp_rcv.c:174: warning: Function parameter or member 'mapped' not described in 'unpin_rcv_pages'
       drivers/infiniband/hw/hfi1/user_exp_rcv.c:196: warning: Function parameter or member 'fd' not described in 'pin_rcv_pages'
       drivers/infiniband/hw/hfi1/user_exp_rcv.c:196: warning: Function parameter or member 'tidbuf' not described in 'pin_rcv_pages'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-19-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      c6f2b65e
    • Lee Jones's avatar
      RDMA/hw/hfi1/ud: Fix a little more doc-rot · 16e1b536
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/ud.c:477: warning: Function parameter or member 'ps' not described in 'hfi1_make_ud_req'
       drivers/infiniband/hw/hfi1/ud.c:855: warning: Function parameter or member 'packet' not described in 'hfi1_ud_rcv'
       drivers/infiniband/hw/hfi1/ud.c:855: warning: Excess function parameter 'ibp' description in 'hfi1_ud_rcv'
       drivers/infiniband/hw/hfi1/ud.c:855: warning: Excess function parameter 'hdr' description in 'hfi1_ud_rcv'
       drivers/infiniband/hw/hfi1/ud.c:855: warning: Excess function parameter 'rcv_flags' description in 'hfi1_ud_rcv'
       drivers/infiniband/hw/hfi1/ud.c:855: warning: Excess function parameter 'data' description in 'hfi1_ud_rcv'
       drivers/infiniband/hw/hfi1/ud.c:855: warning: Excess function parameter 'tlen' description in 'hfi1_ud_rcv'
       drivers/infiniband/hw/hfi1/ud.c:855: warning: Excess function parameter 'qp' description in 'hfi1_ud_rcv'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-18-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      16e1b536
    • Lee Jones's avatar
      RDMA/hw/hfi1/uc: Fix a little doc-rot · d6a8bfe0
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/uc.c:64: warning: Function parameter or member 'ps' not described in 'hfi1_make_uc_req'
       drivers/infiniband/hw/hfi1/uc.c:306: warning: Function parameter or member 'packet' not described in 'hfi1_uc_rcv'
       drivers/infiniband/hw/hfi1/uc.c:306: warning: Excess function parameter 'ibp' description in 'hfi1_uc_rcv'
       drivers/infiniband/hw/hfi1/uc.c:306: warning: Excess function parameter 'hdr' description in 'hfi1_uc_rcv'
       drivers/infiniband/hw/hfi1/uc.c:306: warning: Excess function parameter 'rcv_flags' description in 'hfi1_uc_rcv'
       drivers/infiniband/hw/hfi1/uc.c:306: warning: Excess function parameter 'data' description in 'hfi1_uc_rcv'
       drivers/infiniband/hw/hfi1/uc.c:306: warning: Excess function parameter 'tlen' description in 'hfi1_uc_rcv'
       drivers/infiniband/hw/hfi1/uc.c:306: warning: Excess function parameter 'qp' description in 'hfi1_uc_rcv'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-17-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      d6a8bfe0
    • Lee Jones's avatar
      RDMA/hw/hfi1/tid_rdma: Fix a plethora of kernel-doc issues · cd7727fd
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/tid_rdma.c:321: warning: Function parameter or member 'rdi' not described in 'qp_to_rcd'
       drivers/infiniband/hw/hfi1/tid_rdma.c:321: warning: Function parameter or member 'qp' not described in 'qp_to_rcd'
       drivers/infiniband/hw/hfi1/tid_rdma.c:505: warning: Function parameter or member 'queue' not described in 'kernel_tid_waiters'
       drivers/infiniband/hw/hfi1/tid_rdma.c:536: warning: Function parameter or member 'rcd' not described in 'dequeue_tid_waiter'
       drivers/infiniband/hw/hfi1/tid_rdma.c:536: warning: Function parameter or member 'queue' not described in 'dequeue_tid_waiter'
       drivers/infiniband/hw/hfi1/tid_rdma.c:536: warning: Function parameter or member 'qp' not described in 'dequeue_tid_waiter'
       drivers/infiniband/hw/hfi1/tid_rdma.c:562: warning: Function parameter or member 'queue' not described in 'queue_qp_for_tid_wait'
       drivers/infiniband/hw/hfi1/tid_rdma.c:607: warning: Function parameter or member 'qp' not described in 'tid_rdma_schedule_tid_wakeup'
       drivers/infiniband/hw/hfi1/tid_rdma.c:639: warning: Function parameter or member 'work' not described in 'tid_rdma_trigger_resume'
       drivers/infiniband/hw/hfi1/tid_rdma.c:666: warning: Function parameter or member 'qp' not described in '_tid_rdma_flush_wait'
       drivers/infiniband/hw/hfi1/tid_rdma.c:666: warning: Function parameter or member 'queue' not described in '_tid_rdma_flush_wait'
       drivers/infiniband/hw/hfi1/tid_rdma.c:713: warning: Function parameter or member 'rcd' not described in 'kern_reserve_flow'
       drivers/infiniband/hw/hfi1/tid_rdma.c:713: warning: Function parameter or member 'last' not described in 'kern_reserve_flow'
       drivers/infiniband/hw/hfi1/tid_rdma.c:879: warning: Function parameter or member 'flow' not described in 'tid_rdma_find_phys_blocks_4k'
       drivers/infiniband/hw/hfi1/tid_rdma.c:879: warning: Function parameter or member 'pages' not described in 'tid_rdma_find_phys_blocks_4k'
       drivers/infiniband/hw/hfi1/tid_rdma.c:879: warning: Function parameter or member 'npages' not described in 'tid_rdma_find_phys_blocks_4k'
       drivers/infiniband/hw/hfi1/tid_rdma.c:879: warning: Function parameter or member 'list' not described in 'tid_rdma_find_phys_blocks_4k'
       drivers/infiniband/hw/hfi1/tid_rdma.c:972: warning: Function parameter or member 'list' not described in 'tid_flush_pages'
       drivers/infiniband/hw/hfi1/tid_rdma.c:972: warning: Function parameter or member 'idx' not described in 'tid_flush_pages'
       drivers/infiniband/hw/hfi1/tid_rdma.c:972: warning: Function parameter or member 'pages' not described in 'tid_flush_pages'
       drivers/infiniband/hw/hfi1/tid_rdma.c:972: warning: Function parameter or member 'sets' not described in 'tid_flush_pages'
       drivers/infiniband/hw/hfi1/tid_rdma.c:1017: warning: Function parameter or member 'flow' not described in 'tid_rdma_find_phys_blocks_8k'
       drivers/infiniband/hw/hfi1/tid_rdma.c:1017: warning: Function parameter or member 'pages' not described in 'tid_rdma_find_phys_blocks_8k'
       drivers/infiniband/hw/hfi1/tid_rdma.c:1017: warning: Function parameter or member 'npages' not described in 'tid_rdma_find_phys_blocks_8k'
       drivers/infiniband/hw/hfi1/tid_rdma.c:1017: warning: Function parameter or member 'list' not described in 'tid_rdma_find_phys_blocks_8k'
       drivers/infiniband/hw/hfi1/tid_rdma.c:1083: warning: Function parameter or member 'flow' not described in 'kern_find_pages'
       drivers/infiniband/hw/hfi1/tid_rdma.c:1083: warning: Function parameter or member 'pages' not described in 'kern_find_pages'
       drivers/infiniband/hw/hfi1/tid_rdma.c:1083: warning: Function parameter or member 'ss' not described in 'kern_find_pages'
       drivers/infiniband/hw/hfi1/tid_rdma.c:1083: warning: Function parameter or member 'last' not described in 'kern_find_pages'
       drivers/infiniband/hw/hfi1/tid_rdma.c:1604: warning: Function parameter or member 'req' not described in 'hfi1_kern_exp_rcv_free_flows'
       drivers/infiniband/hw/hfi1/tid_rdma.c:3458: warning: Function parameter or member 'qp' not described in 'hfi1_tid_write_alloc_resources'
       drivers/infiniband/hw/hfi1/tid_rdma.c:3458: warning: Function parameter or member 'intr_ctx' not described in 'hfi1_tid_write_alloc_resources'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-16-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      cd7727fd
    • Lee Jones's avatar
      RDMA/hw/hfi1/sdma: Fix misnaming of 'sdma_send_txlist()'s 'count_out' param · d7480310
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/sdma.c:2476: warning: Function parameter or member 'count_out' not described in 'sdma_send_txlist'
       drivers/infiniband/hw/hfi1/sdma.c:2476: warning: Excess function parameter 'count' description in 'sdma_send_txlist'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-15-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      d7480310
    • Lee Jones's avatar
      RDMA/hw/hfi1/ruc: Fix a small formatting and description issues · 0654a746
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/ruc.c:277: warning: Function parameter or member 'bth1' not described in 'hfi1_make_ruc_header_16B'
       drivers/infiniband/hw/hfi1/ruc.c:365: warning: Function parameter or member 'bth1' not described in 'hfi1_make_ruc_header_9B'
       drivers/infiniband/hw/hfi1/ruc.c:472: warning: Function parameter or member 'tid' not described in 'hfi1_schedule_send_yield'
       drivers/infiniband/hw/hfi1/ruc.c:472: warning: Excess function parameter 'timeout' description in 'hfi1_schedule_send_yield'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-14-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      0654a746
    • Lee Jones's avatar
      RDMA/hw/hfi1/qp: Fix some formatting issues and demote kernel-doc abuse · 11edbb19
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/qp.c:195: warning: Function parameter or member 'dev' not described in 'verbs_mtu_enum_to_int'
       drivers/infiniband/hw/hfi1/qp.c:195: warning: Function parameter or member 'mtu' not described in 'verbs_mtu_enum_to_int'
       drivers/infiniband/hw/hfi1/qp.c:306: warning: Function parameter or member 'qp' not described in 'hfi1_setup_wqe'
       drivers/infiniband/hw/hfi1/qp.c:306: warning: Function parameter or member 'wqe' not described in 'hfi1_setup_wqe'
       drivers/infiniband/hw/hfi1/qp.c:306: warning: Function parameter or member 'call_send' not described in 'hfi1_setup_wqe'
       drivers/infiniband/hw/hfi1/qp.c:922: warning: Function parameter or member 'qp' not described in 'hfi1_qp_iter_cb'
       drivers/infiniband/hw/hfi1/qp.c:922: warning: Function parameter or member 'v' not described in 'hfi1_qp_iter_cb'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-13-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      11edbb19
    • Lee Jones's avatar
      RDMA/hw/hfi1/rc: Fix a few function documentation issues · 6993fce4
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/rc.c:430: warning: Function parameter or member 'ps' not described in 'hfi1_make_rc_req'
       drivers/infiniband/hw/hfi1/rc.c:1387: warning: Function parameter or member 'packet' not described in 'hfi1_send_rc_ack'
       drivers/infiniband/hw/hfi1/rc.c:1387: warning: Function parameter or member 'is_fecn' not described in 'hfi1_send_rc_ack'
       drivers/infiniband/hw/hfi1/rc.c:1387: warning: Excess function parameter 'qp' description in 'hfi1_send_rc_ack'
       drivers/infiniband/hw/hfi1/rc.c:2008: warning: Function parameter or member 'aeth' not described in 'do_rc_ack'
       drivers/infiniband/hw/hfi1/rc.c:2008: warning: Function parameter or member 'val' not described in 'do_rc_ack'
       drivers/infiniband/hw/hfi1/rc.c:2008: warning: Function parameter or member 'rcd' not described in 'do_rc_ack'
       drivers/infiniband/hw/hfi1/rc.c:2554: warning: Function parameter or member 'rcd' not described in 'rc_rcv_error'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-12-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      6993fce4
    • Lee Jones's avatar
      RDMA/hw/hfi1/pio_copy: Provide entry for 'pio_copy()'s 'dd' param · f4f86690
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/pio_copy.c:73: warning: Function parameter or member 'dd' not described in 'pio_copy'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-11-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      f4f86690
    • Lee Jones's avatar
      RDMA/hw/hfi1/pcie: Demote kernel-doc abuses · 2a266027
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/pcie.c:343: warning: Function parameter or member 'dd' not described in 'restore_pci_variables'
       drivers/infiniband/hw/hfi1/pcie.c:402: warning: Function parameter or member 'dd' not described in 'save_pci_variables'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-10-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      2a266027
    • Lee Jones's avatar
      RDMA/hw/hfi1/netdev_rx: Fix misdocumentation of the 'start_id' param · 17401db5
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/netdev_rx.c:473: warning: Function parameter or member 'start_id' not described in 'hfi1_netdev_get_first_data'
       drivers/infiniband/hw/hfi1/netdev_rx.c:473: warning: Excess function parameter 'id' description in 'hfi1_netdev_get_first_data'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-9-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      17401db5
    • Lee Jones's avatar
      RDMA/sw/rdmavt/qp: Fix kernel-doc formatting problem · f57cfca8
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/sw/rdmavt/qp.c:1929: warning: Function parameter or member 'post_parms' not described in 'rvt_qp_valid_operation'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-8-lee.jones@linaro.org
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      f57cfca8
    • Lee Jones's avatar
      RDMA/sw/rdmavt/mad: Fix misspelling of 'rvt_process_mad()'s 'in_mad_size' param · c1e73d03
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/sw/rdmavt/mad.c:78: warning: Function parameter or member 'in_mad_size' not described in 'rvt_process_mad'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-7-lee.jones@linaro.org
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      c1e73d03
    • Lee Jones's avatar
      RDMA/hw/hfi1/msix: Add description for 'name' and remove superfluous param 'idx' · e57a8db9
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/msix.c:120: warning: Function parameter or member 'name' not described in 'msix_request_irq'
       drivers/infiniband/hw/hfi1/msix.c:120: warning: Excess function parameter 'idx' description in 'msix_request_irq'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-6-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      e57a8db9
    • Lee Jones's avatar
      RDMA/hw/hfi1/mad: Demote half-completed kernel-doc header fix another · 29f7e5a3
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/mad.c:1354: warning: Function parameter or member 'am' not described in '__subn_set_opa_portinfo'
       drivers/infiniband/hw/hfi1/mad.c:1354: warning: Function parameter or member 'data' not described in '__subn_set_opa_portinfo'
       drivers/infiniband/hw/hfi1/mad.c:1354: warning: Function parameter or member 'resp_len' not described in '__subn_set_opa_portinfo'
       drivers/infiniband/hw/hfi1/mad.c:1354: warning: Function parameter or member 'max_len' not described in '__subn_set_opa_portinfo'
       drivers/infiniband/hw/hfi1/mad.c:1354: warning: Function parameter or member 'local_mad' not described in '__subn_set_opa_portinfo'
       drivers/infiniband/hw/hfi1/mad.c:4919: warning: Function parameter or member 'out_mad_size' not described in 'hfi1_process_mad'
       drivers/infiniband/hw/hfi1/mad.c:4919: warning: Function parameter or member 'out_mad_pkey_index' not described in 'hfi1_process_mad'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-5-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      29f7e5a3
    • Lee Jones's avatar
      RDMA/hw/hfi1/iowait: Demote half-completed kernel-doc and fix formatting issue in another · 36da5370
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/iowait.c:52: warning: Function parameter or member 'tidfunc' not described in 'iowait_init'
       drivers/infiniband/hw/hfi1/iowait.c:52: warning: Function parameter or member 'wakeup' not described in 'iowait_init'
       drivers/infiniband/hw/hfi1/iowait.c:52: warning: Function parameter or member 'sdma_drained' not described in 'iowait_init'
       drivers/infiniband/hw/hfi1/iowait.c:52: warning: Function parameter or member 'init_priority' not described in 'iowait_init'
       drivers/infiniband/hw/hfi1/iowait.c:52: warning: Excess function parameter 'resume' description in 'iowait_init'
       drivers/infiniband/hw/hfi1/iowait.c:94: warning: Function parameter or member 'w' not described in 'iowait_set_work_flag'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-4-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      36da5370
    • Lee Jones's avatar
      RDMA/sw/rdmavt/srq: Fix a couple of kernel-doc issues · ce4cc52f
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/sw/rdmavt/srq.c:78: warning: Function parameter or member 'ibsrq' not described in 'rvt_create_srq'
       drivers/infiniband/sw/rdmavt/srq.c:78: warning: Excess function parameter 'ibpd' description in 'rvt_create_srq'
       drivers/infiniband/sw/rdmavt/srq.c:336: warning: Function parameter or member 'udata' not described in 'rvt_destroy_srq'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-3-lee.jones@linaro.org
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      ce4cc52f
    • Lee Jones's avatar
      RDMA/hw/hfi1/intr: Fix some kernel-doc formatting issues · 510a8949
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/intr.c:99: warning: Function parameter or member 'msg' not described in 'format_hwmsg'
       drivers/infiniband/hw/hfi1/intr.c:99: warning: Function parameter or member 'msgl' not described in 'format_hwmsg'
       drivers/infiniband/hw/hfi1/intr.c:99: warning: Function parameter or member 'hwmsg' not described in 'format_hwmsg'
       drivers/infiniband/hw/hfi1/intr.c:115: warning: Function parameter or member 'hwerrs' not described in 'hfi1_format_hwerrors'
       drivers/infiniband/hw/hfi1/intr.c:115: warning: Function parameter or member 'hwerrmsgs' not described in 'hfi1_format_hwerrors'
       drivers/infiniband/hw/hfi1/intr.c:115: warning: Function parameter or member 'nhwerrmsgs' not described in 'hfi1_format_hwerrors'
       drivers/infiniband/hw/hfi1/intr.c:115: warning: Function parameter or member 'msg' not described in 'hfi1_format_hwerrors'
       drivers/infiniband/hw/hfi1/intr.c:115: warning: Function parameter or member 'msgl' not described in 'hfi1_format_hwerrors'
      
      Link: https://lore.kernel.org/r/20210126124732.3320971-2-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      510a8949
    • Bob Pearson's avatar
      RDMA/rxe: Replace missing rxe_pool_get_index_locked · ce2063e3
      Bob Pearson authored
      One of the pool APIs for when caller is holding lock was not defined but
      is declared in rxe_pool.h. This patch adds the definition.
      
      Link: https://lore.kernel.org/r/20210125211641.2694-7-rpearson@hpe.comSigned-off-by: default avatarBob Pearson <rpearson@hpe.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      ce2063e3
    • Bob Pearson's avatar
      RDMA/rxe: Remove unneeded pool->state · eae5f064
      Bob Pearson authored
      rxe_pool.c uses the field pool->state to mark a pool as invalid when it is
      shut down and checks it in several pool APIs to verify that the pool has
      not been shut down. This is unneeded because the pools are not marked
      invalid unless the entire driver is being removed at which point no
      functional APIs should or could be executing. This patch removes this
      field and associated code.
      
      Link: https://lore.kernel.org/r/20210125211641.2694-6-rpearson@hpe.com
      Suggested-by: zyjzyj2000@gmail.c
      Signed-off-by: default avatarBob Pearson <rpearson@hpe.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      eae5f064
    • Bob Pearson's avatar
      RDMA/rxe: Remove references to ib_device and pool · 6cde3e8e
      Bob Pearson authored
      rxe_pool.c takes references to the pool and ib_device structs for each
      object allocated and also keeps an atomic num_elem count in each
      pool. This is more work than is needed. Pool allocation is only called
      from verbs APIs which already have references to ib_device and pools are
      only diasbled when the driver is removed so no protection of the pool
      addresses are needed. The elem count is used to warn if elements are still
      present in a pool when it is cleaned up which is useful.
      
      This patch eliminates the references to the ib_device and pool structs.
      
      Link: https://lore.kernel.org/r/20210125211641.2694-5-rpearson@hpe.comSigned-off-by: default avatarBob Pearson <rpearson@hpe.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      6cde3e8e
    • Bob Pearson's avatar
      RDMA/rxe: Remove RXE_POOL_ATOMIC · 4276fd0d
      Bob Pearson authored
      rxe_alloc() used the RXE_POOL_ATOMIC flag in rxe_type_info to select
      GFP_ATOMIC in calls to kzalloc(). This was intended to handle cases where
      an object could be created in interrupt context. This no longer occurs
      since allocating those objects has moved into the core so this flag is not
      necessary. An incorrect use of this flag was still present for rxe_mc_elem
      objects and is removed.
      
      Link: https://lore.kernel.org/r/20210125211641.2694-4-rpearson@hpe.comSigned-off-by: default avatarBob Pearson <rpearson@hpe.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      4276fd0d
    • Bob Pearson's avatar
      RDMA/rxe: Fix misleading comments and names · 88cc77eb
      Bob Pearson authored
      The names and comments of the 'unlocked' pool APIs are very misleading and
      not what was intended. This patch replaces 'rxe_xxx_nl' with
      'rxe_xxx_locked' with comments indicating that the caller is expected to
      hold the rxe pool lock.
      
      Link: https://lore.kernel.org/r/20210125211641.2694-3-rpearson@hpe.comReported-by: default avatarHillf Danton <hdanton@sina.com>
      Suggested-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      Signed-off-by: default avatarBob Pearson <rpearson@hpe.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      88cc77eb
    • Bob Pearson's avatar
      RDMA/rxe: Fix bug in rxe_alloc() · c4369575
      Bob Pearson authored
      A recent patch which added an 'unlocked' version of rxe_alloc introduced a
      bug causing kzalloc(..., GFP_KERNEL) to be called while holding a spin
      lock. This patch corrects that error.
      
      rxe_alloc_nl() should always be called while holding the pool->pool_lock
      so the 2nd argument to kzalloc there should be GFP_ATOMIC.
      
      rxe_alloc() prior to the change only locked the code around checking that
      pool->state is RXE_POOL_STATE_VALID to avoid races between working threads
      and a thread shutting down the rxe driver. This patch reverts rxe_alloc()
      to this behavior so the lock is not held when kzalloc() is called.
      
      Link: https://lore.kernel.org/r/20210125211641.2694-2-rpearson@hpe.com
      Reported-by: syzbot+ec2fd72374785d0e558e@syzkaller.appspotmail.com
      Fixes: 3853c35e ("RDMA/rxe: Add unlocked versions of pool APIs")
      Signed-off-by: default avatarBob Pearson <rpearson@hpe.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      c4369575
    • Shay Drory's avatar
      IB/umad: Return EPOLLERR in case of when device disassociated · def4cd43
      Shay Drory authored
      Currently, polling a umad device will always works, even if the device was
      disassociated. A disassociated device should immediately return EPOLLERR
      from poll(). Otherwise userspace is endlessly hung on poll() with no idea
      that the device has been removed from the system.
      
      Fixes: 1da177e4 ("Linux-2.6.12-rc2")
      Link: https://lore.kernel.org/r/20210125121339.837518-3-leon@kernel.orgSigned-off-by: default avatarShay Drory <shayd@nvidia.com>
      Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      def4cd43
    • Shay Drory's avatar
      IB/umad: Return EIO in case of when device disassociated · 4fc54618
      Shay Drory authored
      MAD message received by the user has EINVAL error in all flows
      including when the device is disassociated. That makes it impossible
      for the applications to treat such flow differently.
      
      Change it to return EIO, so the applications will be able to perform
      disassociation recovery.
      
      Fixes: 1da177e4 ("Linux-2.6.12-rc2")
      Link: https://lore.kernel.org/r/20210125121339.837518-2-leon@kernel.orgSigned-off-by: default avatarShay Drory <shayd@nvidia.com>
      Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      4fc54618
    • Mark Bloch's avatar
      RDMA/mlx5: Allow creating all QPs even when non RDMA profile is used · 2614488d
      Mark Bloch authored
      The cited commit disallowed creating any QP which isn't raw ethernet, reg
      umr or the special UD qp for testing WC, this proved too strict.
      
      While modify can't be done (no GIDS/GID table for example) just creating a
      QP is okay.
      
      This patch partially reverts the bellow mentioned commit and places the
      restriction at the modify QP stage and not at the creation.  DEVX commands
      should be used to manipulate such QPs.
      
      Fixes: 42caf9cb ("RDMA/mlx5: Allow only raw Ethernet QPs when RoCE isn't enabled")
      Link: https://lore.kernel.org/r/20210125120709.836718-1-leon@kernel.orgSigned-off-by: default avatarMark Bloch <mbloch@nvidia.com>
      Reviewed-by: default avatarMaor Gottlieb <maorg@mellanox.com>
      Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      2614488d
    • Maor Gottlieb's avatar
      tools/testing/scatterlist: Fix overflow of max segment size · 96667052
      Maor Gottlieb authored
      Because SCATTERLIST_MAX_SEGMENT was removed and replaced with UINT_MAX,
      the test overflows the max_sgement variable. Remove this case.
      
      Fixes: 7a60c2dd ("drm: Remove SCATTERLIST_MAX_SEGMENT")
      Link: https://lore.kernel.org/r/20210125120527.836363-1-leon@kernel.orgSigned-off-by: default avatarMaor Gottlieb <maorg@nvidia.com>
      Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      96667052
    • Lang Cheng's avatar
      RDMA/hns: Use new interface to set MPT related fields · dc504774
      Lang Cheng authored
      Achieve hr_reg_write() to simply the codes to fill fields.
      
      Link: https://lore.kernel.org/r/1611395282-991-4-git-send-email-liweihang@huawei.comSigned-off-by: default avatarLang Cheng <chenglang@huawei.com>
      Signed-off-by: default avatarWeihang Li <liweihang@huawei.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      dc504774
    • Lang Cheng's avatar
      RDMA/hns: Optimize the MR registration process · 4e9fc1da
      Lang Cheng authored
      When creating or re-registering an MR, storing the PDN, access flag and
      IOVA information ASAP can simplify the number of parameters passed into
      the subsequent process.
      
      Link: https://lore.kernel.org/r/1611395282-991-3-git-send-email-liweihang@huawei.comReported-by: default avatarkernel test robot <lkp@intel.com>
      Signed-off-by: default avatarLang Cheng <chenglang@huawei.com>
      Signed-off-by: default avatarWeihang Li <liweihang@huawei.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      4e9fc1da
    • Xi Wang's avatar
      RDMA/hns: Refactor the MTR creation flow · 0e0ab04b
      Xi Wang authored
      Split the hns_roce_mtr_create() into serval small functions, remove unused
      member in 'struct hns_roce_buf_attr' and delete unnecessary MTR page count
      check flow to make the MTR creation related codes clearer.
      
      Link: https://lore.kernel.org/r/1611395282-991-2-git-send-email-liweihang@huawei.comSigned-off-by: default avatarXi Wang <wangxi11@huawei.com>
      Signed-off-by: default avatarWeihang Li <liweihang@huawei.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      0e0ab04b
  2. 22 Jan, 2021 9 commits
    • Lee Jones's avatar
      RDMA/sw/rdmavt/qp: Fix a bunch of kernel-doc misdemeanours · f8e9a970
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/sw/rdmavt/qp.c:165: warning: Function parameter or member 'rdi' not described in 'rvt_wss_init'
       drivers/infiniband/sw/rdmavt/qp.c:329: warning: Function parameter or member 'rdi' not described in 'init_qpn_table'
       drivers/infiniband/sw/rdmavt/qp.c:534: warning: Function parameter or member 'type' not described in 'alloc_qpn'
       drivers/infiniband/sw/rdmavt/qp.c:664: warning: Function parameter or member 'wqe' not described in 'rvt_swqe_has_lkey'
       drivers/infiniband/sw/rdmavt/qp.c:664: warning: Function parameter or member 'lkey' not described in 'rvt_swqe_has_lkey'
       drivers/infiniband/sw/rdmavt/qp.c:682: warning: Function parameter or member 'qp' not described in 'rvt_qp_sends_has_lkey'
       drivers/infiniband/sw/rdmavt/qp.c:682: warning: Function parameter or member 'lkey' not described in 'rvt_qp_sends_has_lkey'
       drivers/infiniband/sw/rdmavt/qp.c:706: warning: Function parameter or member 'qp' not described in 'rvt_qp_acks_has_lkey'
       drivers/infiniband/sw/rdmavt/qp.c:706: warning: Function parameter or member 'lkey' not described in 'rvt_qp_acks_has_lkey'
       drivers/infiniband/sw/rdmavt/qp.c:866: warning: Function parameter or member 'rdi' not described in 'rvt_init_qp'
       drivers/infiniband/sw/rdmavt/qp.c:920: warning: Function parameter or member 'rdi' not described in '_rvt_reset_qp'
       drivers/infiniband/sw/rdmavt/qp.c:1736: warning: Function parameter or member 'udata' not described in 'rvt_destroy_qp'
       drivers/infiniband/sw/rdmavt/qp.c:1924: warning: Function parameter or member 'qp' not described in 'rvt_qp_valid_operation'
       drivers/infiniband/sw/rdmavt/qp.c:1924: warning: Function parameter or member 'post_parms' not described in 'rvt_qp_valid_operation'
       drivers/infiniband/sw/rdmavt/qp.c:1924: warning: Function parameter or member 'wr' not described in 'rvt_qp_valid_operation'
       drivers/infiniband/sw/rdmavt/qp.c:2020: warning: Function parameter or member 'call_send' not described in 'rvt_post_one_wr'
       drivers/infiniband/sw/rdmavt/qp.c:2621: warning: Function parameter or member 'qp' not described in 'rvt_stop_rnr_timer'
      
      Link: https://lore.kernel.org/r/20210121094519.2044049-31-lee.jones@linaro.org
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      f8e9a970
    • Lee Jones's avatar
      RDMA/hw/qib/qib_iba6120: Fix some repeated (copy/paste) kernel-doc issues · 71f964c3
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/qib/qib_iba6120.c:1229: warning: Function parameter or member 'ppd' not described in 'qib_6120_bringup_serdes'
       drivers/infiniband/hw/qib/qib_iba6120.c:1229: warning: Excess function parameter 'dd' description in 'qib_6120_bringup_serdes'
       drivers/infiniband/hw/qib/qib_iba6120.c:1436: warning: Function parameter or member 'ppd' not described in 'qib_6120_setup_setextled'
       drivers/infiniband/hw/qib/qib_iba6120.c:1436: warning: Excess function parameter 'dd' description in 'qib_6120_setup_setextled'
       drivers/infiniband/hw/qib/qib_iba6120.c:1836: warning: Function parameter or member 'type' not described in 'qib_6120_put_tid'
       drivers/infiniband/hw/qib/qib_iba6120.c:1836: warning: Excess function parameter 'tidtype' description in 'qib_6120_put_tid'
       drivers/infiniband/hw/qib/qib_iba6120.c:1903: warning: Function parameter or member 'type' not described in 'qib_6120_put_tid_2'
       drivers/infiniband/hw/qib/qib_iba6120.c:1903: warning: Excess function parameter 'tidtype' description in 'qib_6120_put_tid_2'
       drivers/infiniband/hw/qib/qib_iba6120.c:1944: warning: Function parameter or member 'rcd' not described in 'qib_6120_clear_tids'
       drivers/infiniband/hw/qib/qib_iba6120.c:1944: warning: Excess function parameter 'ctxt' description in 'qib_6120_clear_tids'
       drivers/infiniband/hw/qib/qib_iba6120.c:2018: warning: Function parameter or member 'kinfo' not described in 'qib_6120_get_base_info'
       drivers/infiniband/hw/qib/qib_iba6120.c:2018: warning: Excess function parameter 'kbase' description in 'qib_6120_get_base_info'
       drivers/infiniband/hw/qib/qib_iba6120.c:2277: warning: Function parameter or member 'ppd' not described in 'qib_portcntr_6120'
       drivers/infiniband/hw/qib/qib_iba6120.c:2277: warning: Function parameter or member 'reg' not described in 'qib_portcntr_6120'
       drivers/infiniband/hw/qib/qib_iba6120.c:2277: warning: Excess function parameter 'dd' description in 'qib_portcntr_6120'
       drivers/infiniband/hw/qib/qib_iba6120.c:2277: warning: Excess function parameter 'creg' description in 'qib_portcntr_6120'
       drivers/infiniband/hw/qib/qib_iba6120.c:2620: warning: Function parameter or member 't' not described in 'qib_get_6120_faststats'
      
      Link: https://lore.kernel.org/r/20210121094519.2044049-30-lee.jones@linaro.org
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      71f964c3
    • Lee Jones's avatar
      RDMA/hw/qib/qib_verbs: Repair some formatting problems · 3c2504be
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/qib/qib_verbs.c:1077: warning: Function parameter or member 'ppd' not described in 'qib_get_counters'
       drivers/infiniband/hw/qib/qib_verbs.c:1077: warning: Excess function parameter 'dd' description in 'qib_get_counters'
       drivers/infiniband/hw/qib/qib_verbs.c:1686: warning: Function parameter or member 'qp' not described in '_qib_schedule_send'
       drivers/infiniband/hw/qib/qib_verbs.c:1703: warning: Function parameter or member 'qp' not described in 'qib_schedule_send'
      
      Link: https://lore.kernel.org/r/20210121094519.2044049-29-lee.jones@linaro.org
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      3c2504be
    • Lee Jones's avatar
      RDMA/hw/qib/qib_iba7322: Fix a bunch of copy/paste issues · a8a47b16
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/qib/qib_iba7322.c:2521: warning: Function parameter or member 'ppd' not described in 'qib_7322_mini_quiet_serdes'
       drivers/infiniband/hw/qib/qib_iba7322.c:2521: warning: Excess function parameter 'dd' description in 'qib_7322_mini_quiet_serdes'
       drivers/infiniband/hw/qib/qib_iba7322.c:3768: warning: Function parameter or member 'type' not described in 'qib_7322_put_tid'
       drivers/infiniband/hw/qib/qib_iba7322.c:3768: warning: Excess function parameter 'tidtype' description in 'qib_7322_put_tid'
       drivers/infiniband/hw/qib/qib_iba7322.c:3806: warning: Function parameter or member 'rcd' not described in 'qib_7322_clear_tids'
       drivers/infiniband/hw/qib/qib_iba7322.c:3806: warning: Excess function parameter 'ctxt' description in 'qib_7322_clear_tids'
       drivers/infiniband/hw/qib/qib_iba7322.c:3872: warning: Function parameter or member 'kinfo' not described in 'qib_7322_get_base_info'
       drivers/infiniband/hw/qib/qib_iba7322.c:3872: warning: Excess function parameter 'kbase' description in 'qib_7322_get_base_info'
       drivers/infiniband/hw/qib/qib_iba7322.c:4730: warning: Function parameter or member 'reg' not described in 'qib_portcntr_7322'
       drivers/infiniband/hw/qib/qib_iba7322.c:4730: warning: Excess function parameter 'creg' description in 'qib_portcntr_7322'
       drivers/infiniband/hw/qib/qib_iba7322.c:5109: warning: Function parameter or member 't' not described in 'qib_get_7322_faststats'
       drivers/infiniband/hw/qib/qib_iba7322.c:7189: warning: Function parameter or member 'pdev' not described in 'qib_init_iba7322_funcs'
       drivers/infiniband/hw/qib/qib_iba7322.c:7189: warning: Excess function parameter 'dev' description in 'qib_init_iba7322_funcs'
      
      Link: https://lore.kernel.org/r/20210121094519.2044049-28-lee.jones@linaro.org
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      a8a47b16
    • Lee Jones's avatar
      RDMA/sw/rdmavt/mr: Fix some issues related to formatting and missing descriptions · cf8f5cea
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/sw/rdmavt/mr.c:380: warning: Function parameter or member 'virt_addr' not described in 'rvt_reg_user_mr'
       drivers/infiniband/sw/rdmavt/mr.c:449: warning: Function parameter or member 'qp' not described in 'rvt_dereg_clean_qp_cb'
       drivers/infiniband/sw/rdmavt/mr.c:449: warning: Function parameter or member 'v' not described in 'rvt_dereg_clean_qp_cb'
       drivers/infiniband/sw/rdmavt/mr.c:466: warning: Function parameter or member 'mr' not described in 'rvt_dereg_clean_qps'
       drivers/infiniband/sw/rdmavt/mr.c:484: warning: Function parameter or member 'mr' not described in 'rvt_check_refs'
       drivers/infiniband/sw/rdmavt/mr.c:484: warning: Function parameter or member 't' not described in 'rvt_check_refs'
       drivers/infiniband/sw/rdmavt/mr.c:513: warning: Function parameter or member 'mr' not described in 'rvt_mr_has_lkey'
       drivers/infiniband/sw/rdmavt/mr.c:513: warning: Function parameter or member 'lkey' not described in 'rvt_mr_has_lkey'
       drivers/infiniband/sw/rdmavt/mr.c:526: warning: Function parameter or member 'ss' not described in 'rvt_ss_has_lkey'
       drivers/infiniband/sw/rdmavt/mr.c:526: warning: Function parameter or member 'lkey' not described in 'rvt_ss_has_lkey'
       drivers/infiniband/sw/rdmavt/mr.c:551: warning: Function parameter or member 'udata' not described in 'rvt_dereg_mr'
      
      Link: https://lore.kernel.org/r/20210121094519.2044049-27-lee.jones@linaro.org
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      cf8f5cea
    • Lee Jones's avatar
      RDMA/hw/hfi1/file_ops: Fix' manage_rcvq()'s 'arg' param · 8e9a197e
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/file_ops.c:1533: warning: Function parameter or member 'arg' not described in 'manage_rcvq'
       drivers/infiniband/hw/hfi1/file_ops.c:1533: warning: Excess function parameter 'start_stop' description in 'manage_rcvq'
      
      Link: https://lore.kernel.org/r/20210121094519.2044049-26-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      8e9a197e
    • Lee Jones's avatar
      RDMA/hw/qib/qib_iba7220: Fix some kernel-doc issues · f40164f9
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/qib/qib_iba7220.c:1726: warning: Function parameter or member 'ppd' not described in 'qib_setup_7220_setextled'
       drivers/infiniband/hw/qib/qib_iba7220.c:1726: warning: Excess function parameter 'dd' description in 'qib_setup_7220_setextled'
       drivers/infiniband/hw/qib/qib_iba7220.c:2154: warning: Function parameter or member 'type' not described in 'qib_7220_put_tid'
       drivers/infiniband/hw/qib/qib_iba7220.c:2154: warning: Excess function parameter 'tidtype' description in 'qib_7220_put_tid'
       drivers/infiniband/hw/qib/qib_iba7220.c:2192: warning: Function parameter or member 'rcd' not described in 'qib_7220_clear_tids'
       drivers/infiniband/hw/qib/qib_iba7220.c:2192: warning: Excess function parameter 'ctxt' description in 'qib_7220_clear_tids'
       drivers/infiniband/hw/qib/qib_iba7220.c:2248: warning: Function parameter or member 'kinfo' not described in 'qib_7220_get_base_info'
       drivers/infiniband/hw/qib/qib_iba7220.c:2248: warning: Excess function parameter 'kbase' description in 'qib_7220_get_base_info'
       drivers/infiniband/hw/qib/qib_iba7220.c:2903: warning: Function parameter or member 'ppd' not described in 'qib_portcntr_7220'
       drivers/infiniband/hw/qib/qib_iba7220.c:2903: warning: Function parameter or member 'reg' not described in 'qib_portcntr_7220'
       drivers/infiniband/hw/qib/qib_iba7220.c:2903: warning: Excess function parameter 'dd' description in 'qib_portcntr_7220'
       drivers/infiniband/hw/qib/qib_iba7220.c:2903: warning: Excess function parameter 'creg' description in 'qib_portcntr_7220'
       drivers/infiniband/hw/qib/qib_iba7220.c:3242: warning: Function parameter or member 't' not described in 'qib_get_7220_faststats'
       drivers/infiniband/hw/qib/qib_iba7220.c:4479: warning: Function parameter or member 'pdev' not described in 'qib_init_iba7220_funcs'
       drivers/infiniband/hw/qib/qib_iba7220.c:4479: warning: Excess function parameter 'dev' description in 'qib_init_iba7220_funcs'
      
      Link: https://lore.kernel.org/r/20210121094519.2044049-25-lee.jones@linaro.org
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      f40164f9
    • Lee Jones's avatar
      RDMA/hw/hfi1/exp_rcv: Fix some kernel-doc formatting issues · 9d2338ca
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/hw/hfi1/exp_rcv.c:56: warning: Function parameter or member 'set' not described in 'hfi1_exp_tid_set_init'
       drivers/infiniband/hw/hfi1/exp_rcv.c:66: warning: Function parameter or member 'rcd' not described in 'hfi1_exp_tid_group_init'
       drivers/infiniband/hw/hfi1/exp_rcv.c:77: warning: Function parameter or member 'rcd' not described in 'hfi1_alloc_ctxt_rcv_groups'
       drivers/infiniband/hw/hfi1/exp_rcv.c:114: warning: Function parameter or member 'rcd' not described in 'hfi1_free_ctxt_rcv_groups'
      
      Link: https://lore.kernel.org/r/20210121094519.2044049-24-lee.jones@linaro.org
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      9d2338ca
    • Lee Jones's avatar
      RDMA/sw/rdmavt/mcast: Demote incomplete kernel-doc header · 00d25ff6
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/infiniband/sw/rdmavt/mcast.c:195: warning: Function parameter or member 'rdi' not described in 'rvt_mcast_add'
       drivers/infiniband/sw/rdmavt/mcast.c:195: warning: Function parameter or member 'ibp' not described in 'rvt_mcast_add'
      
      Link: https://lore.kernel.org/r/20210121094519.2044049-23-lee.jones@linaro.org
      Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
      Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
      Cc: Doug Ledford <dledford@redhat.com>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: linux-rdma@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      00d25ff6