1. 19 Apr, 2024 1 commit
    • David Howells's avatar
      cifs: Fix reacquisition of volume cookie on still-live connection · dad80c6b
      David Howells authored
      During mount, cifs_mount_get_tcon() gets a tcon resource connection record
      and then attaches an fscache volume cookie to it.  However, it does this
      irrespective of whether or not the tcon returned from cifs_get_tcon() is a
      new record or one that's already in use.  This leads to a warning about a
      volume cookie collision and a leaked volume cookie because tcon->fscache
      gets reset.
      
      Fix this be adding a mutex and a "we've already tried this" flag and only
      doing it once for the lifetime of the tcon.
      
      [!] Note: Looking at cifs_mount_get_tcon(), a more general solution may
      actually be required.  Reacquiring the volume cookie isn't the only thing
      that function does: it also partially reinitialises the tcon record without
      any locking - which may cause live filesystem ops already using the tcon
      through a previous mount to malfunction.
      
      This can be reproduced simply by something like:
      
          mount //example.com/test /xfstest.test -o user=shares,pass=xxx,fsc
          mount //example.com/test /mnt -o user=shares,pass=xxx,fsc
      
      Fixes: 70431bfd ("cifs: Support fscache indexing rewrite")
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Acked-by: default avatarPaulo Alcantara (Red Hat) <pc@manguebit.com>
      cc: Shyam Prasad N <sprasad@microsoft.com>
      cc: linux-cifs@vger.kernel.org
      cc: linux-fsdevel@vger.kernel.org
      Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
      dad80c6b
  2. 14 Apr, 2024 10 commits
  3. 13 Apr, 2024 5 commits
    • Linus Torvalds's avatar
      Merge tag 'ata-6.9-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux · 7efd0a74
      Linus Torvalds authored
      Pull ata fixes from Damien Le Moal:
      
       - Add the mask_port_map parameter to the ahci driver. This is a
         follow-up to the recent snafu with the ASMedia controller and its
         virtual port hidding port-multiplier devices. As ASMedia confirmed
         that there is no way to determine if these slow-to-probe virtual
         ports are actually representing the ports of a port-multiplier
         devices, this new parameter allow masking ports to significantly
         speed up probing during system boot, resulting in shorter boot times.
      
       - A fix for an incorrect handling of a port unlock in
         ata_scsi_dev_rescan().
      
       - Allow command duration limits to be detected for ACS-4 devices are
         there are such devices out in the field.
      
      * tag 'ata-6.9-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux:
        ata: libata-core: Allow command duration limits detection for ACS-4 drives
        ata: libata-scsi: Fix ata_scsi_dev_rescan() error path
        ata: ahci: Add mask_port_map module parameter
      7efd0a74
    • Linus Torvalds's avatar
      Merge tag 'zonefs-6.9-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/zonefs · 76b0e9c4
      Linus Torvalds authored
      Pull zonefs fix from Damien Le Moal:
      
       - Suppress a coccicheck warning using str_plural()
      
      * tag 'zonefs-6.9-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/zonefs:
        zonefs: Use str_plural() to fix Coccinelle warning
      76b0e9c4
    • Linus Torvalds's avatar
      Merge tag 'v6.9-rc3-SMB3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6 · fa4022cb
      Linus Torvalds authored
      Pull smb client fixes from Steve French:
      
       - fix for oops in cifs_get_fattr of deleted files
      
       - fix for the remote open counter going negative in some directory
         lease cases
      
       - fix for mkfifo to instantiate dentry to avoid possible crash
      
       - important fix to allow handling key rotation for mount and remount
         (ie cases that are becoming more common when password that was used
         for the mount will expire soon but will be replaced by new password)
      
      * tag 'v6.9-rc3-SMB3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6:
        smb3: fix broken reconnect when password changing on the server by allowing password rotation
        smb: client: instantiate when creating SFU files
        smb3: fix Open files on server counter going negative
        smb: client: fix NULL ptr deref in cifs_mark_open_handles_for_deleted_file()
      fa4022cb
    • Igor Pylypiv's avatar
      ata: libata-core: Allow command duration limits detection for ACS-4 drives · c0297e7d
      Igor Pylypiv authored
      Even though the command duration limits (CDL) feature was first added
      in ACS-5 (major version 12), there are some ACS-4 (major version 11)
      drives that implement CDL as well.
      
      IDENTIFY_DEVICE, SUPPORTED_CAPABILITIES, and CURRENT_SETTINGS log pages
      are mandatory in the ACS-4 standard so it should be safe to read these
      log pages on older drives implementing the ACS-4 standard.
      
      Fixes: 62e4a60e ("scsi: ata: libata: Detect support for command duration limits")
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarIgor Pylypiv <ipylypiv@google.com>
      Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      c0297e7d
    • Damien Le Moal's avatar
      ata: libata-scsi: Fix ata_scsi_dev_rescan() error path · 79336504
      Damien Le Moal authored
      Commit 0c76106c ("scsi: sd: Fix TCG OPAL unlock on system resume")
      incorrectly handles failures of scsi_resume_device() in
      ata_scsi_dev_rescan(), leading to a double call to
      spin_unlock_irqrestore() to unlock a device port. Fix this by redefining
      the goto labels used in case of errors and only unlock the port
      scsi_scan_mutex when scsi_resume_device() fails.
      
      Bug found with the Smatch static checker warning:
      
      	drivers/ata/libata-scsi.c:4774 ata_scsi_dev_rescan()
      	error: double unlocked 'ap->lock' (orig line 4757)
      Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
      Fixes: 0c76106c ("scsi: sd: Fix TCG OPAL unlock on system resume")
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      Reviewed-by: default avatarNiklas Cassel <cassel@kernel.org>
      79336504
  4. 12 Apr, 2024 24 commits
    • Linus Torvalds's avatar
      Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux · 8f2c0577
      Linus Torvalds authored
      Pull arm64 fix from Catalin Marinas:
       "Fix the TLBI RANGE operand calculation causing live migration under
        KVM/arm64 to miss dirty pages due to stale TLB entries"
      
      * tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux:
        arm64: tlb: Fix TLBI RANGE operand
      8f2c0577
    • Linus Torvalds's avatar
      Merge tag 'soc-fixes-6.9-1' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc · 678e14c7
      Linus Torvalds authored
      Pull SoC fixes from Arnd Bergmann:
       "The device tree changes this time are all for NXP i.MX platforms,
        addressing issues with clocks and regulators on i.MX7 and i.MX8.
      
        The old OMAP2 based Nokia N8x0 tablet get a couple of code fixes for
        regressions that came in.
      
        The ARM SCMI and FF-A firmware interfaces get a couple of minor bug
        fixes.
      
        A regression fix for RISC-V cache management addresses a problem with
        probe order on Sifive cores"
      
      * tag 'soc-fixes-6.9-1' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc: (23 commits)
        MAINTAINERS: Change Krzysztof Kozlowski's email address
        arm64: dts: imx8qm-ss-dma: fix can lpcg indices
        arm64: dts: imx8-ss-dma: fix can lpcg indices
        arm64: dts: imx8-ss-dma: fix adc lpcg indices
        arm64: dts: imx8-ss-dma: fix pwm lpcg indices
        arm64: dts: imx8-ss-dma: fix spi lpcg indices
        arm64: dts: imx8-ss-conn: fix usb lpcg indices
        arm64: dts: imx8-ss-lsio: fix pwm lpcg indices
        ARM: dts: imx7s-warp: Pass OV2680 link-frequencies
        ARM: dts: imx7-mba7: Use 'no-mmc' property
        arm64: dts: imx8-ss-conn: fix usdhc wrong lpcg clock order
        arm64: dts: freescale: imx8mp-venice-gw73xx-2x: fix USB vbus regulator
        arm64: dts: freescale: imx8mp-venice-gw72xx-2x: fix USB vbus regulator
        cache: sifive_ccache: Partially convert to a platform driver
        firmware: arm_scmi: Make raw debugfs entries non-seekable
        firmware: arm_scmi: Fix wrong fastchannel initialization
        firmware: arm_ffa: Fix the partition ID check in ffa_notification_info_get()
        ARM: OMAP2+: fix USB regression on Nokia N8x0
        mmc: omap: restore original power up/down steps
        mmc: omap: fix deferred probe
        ...
      678e14c7
    • Linus Torvalds's avatar
      Merge tag 'iommu-fixes-v6.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu · c7c4e130
      Linus Torvalds authored
      Pull iommu fixes from Joerg Roedel:
      
       - Intel VT-d Fixes:
           - Allocate local memory for PRQ page
           - Fix WARN_ON in iommu probe path
           - Fix wrong use of pasid config
      
       - AMD IOMMU Fixes:
           - Lock inversion fix
           - Log message severity fix
           - Disable SNP when v2 page-tables are used
      
       - Mediatek driver:
           - Fix module autoloading
      
      * tag 'iommu-fixes-v6.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu:
        iommu/amd: Change log message severity
        iommu/vt-d: Fix WARN_ON in iommu probe path
        iommu/vt-d: Allocate local memory for page request queue
        iommu/vt-d: Fix wrong use of pasid config
        iommu: mtk: fix module autoloading
        iommu/amd: Do not enable SNP when V2 page table is enabled
        iommu/amd: Fix possible irq lock inversion dependency issue
      c7c4e130
    • Linus Torvalds's avatar
      Merge tag 'pci-v6.9-fixes-1' of git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci · b3812ff0
      Linus Torvalds authored
      Pull pci fixes from Bjorn Helgaas:
      
       - Revert a quirk that prevented Secondary Bus Reset for LSI / Agere
         FW643.
      
         We thought the device was broken, but the reset does work correctly
         on other platforms, and the reset avoids leaking data out of VMs
         (Bjorn Helgaas)
      
       - Update MAINTAINERS to reflect that Gustavo Pimentel is no longer
         reachable (Manivannan Sadhasivam)
      
      * tag 'pci-v6.9-fixes-1' of git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci:
        Revert "PCI: Mark LSI FW643 to avoid bus reset"
        MAINTAINERS: Drop Gustavo Pimentel as PCI DWC Maintainer
      b3812ff0
    • Linus Torvalds's avatar
      Merge tag 'block-6.9-20240412' of git://git.kernel.dk/linux · d7ad0581
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
      
       - MD pull request via Song:
             - UAF fix (Yu)
      
       - Avoid out-of-bounds shift in blk-iocost (Rik)
      
       - Fix for q->blkg_list corruption (Ming)
      
       - Relax virt boundary mask/size segment checking (Ming)
      
      * tag 'block-6.9-20240412' of git://git.kernel.dk/linux:
        block: fix that blk_time_get_ns() doesn't update time after schedule
        block: allow device to have both virt_boundary_mask and max segment size
        block: fix q->blkg_list corruption during disk rebind
        blk-iocost: avoid out of bounds shift
        raid1: fix use-after-free for original bio in raid1_write_request()
      d7ad0581
    • Linus Torvalds's avatar
      Merge tag 'io_uring-6.9-20240412' of git://git.kernel.dk/linux · c7adbe2e
      Linus Torvalds authored
      Pull io_uring fixes from Jens Axboe:
      
       - Fix for sigmask restoring while waiting for events (Alexey)
      
       - Typo fix in comment (Haiyue)
      
       - Fix for a msg_control retstore on SEND_ZC retries (Pavel)
      
      * tag 'io_uring-6.9-20240412' of git://git.kernel.dk/linux:
        io-uring: correct typo in comment for IOU_F_TWQ_LAZY_WAKE
        io_uring/net: restore msg_control on sendzc retry
        io_uring: Fix io_cqring_wait() not restoring sigmask on get_timespec64() failure
      c7adbe2e
    • Linus Torvalds's avatar
      Merge tag 'ceph-for-6.9-rc4' of https://github.com/ceph/ceph-client · 90d3eaaf
      Linus Torvalds authored
      Pull ceph fixes from Ilya Dryomov:
       "Two CephFS fixes marked for stable and a MAINTAINERS update"
      
      * tag 'ceph-for-6.9-rc4' of https://github.com/ceph/ceph-client:
        MAINTAINERS: remove myself as a Reviewer for Ceph
        ceph: switch to use cap_delay_lock for the unlink delay list
        ceph: redirty page before returning AOP_WRITEPAGE_ACTIVATE
      90d3eaaf
    • Linus Torvalds's avatar
      Kconfig: add some hidden tabs on purpose · d5cf50da
      Linus Torvalds authored
      Commit d96c3600 ("tracing: Fix FTRACE_RECORD_RECURSION_SIZE Kconfig
      entry") removed a hidden tab because it apparently showed breakage in
      some third-party kernel config parsing tool.
      
      It wasn't clear what tool it was, but let's make sure it gets fixed.
      Because if you can't parse tabs as whitespace, you should not be parsing
      the kernel Kconfig files.
      
      In fact, let's make such breakage more obvious than some esoteric ftrace
      record size option.  If you can't parse tabs, you can't have page sizes.
      
      Yes, tab-vs-space confusion is sadly a traditional Unix thing, and
      'make' is famous for being broken in this regard.  But no, that does not
      mean that it's ok.
      
      I'd add more random tabs to our Kconfig files, but I don't want to make
      things uglier than necessary.  But it *might* bbe necessary if it turns
      out we see more of this kind of silly tooling.
      
      Fixes: d96c3600 ("tracing: Fix FTRACE_RECORD_RECURSION_SIZE Kconfig entry")
      Link: https://lore.kernel.org/lkml/CAHk-=wj-hLLN_t_m5OL4dXLaxvXKy_axuoJYXif7iczbfgAevQ@mail.gmail.com/Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      d5cf50da
    • Linus Torvalds's avatar
      Merge tag 'trace-v6.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace · 5939d451
      Linus Torvalds authored
      Pull tracing fixes from Steven Rostedt:
      
       - Fix the buffer_percent accounting as it is dependent on three
         variables:
      
           1) pages_read - number of subbuffers read
           2) pages_lost - number of subbuffers lost due to overwrite
           3) pages_touched - number of pages that a writer entered
      
         These three counters only increment, and to know how many active
         pages there are on the buffer at any given time, the pages_read and
         pages_lost are subtracted from pages_touched.
      
         But the pages touched was incremented whenever any writer went to the
         next subbuffer even if it wasn't the only one, so it was incremented
         more than it should be causing the counter for how many subbuffers
         currently have content incorrect, which caused the buffer_percent
         that holds waiters until the ring buffer is filled to a given
         percentage to wake up early.
      
       - Fix warning of unused functions when PERF_EVENTS is not configured in
      
       - Replace bad tab with space in Kconfig for FTRACE_RECORD_RECURSION_SIZE
      
       - Fix to some kerneldoc function comments in eventfs code.
      
      * tag 'trace-v6.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace:
        ring-buffer: Only update pages_touched when a new page is touched
        tracing: hide unused ftrace_event_id_fops
        tracing: Fix FTRACE_RECORD_RECURSION_SIZE Kconfig entry
        eventfs: Fix kernel-doc comments to functions
      5939d451
    • Linus Torvalds's avatar
      Merge tag 'mips-fixes_6.9_1' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux · e00011a1
      Linus Torvalds authored
      Pull MIPS fix from Thomas Bogendoerfer:
       "Fix for syscall_get_nr() to make it work even if tracing is disabled"
      
      * tag 'mips-fixes_6.9_1' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux:
        MIPS: scall: Save thread_info.syscall unconditionally on entry
      e00011a1
    • Linus Torvalds's avatar
      Merge tag 'drm-fixes-2024-04-12' of https://gitlab.freedesktop.org/drm/kernel · d1c13e80
      Linus Torvalds authored
      Pull drm fixes from Dave Airlie:
       "Looks like everyone woke up after holidays, this weeks pull has a
        bunch of stuff all over, 2 weeks worth of amdgpu is a lot of it, then
        i915/xe have a few, a bunch of msm fixes, then some scattered driver
        fixes.
      
        I expect things will settle down for rc5.
      
        client:
         - Protect connector modes with mode_config mutex
      
        ast:
         - Fix soft lockup
      
        host1x:
         - Do not setup DMA for virtual addresses
      
        ivpu:
         - Fix deadlock in context_xa
         - PCI fixes
         - Fixes to error handling
      
        nouveau:
         - gsp: Fix OOB access
         - Fix casting
      
        panfrost:
         - Fix error path in MMU code
      
        qxl:
         - Revert "drm/qxl: simplify qxl_fence_wait"
      
        vmwgfx:
         - Enable DMA for SEV mappings
      
        i915:
         - Couple CDCLK programming fixes
         - HDCP related fix
         - 4 Bigjoiner related fixes
         - Fix for a circular locking around GuC on reset+wedged case
      
        xe:
         - Fix double display mutex initializations
         - Fix u32 -> u64 implicit conversions
         - Fix RING_CONTEXT_CONTROL not marked as masked
      
        msm:
         - DP refcount leak fix on disconnect
         - Add missing newlines to prints in msm_fb and msm_kms
         - fix dpu debugfs entry permissions
         - Fix the interface table for the catalog of X1E80100
         - fix irq message printing
         - Bindings fix to add DP node as child of mdss for mdss node
         - Minor typo fix in DP driver API which handles port status change
         - fix CHRASHDUMP_READ()
         - fix HHB (highest bank bit) for a619 to fix UBWC corruption
      
        amdgpu:
         - GPU reset fixes
         - Fix some confusing logging
         - UMSCH fix
         - Aborted suspend fix
         - DCN 3.5 fixes
         - S4 fix
         - MES logging fixes
         - SMU 14 fixes
         - SDMA 4.4.2 fix
         - KASAN fix
         - SMU 13.0.10 fix
         - VCN partition fix
         - GFX11 fixes
         - DWB fixes
         - Plane handling fix
         - FAMS fix
         - DCN 3.1.6 fix
         - VSC SDP fixes
         - OLED panel fix
         - GFX 11.5 fix
      
        amdkfd:
         - GPU reset fixes
         - fix ioctl integer overflow"
      
      * tag 'drm-fixes-2024-04-12' of https://gitlab.freedesktop.org/drm/kernel: (65 commits)
        amdkfd: use calloc instead of kzalloc to avoid integer overflow
        drm/xe: Label RING_CONTEXT_CONTROL as masked
        drm/xe/xe_migrate: Cast to output precision before multiplying operands
        drm/xe/hwmon: Cast result to output precision on left shift of operand
        drm/xe/display: Fix double mutex initialization
        drm/amdgpu: differentiate external rev id for gfx 11.5.0
        drm/amd/display: Adjust dprefclk by down spread percentage.
        drm/amd/display: Set VSC SDP Colorimetry same way for MST and SST
        drm/amd/display: Program VSC SDP colorimetry for all DP sinks >= 1.4
        drm/amd/display: fix disable otg wa logic in DCN316
        drm/amd/display: Do not recursively call manual trigger programming
        drm/amd/display: always reset ODM mode in context when adding first plane
        drm/amdgpu: fix incorrect number of active RBs for gfx11
        drm/amd/display: Return max resolution supported by DWB
        amd/amdkfd: sync all devices to wait all processes being evicted
        drm/amdgpu: clear set_q_mode_offs when VM changed
        drm/amdgpu: Fix VCN allocation in CPX partition
        drm/amd/pm: fix the high voltage issue after unload
        drm/amd/display: Skip on writeback when it's not applicable
        drm/amdgpu: implement IRQ_STATE_ENABLE for SDMA v4.4.2
        ...
      d1c13e80
    • Oleg Nesterov's avatar
      selftests: kselftest: Fix build failure with NOLIBC · 16767502
      Oleg Nesterov authored
      As Mark explains ksft_min_kernel_version() can't be compiled with nolibc,
      it doesn't implement uname().
      
      Fixes: 6d029c25 ("selftests/timers/posix_timers: Reimplement check_timer_distribution()")
      Reported-by: default avatarMark Brown <broonie@kernel.org>
      Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Link: https://lore.kernel.org/r/20240412123536.GA32444@redhat.com
      Closes: https://lore.kernel.org/all/f0523b3a-ea08-4615-b0fb-5b504a2d39df@sirena.org.uk/
      16767502
    • Yu Kuai's avatar
      block: fix that blk_time_get_ns() doesn't update time after schedule · 3ec48489
      Yu Kuai authored
      While monitoring the throttle time of IO from iocost, it's found that
      such time is always zero after the io_schedule() from ioc_rqos_throttle,
      for example, with the following debug patch:
      
      +       printk("%s-%d: %s enter %llu\n", current->comm, current->pid, __func__, blk_time_get_ns());
              while (true) {
                      set_current_state(TASK_UNINTERRUPTIBLE);
                      if (wait.committed)
                              break;
                      io_schedule();
              }
      +       printk("%s-%d: %s exit  %llu\n", current->comm, current->pid, __func__, blk_time_get_ns());
      
      It can be observerd that blk_time_get_ns() always return the same time:
      
      [ 1068.096579] fio-1268: ioc_rqos_throttle enter 1067901962288
      [ 1068.272587] fio-1268: ioc_rqos_throttle exit  1067901962288
      [ 1068.274389] fio-1268: ioc_rqos_throttle enter 1067901962288
      [ 1068.472690] fio-1268: ioc_rqos_throttle exit  1067901962288
      [ 1068.474485] fio-1268: ioc_rqos_throttle enter 1067901962288
      [ 1068.672656] fio-1268: ioc_rqos_throttle exit  1067901962288
      [ 1068.674451] fio-1268: ioc_rqos_throttle enter 1067901962288
      [ 1068.872655] fio-1268: ioc_rqos_throttle exit  1067901962288
      
      And I think the root cause is that 'PF_BLOCK_TS' is always cleared
      by blk_flush_plug() before scheduel(), hence blk_plug_invalidate_ts()
      will never be called:
      
      blk_time_get_ns
       plug->cur_ktime = ktime_get_ns();
       current->flags |= PF_BLOCK_TS;
      
      io_schedule:
       io_schedule_prepare
        blk_flush_plug
         __blk_flush_plug
          /* the flag is cleared, while time is not */
          current->flags &= ~PF_BLOCK_TS;
       schedule
       sched_update_worker
        /* the flag is not set, hence plug->cur_ktime is not cleared */
        if (tsk->flags & PF_BLOCK_TS)
         blk_plug_invalidate_ts()
      
      blk_time_get_ns
       /* got the time stashed before schedule */
       return plug->cur_ktime;
      
      Fix the problem by clearing cached time in __blk_flush_plug().
      
      Fixes: 06b23f92 ("block: update cached timestamp post schedule/preemption")
      Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
      Link: https://lore.kernel.org/r/20240411032349.3051233-2-yukuai1@huaweicloud.comSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
      3ec48489
    • John Stultz's avatar
      selftests: timers: Fix abs() warning in posix_timers test · ed366de8
      John Stultz authored
      Building with clang results in the following warning:
      
        posix_timers.c:69:6: warning: absolute value function 'abs' given an
            argument of type 'long long' but has parameter of type 'int' which may
            cause truncation of value [-Wabsolute-value]
              if (abs(diff - DELAY * USECS_PER_SEC) > USECS_PER_SEC / 2) {
                  ^
      So switch to using llabs() instead.
      
      Fixes: 0bc4b0cf ("selftests: add basic posix timers selftests")
      Signed-off-by: default avatarJohn Stultz <jstultz@google.com>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Cc: stable@vger.kernel.org
      Link: https://lore.kernel.org/r/20240410232637.4135564-3-jstultz@google.com
      ed366de8
    • Nathan Chancellor's avatar
      selftests: kselftest: Mark functions that unconditionally call exit() as __noreturn · f7d5bcd3
      Nathan Chancellor authored
      After commit 6d029c25 ("selftests/timers/posix_timers: Reimplement
      check_timer_distribution()"), clang warns:
      
        tools/testing/selftests/timers/../kselftest.h:398:6: warning: variable 'major' is used uninitialized whenever '||' condition is true [-Wsometimes-uninitialized]
          398 |         if (uname(&info) || sscanf(info.release, "%u.%u.", &major, &minor) != 2)
              |             ^~~~~~~~~~~~
        tools/testing/selftests/timers/../kselftest.h:401:9: note: uninitialized use occurs here
          401 |         return major > min_major || (major == min_major && minor >= min_minor);
              |                ^~~~~
        tools/testing/selftests/timers/../kselftest.h:398:6: note: remove the '||' if its condition is always false
          398 |         if (uname(&info) || sscanf(info.release, "%u.%u.", &major, &minor) != 2)
              |             ^~~~~~~~~~~~~~~
        tools/testing/selftests/timers/../kselftest.h:395:20: note: initialize the variable 'major' to silence this warning
          395 |         unsigned int major, minor;
              |                           ^
              |                            = 0
      
      This is a false positive because if uname() fails, ksft_exit_fail_msg()
      will be called, which unconditionally calls exit(), a noreturn function.
      However, clang does not know that ksft_exit_fail_msg() will call exit() at
      the point in the pipeline that the warning is emitted because inlining has
      not occurred, so it assumes control flow will resume normally after
      ksft_exit_fail_msg() is called.
      
      Make it clear to clang that all of the functions that call exit()
      unconditionally in kselftest.h are noreturn transitively by marking them
      explicitly with '__attribute__((__noreturn__))', which clears up the
      warning above and any future warnings that may appear for the same reason.
      
      Fixes: 6d029c25 ("selftests/timers/posix_timers: Reimplement check_timer_distribution()")
      Reported-by: default avatarJohn Stultz <jstultz@google.com>
      Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Acked-by: default avatarShuah Khan <skhan@linuxfoundation.org>
      Cc: stable@vger.kernel.org
      Link: https://lore.kernel.org/r/20240411-mark-kselftest-exit-funcs-noreturn-v1-1-b027c948f586@kernel.org
      Closes: https://lore.kernel.org/all/20240410232637.4135564-2-jstultz@google.com/
      f7d5bcd3
    • John Stultz's avatar
      selftests: timers: Fix posix_timers ksft_print_msg() warning · e4a6bcea
      John Stultz authored
      After commit 6d029c25 ("selftests/timers/posix_timers: Reimplement
      check_timer_distribution()") the following warning occurs when building
      with an older gcc:
      
      posix_timers.c:250:2: warning: format not a string literal and no format arguments [-Wformat-security]
        250 |  ksft_print_msg(errmsg);
            |  ^~~~~~~~~~~~~~
      
      Fix this up by changing it to ksft_print_msg("%s", errmsg)
      
      Fixes: 6d029c25 ("selftests/timers/posix_timers: Reimplement check_timer_distribution()")
      Signed-off-by: default avatarJohn Stultz <jstultz@google.com>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Acked-by: default avatarJustin Stitt <justinstitt@google.com>
      Acked-by: default avatarShuah Khan <skhan@linuxfoundation.org>
      Cc: stable@vger.kernel.org
      Link: https://lore.kernel.org/r/20240410232637.4135564-1-jstultz@google.com
      e4a6bcea
    • Vasant Hegde's avatar
      iommu/amd: Change log message severity · b8246a2a
      Vasant Hegde authored
      Use consistent log severity (pr_warn) to log all messages in SNP
      enable path.
      Suggested-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
      Signed-off-by: default avatarVasant Hegde <vasant.hegde@amd.com>
      Link: https://lore.kernel.org/r/20240410101643.32309-1-vasant.hegde@amd.comSigned-off-by: default avatarJoerg Roedel <jroedel@suse.de>
      b8246a2a
    • Lu Baolu's avatar
      iommu/vt-d: Fix WARN_ON in iommu probe path · 89436f4f
      Lu Baolu authored
      Commit 1a75cc71 ("iommu/vt-d: Use rbtree to track iommu probed
      devices") adds all devices probed by the iommu driver in a rbtree
      indexed by the source ID of each device. It assumes that each device
      has a unique source ID. This assumption is incorrect and the VT-d
      spec doesn't state this requirement either.
      
      The reason for using a rbtree to track devices is to look up the device
      with PCI bus and devfunc in the paths of handling ATS invalidation time
      out error and the PRI I/O page faults. Both are PCI ATS feature related.
      
      Only track the devices that have PCI ATS capabilities in the rbtree to
      avoid unnecessary WARN_ON in the iommu probe path. Otherwise, on some
      platforms below kernel splat will be displayed and the iommu probe results
      in failure.
      
       WARNING: CPU: 3 PID: 166 at drivers/iommu/intel/iommu.c:158 intel_iommu_probe_device+0x319/0xd90
       Call Trace:
        <TASK>
        ? __warn+0x7e/0x180
        ? intel_iommu_probe_device+0x319/0xd90
        ? report_bug+0x1f8/0x200
        ? handle_bug+0x3c/0x70
        ? exc_invalid_op+0x18/0x70
        ? asm_exc_invalid_op+0x1a/0x20
        ? intel_iommu_probe_device+0x319/0xd90
        ? debug_mutex_init+0x37/0x50
        __iommu_probe_device+0xf2/0x4f0
        iommu_probe_device+0x22/0x70
        iommu_bus_notifier+0x1e/0x40
        notifier_call_chain+0x46/0x150
        blocking_notifier_call_chain+0x42/0x60
        bus_notify+0x2f/0x50
        device_add+0x5ed/0x7e0
        platform_device_add+0xf5/0x240
        mfd_add_devices+0x3f9/0x500
        ? preempt_count_add+0x4c/0xa0
        ? up_write+0xa2/0x1b0
        ? __debugfs_create_file+0xe3/0x150
        intel_lpss_probe+0x49f/0x5b0
        ? pci_conf1_write+0xa3/0xf0
        intel_lpss_pci_probe+0xcf/0x110 [intel_lpss_pci]
        pci_device_probe+0x95/0x120
        really_probe+0xd9/0x370
        ? __pfx___driver_attach+0x10/0x10
        __driver_probe_device+0x73/0x150
        driver_probe_device+0x19/0xa0
        __driver_attach+0xb6/0x180
        ? __pfx___driver_attach+0x10/0x10
        bus_for_each_dev+0x77/0xd0
        bus_add_driver+0x114/0x210
        driver_register+0x5b/0x110
        ? __pfx_intel_lpss_pci_driver_init+0x10/0x10 [intel_lpss_pci]
        do_one_initcall+0x57/0x2b0
        ? kmalloc_trace+0x21e/0x280
        ? do_init_module+0x1e/0x210
        do_init_module+0x5f/0x210
        load_module+0x1d37/0x1fc0
        ? init_module_from_file+0x86/0xd0
        init_module_from_file+0x86/0xd0
        idempotent_init_module+0x17c/0x230
        __x64_sys_finit_module+0x56/0xb0
        do_syscall_64+0x6e/0x140
        entry_SYSCALL_64_after_hwframe+0x71/0x79
      
      Fixes: 1a75cc71 ("iommu/vt-d: Use rbtree to track iommu probed devices")
      Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10689Signed-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
      Link: https://lore.kernel.org/r/20240407011429.136282-1-baolu.lu@linux.intel.comReviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
      Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
      89436f4f
    • Jacob Pan's avatar
      iommu/vt-d: Allocate local memory for page request queue · a34f3e20
      Jacob Pan authored
      The page request queue is per IOMMU, its allocation should be made
      NUMA-aware for performance reasons.
      
      Fixes: a222a7f0 ("iommu/vt-d: Implement page request handling")
      Signed-off-by: default avatarJacob Pan <jacob.jun.pan@linux.intel.com>
      Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
      Link: https://lore.kernel.org/r/20240403214007.985600-1-jacob.jun.pan@linux.intel.comSigned-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
      Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
      a34f3e20
    • Xuchun Shang's avatar
      iommu/vt-d: Fix wrong use of pasid config · 5b3625a4
      Xuchun Shang authored
      The commit "iommu/vt-d: Add IOMMU perfmon support" introduce IOMMU
      PMU feature, but use the wrong config when set pasid filter.
      
      Fixes: 7232ab8b ("iommu/vt-d: Add IOMMU perfmon support")
      Signed-off-by: default avatarXuchun Shang <xuchun.shang@linux.alibaba.com>
      Reviewed-by: default avatarKan Liang <kan.liang@linux.intel.com>
      Link: https://lore.kernel.org/r/20240401060753.3321318-1-xuchun.shang@linux.alibaba.comSigned-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
      Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
      5b3625a4
    • Thomas Gleixner's avatar
      x86/cpu/amd: Move TOPOEXT enablement into the topology parser · 7211274f
      Thomas Gleixner authored
      The topology rework missed that early_init_amd() tries to re-enable the
      Topology Extensions when the BIOS disabled them.
      
      The new parser is invoked before early_init_amd() so the re-enable attempt
      happens too late.
      
      Move it into the AMD specific topology parser code where it belongs.
      
      Fixes: f7fb3b2d ("x86/cpu: Provide an AMD/HYGON specific topology parser")
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      Link: https://lore.kernel.org/r/878r1j260l.ffs@tglx
      7211274f
    • Thomas Gleixner's avatar
      x86/cpu/amd: Make the NODEID_MSR union actually work · c064b536
      Thomas Gleixner authored
      A system with NODEID_MSR was reported to crash during early boot without
      any output.
      
      The reason is that the union which is used for accessing the bitfields in
      the MSR is written wrongly and the resulting executable code accesses the
      wrong part of the MSR data.
      
      As a consequence a later division by that value results in 0 and that
      result is used for another division as divisor, which obviously does not
      work well.
      
      The magic world of C, unions and bitfields:
      
          union {
          	  u64   bita : 3,
      	        bitb : 3;
      	  u64   all;
          } x;
      
          x.all = foo();
      
          a = x.bita;
          b = x.bitb;
      
      results in the effective executable code of:
      
         a = b = x.bita;
      
      because bita and bitb are treated as union members and therefore both end
      up at bit offset 0.
      
      Wrapping the bitfield into an anonymous struct:
      
          union {
          	  struct {
          	     u64  bita : 3,
      	          bitb : 3;
                };
      	  u64	  all;
          } x;
      
      works like expected.
      
      Rework the NODEID_MSR union in exactly that way to cure the problem.
      
      Fixes: f7fb3b2d ("x86/cpu: Provide an AMD/HYGON specific topology parser")
      Reported-by: default avatar"kernelci.org bot" <bot@kernelci.org>
      Reported-by: default avatarLaura Nao <laura.nao@collabora.com>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Tested-by: default avatarLaura Nao <laura.nao@collabora.com>
      Link: https://lore.kernel.org/r/20240410194311.596282919@linutronix.de
      Closes: https://lore.kernel.org/all/20240322175210.124416-1-laura.nao@collabora.com/
      c064b536
    • Thomas Gleixner's avatar
      x86/cpu/amd: Make the CPUID 0x80000008 parser correct · 1b3108f6
      Thomas Gleixner authored
      CPUID 0x80000008 ECX.cpu_nthreads describes the number of threads in the
      package. The parser uses this value to initialize the SMT domain level.
      
      That's wrong because cpu_nthreads does not describe the number of threads
      per physical core. So this needs to set the CORE domain level and let the
      later parsers set the SMT shift if available.
      
      Preset the SMT domain level with the assumption of one thread per core,
      which is correct ifrt here are no other CPUID leafs to parse, and propagate
      cpu_nthreads and the core level APIC bitwidth into the CORE domain.
      
      Fixes: f7fb3b2d ("x86/cpu: Provide an AMD/HYGON specific topology parser")
      Reported-by: default avatar"kernelci.org bot" <bot@kernelci.org>
      Reported-by: default avatarLaura Nao <laura.nao@collabora.com>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Tested-by: default avatarLaura Nao <laura.nao@collabora.com>
      Link: https://lore.kernel.org/r/20240410194311.535206450@linutronix.de
      1b3108f6
    • Josh Poimboeuf's avatar
      x86/bugs: Replace CONFIG_SPECTRE_BHI_{ON,OFF} with CONFIG_MITIGATION_SPECTRE_BHI · 4f511739
      Josh Poimboeuf authored
      For consistency with the other CONFIG_MITIGATION_* options, replace the
      CONFIG_SPECTRE_BHI_{ON,OFF} options with a single
      CONFIG_MITIGATION_SPECTRE_BHI option.
      
      [ mingo: Fix ]
      Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@kernel.org>
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      Cc: Sean Christopherson <seanjc@google.com>
      Cc: Linus Torvalds <torvalds@linux-foundation.org>
      Cc: Nikolay Borisov <nik.borisov@suse.com>
      Link: https://lore.kernel.org/r/3833812ea63e7fdbe36bf8b932e63f70d18e2a2a.1712813475.git.jpoimboe@kernel.org
      4f511739