.

wcfs/pptreesubset.go

@@ -126,19 +126,7 @@ func (S PPTreeSubSet) Path(oid zodb.Oid) (path []zodb.Oid) {
 	return path
 }
 
-// XXX doc
-func (S PPTreeSubSet) AddNodePath(path []Node) { // XXX Tree|Bucket; path[0] = root
-	// XXX assert Tree Tree ... Tree Bucket
-//	root := path[0].(*Tree).POid()
-
-	oidv := []zodb.Oid{}
-	for _, node := range path {
-		oidv = append(oidv, node.POid())
-	}
-	S.AddPath(oidv)
-}
-
-// XXX doc
+// AddPath adds path to a node to the set.
 func (S PPTreeSubSet) AddPath(path []zodb.Oid) {
 	S.verify()
 	defer S.verify()
@@ -176,7 +164,7 @@ func (S PPTreeSubSet) AddPath(path []zodb.Oid) {
 			// XXX .trackNew += oid
 		}
 		if track.parent != parent {
-			// XXX -> error (e.g. due to corrupt data in ZODB)
+			// XXX -> error (e.g. due to corrupt data in ZODB) ?
 			panicf("node %s is reachable from multiple parents: %s %s",
 				oid, track.parent, parent)
 		}
@@ -190,6 +178,19 @@ func (S PPTreeSubSet) AddPath(path []zodb.Oid) {
 	}
 }
 
+// AddNodePath is a convenience wrapper to call AddPath starting from Nodes instead of Oids.
+func (S PPTreeSubSet) AddNodePath(path []Node) { // XXX Tree|Bucket; path[0] = root
+	// XXX assert Tree Tree ... Tree Bucket
+//	root := path[0].(*Tree).POid()
+
+	oidv := []zodb.Oid{}
+	for _, node := range path {
+		oidv = append(oidv, node.POid())
+	}
+	S.AddPath(oidv)
+}
+
+
 
 
 // ---- Union/Difference ----