Commit 1303799e authored by Kirill Smelkov's avatar Kirill Smelkov Committed by Levin Zimmermann

wcfs: tests: Fix thinko in "sleep > wcfs pin timeout - wcfs must kill us"

If wcfs kills client that did not respond to pin notification in
pintimeout time, we need to wait strictly _more_ than that time to detect
whether client was killed or not. And in practice, due to noise in
operating system load and other factors, that waiting time should be
significantly greater to detect lack of expected event. However we were
waiting for exactly 1·pintimeout time and were claiming that there was
no pinkill event right after that.

-> Wait for 2·pintimeout instead of 1·pintimeout to make pinkill detection robust.

/reviewed-by @levin.zimmermann
/reviewed-on nexedi/wendelin.core!18
parent e8a3f34a
...@@ -68,8 +68,8 @@ def test_wcfs_pintimeout_kill(with_prompt_pintimeout): ...@@ -68,8 +68,8 @@ def test_wcfs_pintimeout_kill(with_prompt_pintimeout):
# sleep > wcfs pin timeout - wcfs must kill us # sleep > wcfs pin timeout - wcfs must kill us
_, _rx = select( _, _rx = select(
ctx.done().recv, # 0 ctx.done().recv, # 0
time.after(t.pintimeout).recv, # 1 time.after(2*t.pintimeout).recv, # 1
) )
if _ == 0: if _ == 0:
raise ctx.err() raise ctx.err()
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment