Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
cloudooo
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
6
Merge Requests
6
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Jobs
Commits
Open sidebar
nexedi
cloudooo
Commits
0cfb5a16
Commit
0cfb5a16
authored
May 16, 2019
by
Boris Kocherov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
stop hanging uno thread
parent
722dad78
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
16 additions
and
5 deletions
+16
-5
cloudooo/handler/ooo/handler.py
cloudooo/handler/ooo/handler.py
+4
-1
cloudooo/handler/ooo/helper/unoconverter.py
cloudooo/handler/ooo/helper/unoconverter.py
+9
-1
cloudooo/handler/ooo/tests/testOooUnoConverter.py
cloudooo/handler/ooo/tests/testOooUnoConverter.py
+3
-3
No files found.
cloudooo/handler/ooo/handler.py
View file @
0cfb5a16
...
...
@@ -126,11 +126,14 @@ class Handler(object):
if
pid_exists
(
process
.
pid
):
logger
.
debug
(
"Process %s terminated"
,
process
.
pid
)
process
.
terminate
()
if
(
process
.
returncode
<
0
and
process
.
returncode
!=
-
6
)
or
stderr
:
if
(
process
.
returncode
!=
-
6
)
or
stderr
:
logger
.
error
(
"Process %s command:%s"
,
process
.
pid
,
" "
.
join
(
command_list
))
logger
.
error
(
"Process %s stdout:%s"
,
process
.
pid
,
stdout
)
logger
.
error
(
"Process %s stderr:%s"
,
process
.
pid
,
stderr
)
logger
.
debug
(
"Process %s terminated with returncode %s"
,
process
.
pid
,
process
.
returncode
)
if
process
.
returncode
!=
-
6
:
raise
ValueError
(
"unocnverter.py should always be interrupted by abort,"
" otherwise deadlock can be raised"
)
return
stdout
,
stderr
def
_callUnoConverter
(
self
,
*
feature_list
,
**
kw
):
...
...
cloudooo/handler/ooo/helper/unoconverter.py
View file @
0cfb5a16
...
...
@@ -367,4 +367,12 @@ def main():
sys
.
stdout
.
write
(
output
)
if
"__main__"
==
__name__
:
main
()
# use abort for avoid deadlock
try
:
main
()
except
:
import
traceback
sys
.
stderr
.
write
(
traceback
.
format_exc
())
sys
.
stdout
.
flush
()
sys
.
stderr
.
flush
()
os
.
abort
()
cloudooo/handler/ooo/tests/testOooUnoConverter.py
View file @
0cfb5a16
...
...
@@ -75,9 +75,9 @@ class TestUnoConverter(HandlerTestCase):
"--destination_format=%s"
%
"doc"
,
"--source_format=%s"
%
"odt"
,
"--mimemapper=%s"
%
mimemapper_pickled
]
stdout
,
stderr
=
Popen
(
command
,
stdout
=
PIPE
,
stderr
=
PIPE
).
communicate
(
)
process
=
Popen
(
command
,
stdout
=
PIPE
,
stderr
=
PIPE
)
stdout
,
stderr
=
process
.
communicate
()
self
.
assertEquals
(
process
.
returncode
,
-
6
)
self
.
assertEquals
(
stderr
,
''
)
output_url
=
stdout
.
replace
(
'
\
n
'
,
''
)
self
.
assertTrue
(
exists
(
output_url
),
stdout
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment