Commit 2a3df9dd authored by Jérome Perrin's avatar Jérome Perrin

testXHTML: use suprocess instead of obsolete popen and close file descriptors explicitly

parent b90ff38c
......@@ -29,7 +29,6 @@
import unittest
import os
import popen2
import urllib
from subprocess import Popen, PIPE
......@@ -450,15 +449,14 @@ class W3Validator(object):
# Zope 2.12 renders page templates as unicode
page_source = page_source.encode('utf-8')
source = 'fragment=%s&output=soap12' % urllib.quote_plus(page_source)
os.environ['CONTENT_LENGTH'] = str(len(source))
os.environ['REQUEST_METHOD'] = 'POST'
stdout, stdin, stderr = popen2.popen3(self.validator_path)
while stdout.readline() != '\n':
result =
return self._parse_validation_results(result)
stdout, stderr = Popen(self.validator_path,
stdin=PIPE, stdout=PIPE, stderr=PIPE,
env={"CONTENT_LENGTH": str(len(source)),
"REQUEST_METHOD": "POST"}).communicate(source)
# Output is a set of headers then the XML content.
return self._parse_validation_results(
stdout.split('<?xml version="1.0" encoding="UTF-8"?>')[1])
class TidyValidator(object):
......@@ -498,9 +496,9 @@ class TidyValidator(object):
retrun two list : a list of errors and an other for warnings
stdout, stdin, stderr = popen2.popen3('%s -e -q -utf8' % self.validator_path)
stdout, stderr = Popen('%s -e -q -utf8' % self.validator_path,
stdin=PIPE, stdout=PIPE, stderr=PIPE,
return self._parse_validation_results(stderr)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment