Skip to content

erp5
erp5
Commit 5ef71164 authored by Boxiang Sun's avatar Boxiang Sun Committed by Tristan Cavelier
8 Browse files
Options

erp5_officejs: Add app cache for ECharts wrapper gadget.

parent d7075dbb
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 353 additions and 3 deletions
bt5/erp5_officejs/PathTemplateItem/web_page_module/gadget_field_graph_echarts_html.html
View file @ 5ef71164
<!DOCTYPE html>
<!--html style="height: 100%"-->
<html style="height: 300px">
<html manifest="gadget_field_graph_echarts.appcache" style="height: 300px">
  • Georgios Dagkakis @georgios.dagkakis ·
    Developer

    Now that we have turned to service worker should we remove this? I am not sure what's the state of projects though, do we expect some to still have appcache?

    cc @romain

  • Romain Courteaud @romain ·
    Owner

    @rporchetto is currently working to drop appcache from officejs

  • Roque @rporchetto ·
    Developer

    As far as I know, support request is the only officejs app that uses gadget_field_graph_echarts. I'll drop that appcache file and check how the tests go.

  • Georgios Dagkakis @georgios.dagkakis ·
    Developer

    Thanks @rporchetto . I think that everything that is in gadget_field_graph_echarts.appcache is already in WebSection_getOfficeJSSupportRequestPrecacheManifestList but please double check when you do

  • Roque @rporchetto ·
    Developer

    Done. It seems to have no impact on support request app and tests. The change is included in this MR !1091 (merged), it will be merged soon.

    Not related to this but FYI, two tests on support request are failing in master: test_result

    Edited by Roque
  • Georgios Dagkakis @georgios.dagkakis ·
    Developer

    Done. It seems to have no impact on support request app and tests. The change is included in this MR !1091 (merged), it will be merged soon.

    thanks!

    Not related to this but FYI, two tests on support request are failing in master: test_result

    mmm from history it seems to be new and only change is on slapos.cookbook. So not sure if this slapos@cdd6690d can have affected, or it may be random?

  • Jérome Perrin @jerome ·
    Owner

    I don't remember seeing this failing like that before, maybe it's something wrong on testnodes.

  • Roque @rporchetto ·
    Developer

    I reverted this change from my MR because it caused some tests to fail (Failed TR).

    I couldn't find out what's wrong, so I will work on this change later and outside my current MR because I need to merge it (2 trainees will work on top of my changes).

    After revert, tests are working.

Please register or sign in to reply
<head>
<meta http-equiv="Content-type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, user-scalable=no" />
......
bt5/erp5_officejs/PathTemplateItem/web_page_module/gadget_field_graph_echarts_html.xml
View file @ 5ef71164
......@@ -242,7 +242,7 @@
</item>
<item>
<key> <string>serial</string> </key>
<value> <string>961.52323.54891.54084</string> </value>
<value> <string>962.25420.32482.53094</string> </value>
</item>
<item>
<key> <string>state</string> </key>
......@@ -260,7 +260,7 @@
</tuple>
<state>
<tuple>
<float>1504268568.29</float>
<float>1506590298.97</float>
<string>UTC</string>
</tuple>
</state>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7