ZSQLCatalog.SQLCatalog: Raise on unknown column by default.

Update callers which could not be fixed so they disable the exception.
Reviewed-by: Jerôme Perrin <jerome@nexedi.com>

bt5/erp5_web_ung_theme/SkinTemplateItem/portal_skins/erp5_web_ung_theme/ERP5Site_checkIfUserExist.xml

@@ -60,6 +60,7 @@ if not kw:\n
 portal = context.getPortalObject()\n
 person = portal.portal_catalog.getResultValue(portal_type="Person",\n
                                               validation_state="validated",\n
+                                              ignore_unknown_columns=True,\n
                                               **kw)\n
 \n
 return json.dumps(dict(response=(person is not None)))\n

product/ERP5/bootstrap/erp5_core/ExtensionTemplateItem/portal_components/extension.erp5.InventoryBrain.py

@@ -52,11 +52,12 @@ class InventoryListBrain(ComputedAttributeGetItemCompatibleMixin):
     Lists each variation
   """
   # Stock management
-  def _callSimulationTool(self, method_id, **kw):
+  def _callSimulationTool(self, method_id, ignore_unknown_columns=True, **kw):
     return getattr(
       self.getPortalObject().portal_simulation,
       method_id,
     )(
+      ignore_unknown_columns=ignore_unknown_columns,
       node_uid=self.node_uid,
       variation_text=self.variation_text,
       resource_uid=self.resource_uid,

product/ERP5/bootstrap/erp5_mysql_innodb_catalog/CatalogMethodTemplateItem/portal_catalog/erp5_mysql_innodb/SQLCatalog_makeSearchTextQuery.xml

@@ -73,7 +73,7 @@ node = context.Base_getAdvancedSearchSyntaxTreeNode(value, column=column)\n
 if node is None:\n
   return context.buildSingleQuery(column, value)\n
 else:\n
-  return context.buildQueryFromAbstractSyntaxTreeNode(node, column)\n
+  return context.buildQueryFromAbstractSyntaxTreeNode(node, column, ignore_unknown_columns=True)\n
 </string> </value>
         </item>
         <item>

product/ERP5/tests/testInventoryAPI.py

@@ -1693,10 +1693,6 @@ class TestMovementHistoryList(InventoryAPITestCase):
     self.assertRaises(ValueError,
                       getMovementHistoryList,
                       section_category='group/notexists')
-    # (but other arguments are ignored)
-    self.assertEqual(len(getMovementHistoryList(
-                        section_category='group/level1',
-                        ignored='argument')), 1)
 
   @expectedFailure
   def testDoubleSectionCategory(self):

product/ERP5Form/Selection.py

@@ -210,6 +210,7 @@ class Selection(Acquisition.Implicit, Traversable, Persistent):
           kw = self.params.copy()
         else:
           kw = params.copy()
+        kw.setdefault("ignore_unknown_columns", True)
         # Always remove '-C'-named parameter.
         kw.pop('-C', None)
         if self.invert_mode is not 0:

product/ZSQLCatalog/SQLCatalog.py

@@ -2178,7 +2178,7 @@ class Catalog(Folder,
         result = None
     return result
 
-  def buildQueryFromAbstractSyntaxTreeNode(self, node, key, wrap=lambda x: x, ignore_unknown_columns=True):
+  def buildQueryFromAbstractSyntaxTreeNode(self, node, key, wrap=lambda x: x, ignore_unknown_columns=False):
     """
       Build a query from given Abstract Syntax Tree (AST) node by recursing in
       its childs.
@@ -2231,7 +2231,7 @@ class Catalog(Folder,
     return self._parseSearchText(self.getSearchKey(
       column, search_key=search_key), search_text, is_valid=is_valid)
 
-  def buildQuery(self, kw, ignore_empty_string=True, operator='and', ignore_unknown_columns=True):
+  def buildQuery(self, kw, ignore_empty_string=True, operator='and', ignore_unknown_columns=False):
     query_list = []
     append = query_list.append
     # unknown_column_dict: contains all (key, value) pairs which could not be
@@ -2375,7 +2375,7 @@ class Catalog(Folder,
 
   def buildEntireQuery(self, kw, query_table='catalog', ignore_empty_string=1,
                        limit=None, extra_column_list=(),
-                       ignore_unknown_columns=True):
+                       ignore_unknown_columns=False):
     kw = self.getCannonicalArgumentDict(kw)
     group_by_list = kw.pop('group_by_list', [])
     select_dict = kw.pop('select_dict', {})
@@ -2417,7 +2417,7 @@ class Catalog(Folder,
   def buildSQLQuery(self, query_table='catalog', REQUEST=None,
                           ignore_empty_string=1, only_group_columns=False,
                           limit=None, extra_column_list=(),
-                          ignore_unknown_columns=True,
+                          ignore_unknown_columns=False,
                           **kw):
     return self.buildEntireQuery(
       kw,