1. 25 Sep, 2018 1 commit
  2. 04 Apr, 2018 1 commit
    • Merge !504 Do not save documents when there are pending activities · 16de28d5
      When document has pending activities, we refuse changing ID ( because there might be pending `updateRelatedContent` activities if I remember correctly ), but it's done in a way that breaks the "atomic" aspect of the transaction a bit, because we
      
      As a result, this happens sometimes that not all properties user changed are modified. In the example below, the change to *Include Documents in Site Map* is not saved (and also change to *ID*):
      
      ![erp5-sorryPendingActivitiesSavePartially](/uploads/ff4bfd6ad0e8a42ba3684cccdc450e21/erp5-sorryPendingActivitiesSavePartially.gif)
      
      ( screencast of editing a document to change ids and several other
      properties - after clicking save, we can see that changing id is refused
      because there is pending activities. Other properties that where changes
      at the same times are not all modified, which breaks the
      transactionality we can usally expect when editing documents in ERP5 )
      
      The changed here is to use a field validator that refused editing when there are pending activities, so that user gets a:
      
      ![erp5-pending-activiities](/uploads/bfe825560bdee34f0443e8e36884f21c/erp5-pending-activiities.png)
      
      ( screenshot of the change: now edition is rejected )
      
      and the result is either all changes are applied or no change is applied at all.
      
      This is done by:
       * introducing a new `my_view_mode_id` field in `erp5_core`'s `Base_viewFieldLibrary`
       * using this field as proxy field of all editable `my_id` fields. Maybe I forgot some business templates, I changed only the most common ones. I intentionally did not change all fields of `erp5_ui_test` because I think they are used to compare speed of proxy fields vs traditional fields.
      
      0352f50fd543fda2712bb8ca93d8a8814f975a26 introduces a Zelenium test exercising this new behavior.
      
      /reviewed-on !504
      
      Conflicts:
      	product/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/Base_viewFieldLibrary.xml
      Jérome Perrin committed
  3. 27 Mar, 2018 1 commit
    • all: Avoid most direct calls to {recursiveI,i}mmediateReindexObject · 35e31f67
      These methods must not be called synchronously:
      - they can break catalog by not being careful enough about other
        reindexations which may happen in parallel. See the serialization_tag
        mechanism for more.
      - indexation gets executed in the security context of the user causing the
        call, which may lead to an indexation result different from what happens
        when indexation happens with an all-accesses user.
      
      Also, simplify a few scripts while doing so.
      Vincent Pelletier committed
  4. 26 Mar, 2018 1 commit
  5. 27 Nov, 2017 1 commit
  6. 31 Oct, 2017 1 commit
  7. 12 Apr, 2017 1 commit
  8. 02 Feb, 2017 4 commits
  9. 23 Dec, 2016 2 commits
  10. 18 Oct, 2016 1 commit
  11. 06 Sep, 2016 1 commit
  12. 05 Sep, 2016 1 commit
  13. 19 Jul, 2016 1 commit
  14. 30 Jun, 2016 1 commit
  15. 07 Jun, 2016 1 commit
  16. 17 Mar, 2016 1 commit
  17. 07 Mar, 2016 1 commit
  18. 04 Feb, 2016 1 commit
  19. 28 Jan, 2016 1 commit
  20. 05 Jan, 2016 1 commit
  21. 04 Jan, 2016 1 commit
  22. 01 Dec, 2015 1 commit
  23. 03 Nov, 2015 1 commit
  24. 28 Sep, 2015 1 commit
  25. 17 Sep, 2015 1 commit
  26. 23 Jul, 2015 1 commit
  27. 08 Jul, 2015 2 commits
  28. 12 May, 2015 1 commit
  29. 05 May, 2015 1 commit
  30. 09 Mar, 2015 1 commit
  31. 16 Dec, 2014 1 commit
  32. 12 Dec, 2014 1 commit
  33. 17 Nov, 2014 1 commit
  34. 11 Sep, 2014 2 commits