erp5:dab1dd86ff67c642115838c6755a35b693ffcee2 commitshttps://lab.nexedi.com/nexedi/erp5/-/commits/dab1dd86ff67c642115838c6755a35b693ffcee22020-02-14T03:41:09+01:00https://lab.nexedi.com/nexedi/erp5/-/commit/dab1dd86ff67c642115838c6755a35b693ffcee2tests: don't run coding style tests in unit tests2020-02-14T03:41:09+01:00Jérome Perrinjerome@nexedi.com
We run them in coding style test suite already.
Also these test now need business template repository properly
configured in template tool, which is not set in default setup, so
keeping them working would require extra work.https://lab.nexedi.com/nexedi/erp5/-/commit/f4a1afddb688cd893fb0b46b8b688d5bec11f29dCodingStyleTestCase: check rebuilding tested BT to catch packaging problems2020-02-14T03:41:07+01:00Jérome Perrinjerome@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/d6d7868975dcea9a89fec85ccb89462dba41d0d2Revert "erp5_dms_ui_test: Add selenium tests"2020-02-14T03:41:06+01:00Jérome Perrinjerome@nexedi.com
This reverts commit <a href="/nexedi/erp5/-/commit/f93918473edffb98ec3db36447d81d4f7f27884c" data-original="f93918473edffb98ec3db36447d81d4f7f27884c" data-link="false" data-link-reference="false" data-project="1" data-commit="f93918473edffb98ec3db36447d81d4f7f27884c" data-reference-type="commit" data-container="body" data-placement="top" data-html="true" title="erp5_dms_ui_test: Add selenium tests" class="gfm gfm-commit has-tooltip">f9391847</a>.
These two paths were only half-committed, for the PDF we don't have the
file content, for the test we don't have the .xml, so in practice this
test never ran.
I tried to run it but it does not pass, uses pause command and some
xpath selector that are now unclear.
PDFJS is also tested in portal_tests/erp5_km_zuite/testCheckPDFPreviewhttps://lab.nexedi.com/nexedi/erp5/-/commit/2fa2ed5d293b64b501053ea7b0ce22f08cb6d44fsvg_editor: business template format change2020-02-14T03:41:05+01:00Jérome Perrinjerome@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/a40e1ff1285e983b720bb1db0e7c9fcbfedb36fbjquery_plugin_svg_editor: business template format change2020-02-14T03:41:04+01:00Jérome Perrinjerome@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/2201c165e690bd02f6d329005209753d08a16338demo_maxma_rule: list business template rule paths explicitly2020-02-14T03:40:45+01:00Jérome Perrinjerome@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/9417956033b2a405221ad37a0a31249905ecb2f5configurator_standard_categories: list business template categories paths exp...2020-02-14T03:40:33+01:00Jérome Perrinjerome@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/5f91bbf81c1497b559d01e757de7b9df2e355671payroll_ui_test: list business template categories paths explicitly2020-02-14T01:18:06+01:00Jérome Perrinjerome@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/10b4996ae53ede1aca4977080dbbbd697500a97btiosafe_test: list business template categories paths explicitly2020-02-14T01:17:54+01:00Jérome Perrinjerome@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/d220132e9d97955ebafab1dc4a8c4ed88b006c6berp5_base: Fix typo: OpenOrder is actually in erp5_open_trade (937500a).2020-02-12T12:27:19+09:00Arnaud Fontainearnaud.fontaine@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/281653f33efabf163a131d97596b69cd82511ee2erp5_web_project_ui: get project home page by publication section preference2020-02-10T13:43:58+01:00Roque Porchettoroque.porchetto@nexedi.com- use global preference to get publication section value
- test updatedhttps://lab.nexedi.com/nexedi/erp5/-/commit/8e24ff0ad59c90e8df896ad3f6cb461fa44f4c55erp5_web_project_ui_test: new category for project home page publication section2020-02-10T13:43:58+01:00Roque Porchettoroque.porchetto@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/b2efae5f02595d2a9d00614446f02b9cf906944cerp5_project: add publication section property to system preference project tab2020-02-10T13:43:58+01:00Roque Porchettoroque.porchetto@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/70b2ab022cb19222bd2cd1b10d0cd8090d36d078[officejs] Fix linshare storage bug2020-02-10T13:32:46+01:00Roque Porchettoroque.porchetto@nexedi.com
/reviewed-on <a href="https://lab.nexedi.com/nexedi/erp5/merge_requests/1017" data-original="https://lab.nexedi.com/nexedi/erp5/merge_requests/1017" data-link="false" data-link-reference="true" data-project="1" data-merge-request="3528" data-project-path="nexedi/erp5" data-iid="1017" data-mr-title="[officejs] Fix linshare storage bug" data-reference-type="merge_request" data-container="body" data-placement="top" data-html="true" title="" class="gfm gfm-merge_request">!1017</a>https://lab.nexedi.com/nexedi/erp5/-/commit/f1f415a38a01547cad4443620e9b1a2eace9ba52ZODB Components: Resetting Portal Type classes was also clearing Interfaces o...2020-02-10T12:30:49+09:00Arnaud Fontainearnaud.fontaine@nexedi.comZODB Components: Resetting Portal Type classes was also clearing Interfaces of erp5.component.* modules.
__implemented__ and __provides__ attributes are cleared on Portal Type reset
to break a circular reference (<a href="/nexedi/erp5/-/commit/11e2b506f303cb75db1591a7a8a18dd56b4b2c10" data-original="11e2b50" data-link="false" data-link-reference="false" data-project="1" data-commit="11e2b506f303cb75db1591a7a8a18dd56b4b2c10" data-reference-type="commit" data-container="body" data-placement="top" data-html="true" title="Portal Type as Classes: Fix memory leak: reset erp5.* classes were never GC (#20170126-19C38D8)." class="gfm gfm-commit has-tooltip">11e2b506</a>). Resetting of ZODB Components is
done independently of Portal Type classes, so until the next ZODB Component
reset, Interfaces were not implemented anymore.
<a href="/nexedi/erp5/-/commit/11e2b506f303cb75db1591a7a8a18dd56b4b2c10" data-original="11e2b50" data-link="false" data-link-reference="false" data-project="1" data-commit="11e2b506f303cb75db1591a7a8a18dd56b4b2c10" data-reference-type="commit" data-container="body" data-placement="top" data-html="true" title="Portal Type as Classes: Fix memory leak: reset erp5.* classes were never GC (#20170126-19C38D8)." class="gfm gfm-commit has-tooltip">11e2b506</a> states that this creates a memory leak but this is not actually true
as Python garbage collector will break such circular reference and collect
this object, as asserted by a newly introduced Unit Test. This is probably
less efficient than explicitly breaking the circular reference and thus relies
on reference counting (rather than the garbage collector) but doing otherwise
would require introspecting ZODB Components module to find classes implementing
Interfaces (erp5.portal_type only contains classes).
This only takes care of ZODB Components modules but maybe breaking circular
references for Portal Type classes is not even needed (if so, this will be done
in a later commit).
https://lab.nexedi.com/nexedi/erp5/-/commit/937500a1e51f55148e40fc3e4b0fb586287ce62cZODB Components: Migrate source files related to erp5_base.2020-02-10T12:30:48+09:00Arnaud Fontainearnaud.fontaine@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/2b8c630500f8a65566cf5ccf76b5215add840e54ZODB Components: When migrating FS Mixin, set the ZODB Component reference to...2020-02-10T12:30:48+09:00Arnaud Fontainearnaud.fontaine@nexedi.comZODB Components: When migrating FS Mixin, set the ZODB Component reference to the class name (like Interfaces).
https://lab.nexedi.com/nexedi/erp5/-/commit/ee686cac7e70b10860b8cd75ea60da31b2871830ZODB Components: Non-core bt5 with 'Document Component' overriding standard...2020-02-10T12:30:47+09:00Arnaud Fontainearnaud.fontaine@nexedi.comZODB Components: Non-core bt5 with 'Document Component' overriding standard ERP5 Document must create its own version_priority.
Otherwise this will clash when standard ERP5 Document will be migrated to ZODB
Components to erp5_base.
https://lab.nexedi.com/nexedi/erp5/-/commit/66f30ebba9b45b42591bf1dd10b01e869a1bf38dZODB Components: Preparation of erp5_base migration from FS: One Mixin per so...2020-02-10T12:30:47+09:00Arnaud Fontainearnaud.fontaine@nexedi.com
Like Document and Interface Components for the same reasons (<a href="/nexedi/erp5/-/commit/694c9feea0cb546f670246a850677e2a9cd3f757" data-original="694c9fe" data-link="false" data-link-reference="false" data-project="1" data-commit="694c9feea0cb546f670246a850677e2a9cd3f757" data-reference-type="commit" data-container="body" data-placement="top" data-html="true" title="ZODB Components: Before migrating Interfaces from FS, there must be one..." class="gfm gfm-commit has-tooltip">694c9fee</a>).https://lab.nexedi.com/nexedi/erp5/-/commit/dc02bfa887ffab9841abebc3f5c16d874388cef5ERP5JS: render before commit2020-02-07T05:39:18+01:00Jérome Perrinjerome@nexedi.com
Since <a href="/nexedi/erp5/-/commit/264ded5ce18882a1744b870f0c2b5cd7dfaf1aef" data-original="264ded5c" data-link="false" data-link-reference="false" data-project="1" data-commit="264ded5ce18882a1744b870f0c2b5cd7dfaf1aef" data-reference-type="commit" data-container="body" data-placement="top" data-html="true" title="[erp5_hal_json_style/erp5_web_renderjs_ui] Render the form directly after a..." class="gfm gfm-commit has-tooltip">264ded5c</a> in ERP5JS we render the form directly after a successful edit, but this was done sometimes too early, namely, the next form was rendered before interaction workflows and this leads to problems like the ones discussed in <a href="https://lab.nexedi.com/nexedi/erp5/merge_requests/982#note_92893" data-original="https://lab.nexedi.com/nexedi/erp5/merge_requests/982#note_92893" data-link="false" data-link-reference="true" data-project="1" data-merge-request="3401" data-project-path="nexedi/erp5" data-iid="982" data-mr-title="Use gadget editor on portal components in ERP5JS" data-reference-type="merge_request" data-container="body" data-placement="top" data-html="true" title="" class="gfm gfm-merge_request">!982 (comment 92893)</a>
/reviewed-on <a href="https://lab.nexedi.com/nexedi/erp5/merge_requests/1040" data-original="https://lab.nexedi.com/nexedi/erp5/merge_requests/1040" data-link="false" data-link-reference="true" data-project="1" data-merge-request="3612" data-project-path="nexedi/erp5" data-iid="1040" data-mr-title="ERP5JS: render before commit" data-reference-type="merge_request" data-container="body" data-placement="top" data-html="true" title="" class="gfm gfm-merge_request">!1040</a>https://lab.nexedi.com/nexedi/erp5/-/commit/ed44bee5fbbbe4698848dc2adcdd1ea29436ce90knowledge_pad_ui_test: fix a random failure2020-02-07T05:33:22+01:00Jérome Perrinjerome@nexedi.com
This test click on the delete button which deletes by an ajax request
and immediatly after open the "wait for activities" page. Sometimes the
second request starts before the first is committed, so there are no
activities to wait for.
When using ZServer, we had only one worker thread, so this was not
visible, but with wsgi we have more than one so it happened sometimes.
Use an old jQuery trick to wait that the first request is no longer in
flight.
/reviewed-on <a href="https://lab.nexedi.com/nexedi/erp5/merge_requests/1038" data-original="https://lab.nexedi.com/nexedi/erp5/merge_requests/1038" data-link="false" data-link-reference="true" data-project="1" data-merge-request="3606" data-project-path="nexedi/erp5" data-iid="1038" data-mr-title="knowledge_pad_ui_test: fix a random failure" data-reference-type="merge_request" data-container="body" data-placement="top" data-html="true" title="" class="gfm gfm-merge_request">!1038</a>https://lab.nexedi.com/nexedi/erp5/-/commit/88ebd8cde0733039854914099af60ccb7b1cde42ERP5Type.Base: Do not inherit from deprecated class.2020-02-06T18:03:27+09:00Vincent Pelletiervincent@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/f247d3a3dde183e4af1339d18a7fee083a73c381ERP5Type.patches.PropertyManager: Trivial simplification.2020-02-06T18:03:27+09:00Vincent Pelletiervincent@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/92e81dd4d2519eb35166cb095da754028bee19c9ERP5Type.patches.Publish: Patch higher in the call stack.2020-02-06T11:43:50+09:00Vincent Pelletiervincent@nexedi.com
Also covers traversal (and a lot more).https://lab.nexedi.com/nexedi/erp5/-/commit/c1deaaed9ee3db969e737e026786e2e7d8a570f3erp5_web_manifest: fetch the vanilla HTML2020-02-05T11:41:08+01:00Romain Courteaudromain@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/c4bd6cd2b04b995274db0ba6d577888363a59c26core: set SameSite=Lax on authentication cookie2020-02-05T11:36:18+01:00Romain Courteaudromain@nexedi.com
<a href="https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02" rel="nofollow noreferrer noopener" target="_blank">https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02</a>
SameSite=None breaks the compatibility with some browser versions.
<a href="https://www.chromium.org/updates/same-site/incompatible-clients" rel="nofollow noreferrer noopener" target="_blank">https://www.chromium.org/updates/same-site/incompatible-clients</a>
We choose Lax and not Strict so that we can open links to ERP5 from
external applications and so that OAuth Logins work. Implementing the
"two cookies, one for read one for write" approach suggested in
<a href="https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02#section-8.8.2" rel="nofollow noreferrer noopener" target="_blank">https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02#section-8.8.2</a>
would be too big change at this point.
Allow instances to surcharge the SameSite value for some specific domains if needed,
by surcharging the ERP5Site_getAuthCookieSameSite script.https://lab.nexedi.com/nexedi/erp5/-/commit/317c3bd106ccb251ed1a0f1e222fdaadb9609582testListBox: Make timeout test failures easier to debug.2020-02-05T17:57:41+09:00Vincent Pelletiervincent@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/a43e825d7671c6408e1ad26496d9969dc6d0388berp5_xhtml_style/erp5_web_renderjs_ui: Update renderJS 0.22.02020-02-04T11:31:50+01:00Romain Courteaudromain@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/97c40dcb277a5a722a26f080da42b25fca25ef1dhal_json_style: after save, render next form later2020-02-03T04:38:57+01:00Jérome Perrinjerome@nexedi.com
We want to render the next page after interaction workflows are
executed.https://lab.nexedi.com/nexedi/erp5/-/commit/fcde3e85c5bd24f0dd346c2e18ee6f5d406795b3ui_test: test how interaction workflows can change values when saving2020-02-03T04:38:55+01:00Jérome Perrinjerome@nexedi.com
This uses a foo_interaction_workflow that sets a short title when title
is set to a special value. We use it to check that when user set the
title to that special value and save, next time the form is displayed,
the values displayed are the ones after interaction workflow modified.
This is a simple and a bit unrealistic scenario, but we have for example
interaction workflows that update security definitions when some
properties are modified, we want the next form to display the values
after modifications.
This is also the case of editions of portal components which sets the
document to "modified" state and "re-validate" it at the end of
transaction, unless pylint detects error.https://lab.nexedi.com/nexedi/erp5/-/commit/766e29c0b058afd9e236b1fdb5b8f217209ab3f8fixup! [hal_json_style+renderjs_ui] Support Actions on multiple objects2020-02-03T04:38:53+01:00Jérome Perrinjerome@nexedi.com
action added in a previous commit was removed, probably by mistake
because only the metadata was removed.https://lab.nexedi.com/nexedi/erp5/-/commit/d05cce6fa1e4aaf99652f783dbcb102ed8f50ad7fixup! erp5_mysql_innodb_catalog: Replace translation join into a separate qu...2020-02-03T04:38:52+01:00Jérome Perrinjerome@nexedi.com
workflows were not sorted and some metadata files have an extra \n,
probably because of manual edithttps://lab.nexedi.com/nexedi/erp5/-/commit/94053d300042d1b5550800bf1023f0c6158a26cfEnable coding style test on erp5_hal_hjson_style, erp5_web_renderjs_ui_test a...2020-02-03T04:29:28+01:00Jérome Perrinjerome@nexedi.com
This uses a different approach that what I was using in the past. I'm no longer trying to rename skins that does not match our naming conventions, but just adding them the the "ignore list".
This would still allow to detect when new wrongly named scripts are introduced without risking regressions when we rename a script that was used from some places we did not change (like project customisations).
/reviewed-on <a href="https://lab.nexedi.com/nexedi/erp5/merge_requests/1041" data-original="https://lab.nexedi.com/nexedi/erp5/merge_requests/1041" data-link="false" data-link-reference="true" data-project="1" data-merge-request="3613" data-project-path="nexedi/erp5" data-iid="1041" data-mr-title="Enable coding style test on erp5_hal_hjson_style, erp5_web_renderjs_ui_test and erp5_ui_test" data-reference-type="merge_request" data-container="body" data-placement="top" data-html="true" title="" class="gfm gfm-merge_request">!1041</a>https://lab.nexedi.com/nexedi/erp5/-/commit/dfe9ccd4f00634754e015c1c060c185d00df1a71web_renderjs_ui_test: enable coding style test2020-01-31T11:53:53+01:00Jérome Perrinjerome@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/eaa25c4a259f1e76935cd1f1e3e5d162764f350eCodingStyle: allow 'MailHost' as prefix2020-01-31T11:53:52+01:00Jérome Perrinjerome@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/3ac810e9a35234f9d9b9bfd7b57120930e7c7dc6ui_test: enable coding style test2020-01-31T11:53:51+01:00Jérome Perrinjerome@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/8e893a64c38f6cbccfcfbe393779316a047ed95dui_test: fix pylint errors2020-01-31T11:53:50+01:00Jérome Perrinjerome@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/fd8696d226f568f24c74dacedc207697a07eb038CodingStyle: whitelist skins from erp5_ui_test2020-01-31T11:49:59+01:00Jérome Perrinjerome@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/5a061e8892a1ce3a3e49e7ea7f522372652c765chal_json_style: enable coding style check2020-01-31T11:49:58+01:00Jérome Perrinjerome@nexedi.comhttps://lab.nexedi.com/nexedi/erp5/-/commit/47c62a640cf1f2641af8c9ee70790792c5f4569chal_json_style: fix pylint error2020-01-31T11:49:57+01:00Jérome Perrinjerome@nexedi.com
This was a false positive