1. 30 Nov, 2018 1 commit
  2. 21 Nov, 2018 1 commit
  3. 16 Aug, 2018 1 commit
  4. 27 Jul, 2018 1 commit
    • Sebastien Robin's avatar
      simulation: solve random solving issues in a cluster environment · 924f20fa
      Sebastien Robin authored
      Before, when solving a solver, parsing sub objects of solver_process was done directly synchronously
      in solver_workflow. And we had the case where you have parallel transactions solving a solver,
      each of theses transactions see remaining solver not in solved state, but once all transaction are
      finished, all solver are solved. This could lead to the case where solver_process is never moved
      to succeeded. Instead of using serialize (which may lead to conflicts), just use activities in queue
      with a serialization tag.
      924f20fa
  5. 13 Jul, 2018 3 commits
  6. 05 Jul, 2018 1 commit
  7. 03 Jul, 2018 1 commit
    • Vincent Pelletier's avatar
      all: Replace after_path_and_method_id on reindexation methods by after_tag · 028c9ad7
      Vincent Pelletier authored
      after_method_id is too aggressive a dependency.
      after_path_and_method_id is marginally better, but is bad practice
      nevertheless, as such activity dependencies remain very hard to introspect.
      Tags allow more variations, and are hence easier to follow.
      Also, add XXX comments when (recursive) reindexation is only added to
      represent the dependency, without certainty that a reindexation is actually
      needed per-se: maybe another place in the code chould just appropriately
      tag its reindexation activities instead, saving at least the cost of
      spawning one more activity set, and at most the cost of actually
      reindexing these documents.
      028c9ad7
  8. 14 Jun, 2018 4 commits
  9. 22 May, 2018 1 commit
    • Jérome Perrin's avatar
      base: Image should not acquire local roles · 6476b264
      Jérome Perrin authored
      All top level documents are not supposed to acquire local roles
      https://www.erp5.com/erp5-Guideline.Unset.Acquire.Local.Roles.On.Document.Portal.Type.Configuration.If.Applicable
      
      I believe this comes from the time where we were using images as
      sub-documents of products or persons. We now use embedded files for
      these cases, so no need to have an exception here.
      
      Depending on the security configuration, there might be a notable side effect of applying this change: images that were visible by some users because they acquired Auditor role from the module will not longer be visible by these users, but they will still be indexed as visible, so they will appear in catalog searches.
      In such case, after re-indexing image module the catalog will be consistent again.
      
      
      /reviewed-on !666
      6476b264
  10. 16 May, 2018 2 commits
  11. 30 Mar, 2018 2 commits
  12. 05 Mar, 2018 2 commits
  13. 16 Feb, 2018 1 commit
  14. 14 Feb, 2018 1 commit
  15. 26 Dec, 2017 2 commits
  16. 15 Dec, 2017 1 commit
  17. 27 Nov, 2017 1 commit
  18. 16 Nov, 2017 1 commit
    • Jérome Perrin's avatar
      *: replace \r\n by \n in ZSQL Methods' arguments · 2adf9084
      Jérome Perrin authored
      From the root of repository, I did :
      
      grep -rl Products.ZSQLMethods.SQL  . | grep '\.xml$' | xargs ~/bin/zsql_backslash_n.py
      
      With a script containing
      ```python
      
      from lxml import etree
      import sys
      
      for filename in sys.argv[1:]:
        with open(filename) as f:
          tree = etree.parse(f)
          root = tree.getroot()
          for el in tree.xpath('//item/key/string[text() = "arguments_src"]/../../value/string'):
            if el.text:
              el.text = el.text.replace(r'\r\n', r'\n')
      
          # force <string> element to have a text, so that they export as <string></string> and not <string/>
          for el in tree.xpath('//string[not(text())]'):
            el.text = ''
      
        with open(filename, 'w') as f:
          f.write(
              '<?xml version="1.0"?>\n'
              + etree.tostring(root, pretty_print=True, encoding="utf-8"))
      
        print filename
      ```
      2adf9084
  19. 04 Nov, 2017 1 commit
  20. 31 Oct, 2017 1 commit
  21. 30 Oct, 2017 1 commit
    • Nicolas Wavrant's avatar
      erp5_base: add Organisation's registration code and VAT code in their searchable text · 1e2ebd69
      Nicolas Wavrant authored
      It is a common (CRM principally) use case to search for Organisations using official identifying unique codes, as the registration code or the VAT code.
      
      There is currently no way in ERP5 to look for entities using these unique codes, as they are not-generic enough to be indexed. For the same reason, creating a new table(s) to index Entities' identifiers may give something too blured to reach a consensus on. In my opinion fulltext search is a good solution for this case, and it shouldn't create compability issues for current projects. 
      
      If it is thought necessary, I can also add the Social Security Code (for Organisations/Persons) in the searchable text properties, but it is a more complicated topic as it isn't a public information.
      
      @nexedi 's project managers, what are your thoughts on it ?
      
      /reviewed-on !463
      1e2ebd69
  22. 25 Oct, 2017 1 commit
  23. 13 Oct, 2017 1 commit
    • Jérome Perrin's avatar
      base: remove OrganisationModule_viewSearchDialog · 73091aca
      Jérome Perrin authored
      It was "dead code", this form was not used in any action.
      
      Fields were not following naming conventions, so search would not even
      work.
      
      Because we generate search dialogs based on module listbox, organisation
      module already had a working search dialog, so this dialog is not needed
      anymore.
      73091aca
  24. 01 Sep, 2017 1 commit
    • Kazuhiko Shiozaki's avatar
      ERP5Catalog: add strict_language argument in getDocumentValueList(). · bd7e05f4
      Kazuhiko Shiozaki authored
      If strict_language is False, a document having the other language is
      chosen if the specified language one is missing.
      
      all_languages=True returns results grouped by (reference, language) so
      that we can have several documents for a single reference.
      
      strict_language=False returns results grouped by (reference,) only,
      with considering the language priority, thus we have only one document
      for a single reference.
      bd7e05f4
  25. 25 Aug, 2017 1 commit
  26. 23 Aug, 2017 1 commit
  27. 05 Jul, 2017 2 commits
  28. 03 Jul, 2017 1 commit
  29. 28 Jun, 2017 1 commit
    • Vincent Pelletier's avatar
      erp5_base: Rename z_related_resource_use into z_related_resource_related_use · 0cefde41
      Vincent Pelletier authored
      This ZSQLMethod is shadowing the one ERP5Catalog is trying to use, and
      it has a table list incompatible in 2 ways:
      - it joins again with catalog, despite only being used to pick the uid,
        which ERP5Catalog stopped doing for auto-generated related keys
      - it is actually a chained related key: resource, then use. But
        "resource_use" exists as a Base Category, and is accessible (but broken
        until this change) as "default_resource_use_uid" (for example).
      0cefde41
  30. 19 Jun, 2017 1 commit