1. 26 Jun, 2019 1 commit
  2. 25 Jun, 2019 1 commit
  3. 24 Jun, 2019 7 commits
  4. 22 Jun, 2019 1 commit
    • qa: always report unprocessed activities when functional tests fail · 8d6300da
      Example for erp5_web_renderjs_ui_test:testFunctionalRJSRelationField, which
      was failing randomly (fixed in ca229c3e):
      
      ======================================================================
      FAIL: testFunctionalTestRunner (erp5.component.test.erp5_version.testFunctionalRJSRelationField.TestRenderJSUIRelationField)
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File ".../product/ERP5Type/tests/ERP5TypeFunctionalTestCase.py", line 372, in testFunctionalTestRunner
          self.fail('\n'.join(error))
      AssertionError: These messages are pending: [('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/portal_catalog', 'unindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/bar_module', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_bar_module', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/portal_preferences/erp5_ui_test_preference', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module/2', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module/2', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module/3', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module', 'immediateReindexObject', -2, 1), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/bar_module', 'immediateReindexObject', -2, 1), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_bar_module', 'immediateReindexObject', -2, 1), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/portal_preferences/erp5_ui_test_preference', 'immediateReindexObject', -2, 1)]
      Last error message:
      RuntimeError
      tic is looping forever.
      Traceback (innermost last):
        Module ZPublisher.Publish, line 138, in publish
          request, bind=1)
        Module ZPublisher.mapply, line 77, in mapply
          if debug is not None: return debug(object,args,context)
        Module ZPublisher.Publish, line 48, in call_object
          result=apply(object,args) # Type s<cr> to step into published object.
        Module Products.ERP5Type.patches.ExternalMethod, line 113, in __call__
          return _f[0](self.aq_parent, *args, **kw)
        Module erp5.component.extension.erp5_version.ERP5Zuite, line 21, in waitForActivities
          raise RuntimeError('tic is looping forever.')
      RuntimeError: tic is looping forever.
      
      testAccessUnauthorizedRelationValue
      testBreadcrumbCanNotAccessRelationSearchPage
      testMultiRelationDefaultSortAndParameterList
      testMultiRelationFieldEmptySearchWithListbox
      testMultiRelationFieldHomonyms
      testMultiRelationFieldSearchWithListbox
      testMultiRelationFieldSearchWithProxyListbox
      testMultiRelationFieldUnknownIcon
      testMultiRelationFieldWithNonSavedPageContent
      testProxyListBox
      testRelationDefaultSortAndParameterList
      testRelationFieldEmptySearchWithListbox
      testRelationFieldRefresh
      testRelationFieldSearchWithListbox
      testRelationFieldWithNonSavedPageContent
      testSimpleMultiRelationField
      
      ----------------------------------------------------------------------
      Ran 1 test in 199.267s
      Bryton Lacquement committed
  5. 21 Jun, 2019 1 commit
    • [erp5_simulation] Allow to resolve divergency in the RJS UI · e391ae7c
      [erp5_base]
      Allow Manager to solve the divergency
      Pass the transition ID as the other workflow actions
      
      [erp5_simulation]
      Prevent duplicated keep_items
      
      Fix request value modifications
      
      Do not mark fields as required
      The RJS field marks it as required, and user can't submit anymore.
      Instead, use an external validator to only require the field when the user submit
      Romain Courteaud committed
  6. 20 Jun, 2019 1 commit
  7. 18 Jun, 2019 1 commit
  8. 17 Jun, 2019 2 commits
  9. 12 Jun, 2019 2 commits
  10. 10 Jun, 2019 1 commit
  11. 07 Jun, 2019 3 commits
  12. 06 Jun, 2019 3 commits
  13. 04 Jun, 2019 1 commit
    • Updates for xhtml style and gadgets · ce4e546b
      Gadgets:
      
      * Support `changed` flag from `erp5.js`: 
      
      ![unsaved changes sreenshot](/uploads/cff30eae0a5d87df26bac13d43e1da3f/image.png)
      
      * Comply with translation protocol used in ERP5JS. This does not translate, because it would not be easy ( ERP5JS translate client side with a json database of message, but in xhtml style the translation is performed server side with localizer) and not so important now. What matters is just that we can somehow reuse gadgets.
      
      Style:
      
      * While we are at it, fix a minor annoyance that the button in "long" dialogs where not easy to reach, at least on chrome
      
      ![before](/uploads/e03a8311571806a55fd72f6923cf855a/Screenshot_2019-05-31_at_10.38.05.png)
      
      ![after](/uploads/5753bc44fbc0f69b6adfeb14b3367236/Screenshot_2019-05-31_at_10.38.37.png)
      
      /reviewed-on !880
      Jérome Perrin committed
  14. 03 Jun, 2019 7 commits
  15. 31 May, 2019 3 commits
  16. 28 May, 2019 1 commit
  17. 24 May, 2019 4 commits
    • simulation: Test the divergence on Float Equivalence Tester with the epsilon-span by default · 6d17f0a1
      Before:
         Float Equivalence Tester does not test the divergence even if Divergence Provider is ON
          
      After:
           Float Equivalence Tester test the divergence with the epsilon-span if Divergence Provider is ON
          
      Before, we needed the following condition to test the divergence at Float Equivalence Tester:
          
             "Divergence Provider is ON"  AND
             ("Absolute Tolerance has some value"  OR
              "Relative Tolerance has some value" )
          
      However this default behavior was not consistent with other testers, and
      difficult to notice from the user interface.
      Thus test the divergence by default with the epsilon span which is defined in 
      FloatEquivalenceTester class.
          
      The epsilon-span is the same amount that when we put 0.0 into the ranges.
      The 0.0 has been the configuration of erp5_configurator_standard_trade_template.
      
      /reviewed-on !865
      Tatuya Kamada committed
    • CMFActivity.ActivityTool: Add missing security declaration. · cfd807ca
      Vincent Pelletier committed
    • ZSQLCatalog: Fix security indexation when indexing the same object multiple times · 048c4414
      When an object is being indexed, it get wrapped so it has magic properties,
      like security definitions as they will be accessed by indexation methods.
      One such property is used to trigger the insertion of rows in
      roles_and_users table. That property has the special feature that it is
      only produced on the first object needing a new set of rows added to
      roles_and_users, other objects will get a None value instead for that
      property so that no further lines are inserted.
      Then, SQCatalog iterates over that wrapper list to compute all indexation
      method parameters. It does so via a cache (LazyIndexationParameterList) so
      that unused parameters are not computed. The cache key is wrapped object's
      uid.
      All this together means that if an object is indexed multiple times in a
      single call (which happens at site creation, for example) and it needs a
      new set of rows added in roles_and_users, only one of produced wrappers
      will get the appropriate value. If that object is not the first on which
      that parameter is evaluated (which gets more likely with every copy of the
      same object being indexed), it will be cached as None and shared between
      all copies, causing no row to be added to roles_and_users.
      
      Full investigation done by by Yusei Tahara.
      wrappers will get the
      Vincent Pelletier committed