erp5_web_project_ui: initial commit for project.nexedi.net
Merged
by 
The changes were merged into master.
-
added 1 commit
- c78dc8f2 - erp5_web_project_ui: front page redirects to custom project module
Toggle commit list -
Toggle commit list
-
Toggle commit list
-
added 1 commit
- e4750a0c - erp5_project: new portal domains for projects filtering
Toggle commit list -
added 1 commit
- aab87399 - erp5_web_project_ui: new skin folder with project quick view form and scripts
Toggle commit list -
added 1 commit
- 473af8cf - erp5_project: project list items ulrs points to new project quick view
Toggle commit list -
added 1 commit
- 3e690ecc - erp5_web_project_ui: button links based on project tabs (views)
Toggle commit list -
Toggle commit list
-
added 1 commit
- 2a16bb6f - erp5_web_project_ui: controller redirect url parameters use domain for filter
Toggle commit list -
added 7 commits
- 7daf6c03 - [HARDCODED] run only Project tests
- 114174a0 - erp5_project: new portal domains for projects filtering
- 420b79ad - erp5_web_project_ui: new skin folder with project quick view form and scripts
- 5f0c72f5 - erp5_project: project list items ulrs points to new project quick view
- 4dfa28e0 - erp5_web_project_ui: button links based on project tabs (views)
- 95158eed - erp5_project: fixing project state domain
- fcb2fc42 - erp5_web_project_ui: controller redirect url parameters use domain for filter
Toggle commit list -
Toggle commit list
-
-
Toggle commit list
-
Toggle commit list
-
-
Toggle commit list
-
Toggle commit list
-
Toggle commit list
-
added 2 commits
Toggle commit list -
-
-
-
-
-
-
added 1 commit
- 69cdd67b - erp5_web_project_ui: refactoring on project gadget info
Toggle commit list -
Toggle commit list
-
-
-
added 1 commit
- 4296e4af - erp5_web_project_ui: project web page as non editable gadget editor
Toggle commit list -
added 1 commit
- e3fb5013 - erp5_web_renderjs_ui: header title link changed from display to history_previous
Toggle commit list -
Toggle commit list
-
added 1 commit
- a7359e8e - erp5_web_project_ui: get last test result state using jio
Toggle commit list -
-
-
-
Toggle commit list
-
Toggle commit list
-
-
Toggle commit list
-
-
Toggle commit list
-
Toggle commit list
-
-
Toggle commit list
-
Toggle commit list
-
added 6 commits
- a4ed1dd4 - erp5_web_project_ui: initial commit for project.nexedi.net
- 64eac95c - erp5_project: new portal domains, scripts and forms for project management views
- 2bdd2e5f - erp5_crm: new domain in support request list
- 2469b884 - erp5_forge: bug module domain
- 2d2018a2 - erp5_web_renderjs_ui: header title link changed from display to history_previous
- c90f2131 - [HARDCODED] run all tests
Toggle commit list -
-
added 6 commits
- d8f35543 - erp5_web_project_ui: initial commit for project.nexedi.net
- 69e1237b - erp5_project: new portal domains, scripts and forms for project management views
- 4c9b019c - erp5_crm: new domain in support request list
- 9b509c2a - erp5_forge: bug module domain
- 70462354 - erp5_web_renderjs_ui: header title link changed from display to history_previous
- e438e874 - [HARDCODED] run all tests
Toggle commit list -
Salut @romain , this MR is ready for review.
I run all tests and this change: rporchetto/erp5@70462354 (form_list header link from #display to #history_previous) makes this test fail: https://nexedijs.erp5.net/#/test_result_module/20191104-73476366/108?uid=2027541975
-
It seems it also breaks erp5js usability completely, as clicking on the link does nothing on module. More manual checks are needed, and probably a new test to prevent such unexpected regression.
-
bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Base_generateStateSupportDomain.py 0 → 100644
11 12 not_validated_domain.edit(title="Not Validated", 13 criterion_property_list=['simulation_state']) 14 not_validated_domain.setCriterion('simulation_state', identity=['submitted', 'suspended', 'draft', 'invalidated']) 15 16 domain_list.append(not_validated_domain) 17 18 cancelled_domain = parent.generateTempDomain(id='cancelled') 19 20 cancelled_domain.edit(title="Cancelled", 21 criterion_property_list=['simulation_state']) 22 cancelled_domain.setCriterion('simulation_state', identity=['cancelled', 'deleted']) 23 24 domain_list.append(cancelled_domain) 25 26 return domain_list -
isn't it possible to factorise a bit the code? (lot of duplicated logic inside the script + nearly identical other scripts)
-
Yes, I refactored it into a short function "generateDomain(id, title, criterion_property, criterion_identity)". This function is used then by all the scripts, so it should be in a common script. Considering that these scripts are in different bts, where do you think is the best location for the common script? I see that all involved bt (for now: crm, forge and project) depends on erp5_base. Is it ok to put the common script there?
-
-
219 237 </item> 238 <item> 239 <key> <string>url_columns</string> </key> 240 <value> 241 <list> 242 <tuple> 243 <string>title</string> 244 <string>Project_getQuickViewUrl</string> 245 </tuple> 246 <tuple> 247 <string>default_destination_section_title</string> 248 <string>Project_getQuickViewUrl</string> 249 </tuple> 250 </list> 251 </value> 252 </item> -
the url_columns will break erp5 current usage (this script does not exist in erp5_project and is not desired there)
-
Then, in order to drop this change here, I should use a new project-list-form right?
-
Yes. I do not see any other solution for now.
-
-
bt5/erp5_project/SkinTemplateItem/portal_skins/erp5_project/Project_viewMilestone.xml
117 131 </item> 118 132 <item> 119 133 <key> <string>pt</string> </key> 120 <value> <string>form_view</string> </value> 134 <value> <string>form_list</string> </value> -
This also breaks
erp5_projectbehaviour.
-
-
bt5/erp5_web_project_ui/SkinTemplateItem/portal_skins/erp5_web_project/Project_getRenderJSExtraInfoParameterList.py 0 → 100644
1 """ 2 ================================================================================ 3 Return parameters to correctly display the RenderJS gadget 4 ================================================================================ 5 """ 6 7 return [('project_title', context.getTitle()), ('jio_key', context.getRelativeUrl()), ('project_reference', context.getReference())] -
do you really need a new script? Isn't it possible to set the list in the TALES expression?
-
It was a more complex script at the beginning, then I moved most of the code into jio requests in js side, so now there isn't need of this script. I'll move it to TALES tab in the form.
-
-
bt5/erp5_web_project_ui/SkinTemplateItem/portal_skins/erp5_web_project/gadget_project_info.html.html 0 → 100644
15 <p> 16 <a id="milestone_link" class="first-line-buttons ui-disabled" data-i18n="[value]Milestones" disabled >Milestones</a> 17 <a id="support_request_link" class="first-line-buttons ui-disabled" data-i18n="[value]Support Requests" disabled >Support requests</a> 18 <a id="bug_link" class="first-line-buttons ui-disabled" data-i18n="[value]Bugs" disabled >Opened Bugs</a> 19 <a id="closed_bug_link" class="first-line-buttons ui-disabled" data-i18n="[value]Closed Bugs" disabled >Closed Bugs</a> 20 </p> 21 </div> 22 <div class="ui-field-contain" style="top:75px;"> 23 <p> 24 <a id="task_link" class="first-line-buttons ui-disabled" data-i18n="[value]Confirmed Tasks" disabled >Confirmed Tasks</a> 25 <a id="not_confirmed_task_link" class="first-line-buttons ui-disabled" data-i18n="[value]Not Confirmed Tasks" disabled >Not Confirmed Tasks</a> 26 <a id="report_link" class="first-line-buttons ui-disabled" data-i18n="[value]Task Reports" disabled >Opened Task Reports</a> 27 <a id="closed_report_link" class="first-line-buttons ui-disabled" data-i18n="[value]Closed Task Reports" disabled >Closed Task Reports</a> 28 </p> 29 </div> 30 <div class="ui-field-contain" style="top:125px;"> -
I would prefer to not set any
styleattribute in the HTML. Please update your custom CSS instead.
-
-
bt5/erp5_web_project_ui/SkinTemplateItem/portal_skins/erp5_web_project/gadget_project_info.js.js 0 → 100644
1 /*jslint nomen: true, indent: 2 */ 2 /*global window, rJS, RSVP, document, FileReader, Blob, jIO, ensureArray, 3 lockGadgetInQueue, unlockGadgetInQueue*/ -
can you
jslintthis script? (I expect it to at least complain about the unusedlockGadgetInQueuevariable)
-
-
bt5/erp5_web_project_ui/bt/template_path_list 0 → 100644
1 web_page_module/project_** 2 web_site_module/project_nexedi_net -
I don't like the
nexedi_netsuffix, as this code is commited in erp5 repository, and so, is unrelated to any custom nexedi configuration.Please find a more generic name.
-
do you agree with "project_management_net" ?
-
_netis meaningless too.
-
-
added 1 commit
- b951c276 - erp5_project: undo page template change in milestone view form
Toggle commit list -
-
added 1 commit
- 4aa18574 - erp5_web_project_ui: drop script and use TALES exp directly
Toggle commit list -
added 1 commit
- 3a7ae796 - erp5_web_project_ui: code cleanup in project info gadget
Toggle commit list -
-
added 1 commit
- 223bd298 - erp5_web_project_ui: rename web site to project_management
Toggle commit list -
-
Toggle commit list
-
Toggle commit list
-
Toggle commit list
-
-
-
added 1 commit
- f8ff4674 - erp5_web_project_ui: using new project management list form
Toggle commit list -
added 7 commits
- 77e065b6 - erp5_web_project_ui: initial commit for project.nexedi.net
- fb45e8aa - erp5_project: new portal domains, scripts and forms for project management views
- 6116f34a - erp5_base: common script to generate domains
- 79984524 - erp5_crm: new domain in support request list
- 1b6bfce3 - erp5_forge: bug module domain
- 82e18270 - erp5_web_renderjs_ui: header title link changed from display to history_previous
- a3a20f36 - [HARDCODED] run all tests
Toggle commit list -
added 81 commits
-
a3a20f36...df0701cf - 73 commits from branch
nexedi:master - c6ee24de - [HARDCODED] run only Project tests
- abd21ba7 - erp5_web_project_ui: initial commit for project.nexedi.net
- 73c5d9cd - erp5_project: new portal domains, scripts and forms for project management views
- fc1bd901 - erp5_base: common script to generate domains
- 5b9fe63c - erp5_crm: new domain in support request list
- 8e24cf2c - erp5_forge: bug module domain
- 57e32f64 - erp5_web_renderjs_ui: header title link changed from display to history_previous
- 102f7823 - [HARDCODED] run all tests
Toggle commit list -
a3a20f36...df0701cf - 73 commits from branch
-
added 8 commits
- 8f1ab296 - erp5_web_project_ui: initial commit for project.nexedi.net
- 35490eda - erp5_project: new portal domains, scripts and forms for project management views
- 7c6857cb - erp5_base: common script to generate domains
- 7fc5d68a - erp5_crm: new domain in support request list
- 0ee638ad - erp5_forge: bug module domain
- bd828fc9 - erp5_web_renderjs_ui: header title link changed from display to history_previous
- 06897d9b - [HARDCODED] run only Project tests
- 2e8e11c3 - [HARDCODED] run all tests
Toggle commit list -
Toggle commit list
-
Toggle commit list
-
added 8 commits
- 3a2b5e89 - erp5_web_project_ui: initial commit for project.nexedi.net
- b68e9ee6 - erp5_project: new portal domains, scripts and forms for project management views
- 22cc28f3 - erp5_base: common script to generate domains
- 6b68d772 - erp5_crm: new domain in support request list
- f9f48681 - erp5_forge: bug module domain
- 05d627e8 - erp5_web_renderjs_ui: header title link changed from display to history_previous
- e74138ae - [HARDCODED] run only Project tests
- b4a97b71 - [HARDCODED] run all tests
Toggle commit list -
Toggle commit list
-
Toggle commit list
-
-
added 1 commit
- fcf5e6fb - Revert "erp5_web_renderjs_ui: header title link changed from display to history_previous"
Toggle commit list -
added 5 commits
- 049391fb - erp5_web_project_ui: initial commit for project.nexedi.net
- 75a69827 - erp5_project: new portal domains, scripts and forms for project management views
- e19243da - erp5_base: common script to generate domains
- 2cbd438f - erp5_crm: new domain in support request list
- e9072e43 - erp5_forge: bug module domain
Toggle commit list -
-
-
Toggle commit list
-
-
added 5 commits
- 79f5af69 - erp5_web_project_ui: initial commit for project.nexedi.net
- 7687fbb2 - erp5_project: new portal domains, scripts and forms for project management views
- bfd4ea44 - erp5_base: common script to generate domains
- 7dced729 - erp5_crm: new domain in support request list
- df660f4f - erp5_forge: bug module domain
Toggle commit list -
-
added 5 commits
- 04e49f17 - erp5_web_project_ui: initial commit for project.nexedi.net
- d5ac659d - erp5_project: new portal domains, scripts and forms for project management views
- d3b71453 - erp5_base: common script to generate domains
- 33836627 - erp5_crm: new domain in support request list
- 61edeef4 - erp5_forge: bug module domain
Toggle commit list -
-
-
merged
Toggle commit list
-
Please register or sign in to post a comment