Skip to content
  • This project
    • Loading...
  • Sign in

nexedi / erp5

Go to a project
Toggle navigation
Toggle navigation pinning
  • Projects
  • Groups
  • Snippets
  • Help
  • Project
  • Activity
  • Repository
  • Pipelines
  • Graphs
  • Merge Requests 113
  • Wiki
  • Snippets
  • Network
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge Request !956 opened 2019-10-11 09:45:04 UTC by Roque@rporchetto

erp5_web_project_ui: initial commit for project.nexedi.net

Edited 2019-11-21 01:17:04 UTC
Request to merge rporchetto:project_nexedi_net into master
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://lab.nexedi.com/rporchetto/erp5.git project_nexedi_net
git checkout -b rporchetto/erp5-project_nexedi_net FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff rporchetto/erp5-project_nexedi_net

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Merged by Roque 2019-11-08 13:42:39 UTC

The changes were merged into master.

  • Discussion 15
  • Commits 5
  • Changes 74
  • {{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • c78dc8f2 - erp5_web_project_ui: front page redirects to custom project module

    Compare with previous version

    2019-10-11 12:18:14 UTC

    added 1 commit

    • c78dc8f2 - erp5_web_project_ui: front page redirects to custom project module

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 13661fae - erp5_web_project_ui_test : initial commit

    Compare with previous version

    2019-10-11 16:53:50 UTC

    added 1 commit

    • 13661fae - erp5_web_project_ui_test : initial commit

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 323dcc2e - [HARDCODED] run only Project tests

    Compare with previous version

    2019-10-11 16:58:04 UTC

    added 1 commit

    • 323dcc2e - [HARDCODED] run only Project tests

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 98a8964c - [HARDCODE] fix tests

    Compare with previous version

    2019-10-15 07:22:57 UTC

    added 1 commit

    • 98a8964c - [HARDCODE] fix tests

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • e4750a0c - erp5_project: new portal domains for projects filtering

    Compare with previous version

    2019-10-15 09:22:33 UTC

    added 1 commit

    • e4750a0c - erp5_project: new portal domains for projects filtering

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • aab87399 - erp5_web_project_ui: new skin folder with project quick view form and scripts

    Compare with previous version

    2019-10-17 15:05:07 UTC

    added 1 commit

    • aab87399 - erp5_web_project_ui: new skin folder with project quick view form and scripts

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 473af8cf - erp5_project: project list items ulrs points to new project quick view

    Compare with previous version

    2019-10-17 15:11:16 UTC

    added 1 commit

    • 473af8cf - erp5_project: project list items ulrs points to new project quick view

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 3e690ecc - erp5_web_project_ui: button links based on project tabs (views)

    Compare with previous version

    2019-10-18 10:40:08 UTC

    added 1 commit

    • 3e690ecc - erp5_web_project_ui: button links based on project tabs (views)

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 1e7aabae - erp5_project: fixing project state domain

    Compare with previous version

    2019-10-21 13:38:28 UTC

    added 1 commit

    • 1e7aabae - erp5_project: fixing project state domain

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 903712fd - [HARDCODED] tests

    Compare with previous version

    2019-10-21 13:58:25 UTC

    added 1 commit

    • 903712fd - [HARDCODED] tests

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 2a16bb6f - erp5_web_project_ui: controller redirect url parameters use domain for filter

    Compare with previous version

    2019-10-21 15:02:08 UTC

    added 1 commit

    • 2a16bb6f - erp5_web_project_ui: controller redirect url parameters use domain for filter

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • bb419d5f - [HARDCODED] all tests

    Compare with previous version

    2019-10-22 08:37:08 UTC

    added 1 commit

    • bb419d5f - [HARDCODED] all tests

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 2a91c0f5 - [HARDCODED] fix tests

    Compare with previous version

    2019-10-22 13:22:44 UTC

    added 1 commit

    • 2a91c0f5 - [HARDCODED] fix tests

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 7 commits

    • 7daf6c03 - [HARDCODED] run only Project tests
    • 114174a0 - erp5_project: new portal domains for projects filtering
    • 420b79ad - erp5_web_project_ui: new skin folder with project quick view form and scripts
    • 5f0c72f5 - erp5_project: project list items ulrs points to new project quick view
    • 4dfa28e0 - erp5_web_project_ui: button links based on project tabs (views)
    • 95158eed - erp5_project: fixing project state domain
    • fcb2fc42 - erp5_web_project_ui: controller redirect url parameters use domain for filter

    Compare with previous version

    2019-10-22 13:24:11 UTC

    added 7 commits

    • 7daf6c03 - [HARDCODED] run only Project tests
    • 114174a0 - erp5_project: new portal domains for projects filtering
    • 420b79ad - erp5_web_project_ui: new skin folder with project quick view form and scripts
    • 5f0c72f5 - erp5_project: project list items ulrs points to new project quick view
    • 4dfa28e0 - erp5_web_project_ui: button links based on project tabs (views)
    • 95158eed - erp5_project: fixing project state domain
    • fcb2fc42 - erp5_web_project_ui: controller redirect url parameters use domain for filter

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 3fdd7a0a - erp5_project: domains for project views

    Compare with previous version

    2019-10-22 14:43:22 UTC

    added 1 commit

    • 3fdd7a0a - erp5_project: domains for project views

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 0fd28ca6 - erp5_web_project_ui: custom links parameters

    Compare with previous version

    2019-10-22 14:44:38 UTC

    added 1 commit

    • 0fd28ca6 - erp5_web_project_ui: custom links parameters

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 388570eb - erp5_project: extend task report domain

    Compare with previous version

    2019-10-22 16:14:37 UTC

    added 1 commit

    • 388570eb - erp5_project: extend task report domain

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • b518055d - erp5_web_project_ui: more links

    Compare with previous version

    2019-10-22 16:15:14 UTC

    added 1 commit

    • b518055d - erp5_web_project_ui: more links

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 36ae4d1c - erp5_web_project_ui: display project home page

    Compare with previous version

    2019-10-23 12:28:44 UTC

    added 1 commit

    • 36ae4d1c - erp5_web_project_ui: display project home page

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 4c18bf72 - erp5_project: more domains

    Compare with previous version

    2019-10-23 12:29:46 UTC

    added 1 commit

    • 4c18bf72 - erp5_project: more domains

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • fb0dbc3c - erp5_crm: support request status domain

    Compare with previous version

    2019-10-23 12:36:51 UTC

    added 1 commit

    • fb0dbc3c - erp5_crm: support request status domain

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 581181de - erp5_project: remove domain

    Compare with previous version

    2019-10-23 12:38:16 UTC

    added 1 commit

    • 581181de - erp5_project: remove domain

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 2 commits

    • 5a0e04d8 - erp5_project: remove domain
    • 33a47ebc - erp5_crm: support request status domain

    Compare with previous version

    2019-10-23 15:45:42 UTC

    added 2 commits

    • 5a0e04d8 - erp5_project: remove domain
    • 33a47ebc - erp5_crm: support request status domain

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 82dce126 - Revert "erp5_crm: support request status domain"

    Compare with previous version

    2019-10-23 15:46:54 UTC

    added 1 commit

    • 82dce126 - Revert "erp5_crm: support request status domain"

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 2 commits

    • afb7b189 - erp5_project: new portal domains, scripts and forms for project management views
    • 51a3455e - erp5_web_project_ui: new skin folder with project quick view form, scripts and gadgets

    Compare with previous version

    2019-10-23 15:53:46 UTC

    added 2 commits

    • afb7b189 - erp5_project: new portal domains, scripts and forms for project management views
    • 51a3455e - erp5_web_project_ui: new skin folder with project quick view form, scripts and gadgets

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 4 commits

    • 81cbdb27 - [HARDCODED] run only Project tests
    • 5591672a - erp5_web_project_ui: initial commit for project.nexedi.net
    • 6ec4403c - erp5_project: new portal domains, scripts and forms for project management views
    • 26a666fa - erp5_web_project_ui_test : initial commit

    Compare with previous version

    2019-10-23 15:56:32 UTC

    added 4 commits

    • 81cbdb27 - [HARDCODED] run only Project tests
    • 5591672a - erp5_web_project_ui: initial commit for project.nexedi.net
    • 6ec4403c - erp5_project: new portal domains, scripts and forms for project management views
    • 26a666fa - erp5_web_project_ui_test : initial commit

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 6b078aa4 - erp5_project: new support request view and domain

    Compare with previous version

    2019-10-23 16:01:08 UTC

    added 1 commit

    • 6b078aa4 - erp5_project: new support request view and domain

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • c88925b1 - erp5_project: set project view forms as lists

    Compare with previous version

    2019-10-24 15:24:29 UTC

    added 1 commit

    • c88925b1 - erp5_project: set project view forms as lists

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 3e39c536 - erp5_web_project_ui: worklist in project page

    Compare with previous version

    2019-10-24 15:32:02 UTC

    added 1 commit

    • 3e39c536 - erp5_web_project_ui: worklist in project page

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 69cdd67b - erp5_web_project_ui: refactoring on project gadget info

    Compare with previous version

    2019-10-25 13:28:42 UTC

    added 1 commit

    • 69cdd67b - erp5_web_project_ui: refactoring on project gadget info

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 5a078b12 - erp5_project: move support domain to crm bt

    Compare with previous version

    2019-10-31 10:54:11 UTC

    added 1 commit

    • 5a078b12 - erp5_project: move support domain to crm bt

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 0dc33e4d - erp5_crm: new domain in support request list

    Compare with previous version

    2019-10-31 10:55:41 UTC

    added 1 commit

    • 0dc33e4d - erp5_crm: new domain in support request list

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • b32b8844 - erp5_web_project_ui: changes for first release

    Compare with previous version

    2019-10-31 10:57:27 UTC

    added 1 commit

    • b32b8844 - erp5_web_project_ui: changes for first release

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 4296e4af - erp5_web_project_ui: project web page as non editable gadget editor

    Compare with previous version

    2019-10-31 13:49:18 UTC

    added 1 commit

    • 4296e4af - erp5_web_project_ui: project web page as non editable gadget editor

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • e3fb5013 - erp5_web_renderjs_ui: header title link changed from display to history_previous

    Compare with previous version

    2019-10-31 15:34:00 UTC

    added 1 commit

    • e3fb5013 - erp5_web_renderjs_ui: header title link changed from display to history_previous

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 377eef39 - [HARDCODED] run all tests

    Compare with previous version

    2019-10-31 16:26:07 UTC

    added 1 commit

    • 377eef39 - [HARDCODED] run all tests

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • a7359e8e - erp5_web_project_ui: get last test result state using jio

    Compare with previous version

    2019-11-04 09:19:13 UTC

    added 1 commit

    • a7359e8e - erp5_web_project_ui: get last test result state using jio

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 12f498d3 - erp5_web_project_ui: get project web page using jio

    Compare with previous version

    2019-11-04 09:38:55 UTC

    added 1 commit

    • 12f498d3 - erp5_web_project_ui: get project web page using jio

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • bf40a06e - erp5_web_project_ui: link to edit project web page

    Compare with previous version

    2019-11-04 10:17:55 UTC

    added 1 commit

    • bf40a06e - erp5_web_project_ui: link to edit project web page

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • cbeaa84a - erp5_web_project_ui: refactoring and cleanup

    Compare with previous version

    2019-11-04 10:42:19 UTC

    added 1 commit

    • cbeaa84a - erp5_web_project_ui: refactoring and cleanup

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • f3c7a7b0 - erp5_web_project_ui: remove server scripts

    Compare with previous version

    2019-11-04 10:47:21 UTC

    added 1 commit

    • f3c7a7b0 - erp5_web_project_ui: remove server scripts

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • f3e64e73 - erp5_web_project_ui: styles and layout

    Compare with previous version

    2019-11-04 12:31:59 UTC

    added 1 commit

    • f3e64e73 - erp5_web_project_ui: styles and layout

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 7b6d1a11 - erp5_project: domain script moved to erp5_crm

    Compare with previous version

    2019-11-04 12:42:07 UTC

    added 1 commit

    • 7b6d1a11 - erp5_project: domain script moved to erp5_crm

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • dc6361ca - erp5_crm: domain script for support request

    Compare with previous version

    2019-11-04 12:42:27 UTC

    added 1 commit

    • dc6361ca - erp5_crm: domain script for support request

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 545e6d09 - erp5_project: remove obsolet scripts and view

    Compare with previous version

    2019-11-04 13:06:13 UTC

    added 1 commit

    • 545e6d09 - erp5_project: remove obsolet scripts and view

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • f3580cd9 - erp5_project: remove obsolete portal action

    Compare with previous version

    2019-11-04 13:06:51 UTC

    added 1 commit

    • f3580cd9 - erp5_project: remove obsolete portal action

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 1407a2b7 - erp5_web_project_ui: minor styles

    Compare with previous version

    2019-11-04 13:07:25 UTC

    added 1 commit

    • 1407a2b7 - erp5_web_project_ui: minor styles

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • c6a99bab - erp5_project: undo changes in project view forms

    Compare with previous version

    2019-11-04 13:22:44 UTC

    added 1 commit

    • c6a99bab - erp5_project: undo changes in project view forms

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 60434f38 - erp5_project: move bug domain to epr5_forge

    Compare with previous version

    2019-11-04 13:30:55 UTC

    added 1 commit

    • 60434f38 - erp5_project: move bug domain to epr5_forge

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • a743b256 - erp5_forge: bug module domain

    Compare with previous version

    2019-11-04 13:31:05 UTC

    added 1 commit

    • a743b256 - erp5_forge: bug module domain

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 6 commits

    • a4ed1dd4 - erp5_web_project_ui: initial commit for project.nexedi.net
    • 64eac95c - erp5_project: new portal domains, scripts and forms for project management views
    • 2bdd2e5f - erp5_crm: new domain in support request list
    • 2469b884 - erp5_forge: bug module domain
    • 2d2018a2 - erp5_web_renderjs_ui: header title link changed from display to history_previous
    • c90f2131 - [HARDCODED] run all tests

    Compare with previous version

    2019-11-04 13:51:16 UTC

    added 6 commits

    • a4ed1dd4 - erp5_web_project_ui: initial commit for project.nexedi.net
    • 64eac95c - erp5_project: new portal domains, scripts and forms for project management views
    • 2bdd2e5f - erp5_crm: new domain in support request list
    • 2469b884 - erp5_forge: bug module domain
    • 2d2018a2 - erp5_web_renderjs_ui: header title link changed from display to history_previous
    • c90f2131 - [HARDCODED] run all tests

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 972dcd19 - erp5_web_project_ui: fix error when no web page

    Compare with previous version

    2019-11-04 15:25:48 UTC

    added 1 commit

    • 972dcd19 - erp5_web_project_ui: fix error when no web page

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 6 commits

    • d8f35543 - erp5_web_project_ui: initial commit for project.nexedi.net
    • 69e1237b - erp5_project: new portal domains, scripts and forms for project management views
    • 4c9b019c - erp5_crm: new domain in support request list
    • 9b509c2a - erp5_forge: bug module domain
    • 70462354 - erp5_web_renderjs_ui: header title link changed from display to history_previous
    • e438e874 - [HARDCODED] run all tests

    Compare with previous version

    2019-11-04 15:45:49 UTC

    added 6 commits

    • d8f35543 - erp5_web_project_ui: initial commit for project.nexedi.net
    • 69e1237b - erp5_project: new portal domains, scripts and forms for project management views
    • 4c9b019c - erp5_crm: new domain in support request list
    • 9b509c2a - erp5_forge: bug module domain
    • 70462354 - erp5_web_renderjs_ui: header title link changed from display to history_previous
    • e438e874 - [HARDCODED] run all tests

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto commented 2019-11-05 08:23:19 UTC
    Developer

    Salut @romain , this MR is ready for review.

    I run all tests and this change: rporchetto/erp5@70462354 (form_list header link from #display to #history_previous) makes this test fail: https://nexedijs.erp5.net/#/test_result_module/20191104-73476366/108?uid=2027541975

  • @romain Romain Courteaud
    @romain commented 2019-11-06 09:53:56 UTC
    Owner

    It seems it also breaks erp5js usability completely, as clicking on the link does nothing on module. More manual checks are needed, and probably a new test to prevent such unexpected regression.

  • Images
    Toggle discussion
    Romain Courteaud
    @romain started a discussion on an outdated diff 2019-11-06 09:55:29 UTC
    Last updated by Roque 2019-11-06 10:36:24 UTC
    bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Base_generateStateSupportDomain.py 0 → 100644
    11
    12 not_validated_domain.edit(title="Not Validated",
    13 criterion_property_list=['simulation_state'])
    14 not_validated_domain.setCriterion('simulation_state', identity=['submitted', 'suspended', 'draft', 'invalidated'])
    15
    16 domain_list.append(not_validated_domain)
    17
    18 cancelled_domain = parent.generateTempDomain(id='cancelled')
    19
    20 cancelled_domain.edit(title="Cancelled",
    21 criterion_property_list=['simulation_state'])
    22 cancelled_domain.setCriterion('simulation_state', identity=['cancelled', 'deleted'])
    23
    24 domain_list.append(cancelled_domain)
    25
    26 return domain_list
    • @romain Romain Courteaud
      @romain commented 2019-11-06 09:55:29 UTC
      Owner

      isn't it possible to factorise a bit the code? (lot of duplicated logic inside the script + nearly identical other scripts)

    • @rporchetto Roque
      @rporchetto commented 2019-11-06 10:36:24 UTC
      Developer

      Yes, I refactored it into a short function "generateDomain(id, title, criterion_property, criterion_identity)". This function is used then by all the scripts, so it should be in a common script. Considering that these scripts are in different bts, where do you think is the best location for the common script? I see that all involved bt (for now: crm, forge and project) depends on erp5_base. Is it ok to put the common script there?

  • Images
    Toggle discussion
    Romain Courteaud
    @romain started a discussion on the diff 2019-11-06 09:58:11 UTC
    Last updated by Romain Courteaud 2019-11-06 14:50:13 UTC
    bt5/erp5_project/SkinTemplateItem/portal_skins/erp5_project/ProjectModule_viewProjectList/listbox.xml
    219 237 </item>
    238 <item>
    239 <key> <string>url_columns</string> </key>
    240 <value>
    241 <list>
    242 <tuple>
    243 <string>title</string>
    244 <string>Project_getQuickViewUrl</string>
    245 </tuple>
    246 <tuple>
    247 <string>default_destination_section_title</string>
    248 <string>Project_getQuickViewUrl</string>
    249 </tuple>
    250 </list>
    251 </value>
    252 </item>
    • @romain Romain Courteaud
      @romain commented 2019-11-06 09:58:11 UTC
      Owner

      the url_columns will break erp5 current usage (this script does not exist in erp5_project and is not desired there)

    • @rporchetto Roque
      @rporchetto commented 2019-11-06 13:39:33 UTC
      Developer

      Then, in order to drop this change here, I should use a new project-list-form right?

    • @romain Romain Courteaud
      @romain commented 2019-11-06 14:50:13 UTC
      Owner

      Yes. I do not see any other solution for now.

  • Images
    Toggle discussion
    Romain Courteaud
    @romain started a discussion on an outdated diff 2019-11-06 09:59:40 UTC
    bt5/erp5_project/SkinTemplateItem/portal_skins/erp5_project/Project_viewMilestone.xml
    117 131 </item>
    118 132 <item>
    119 133 <key> <string>pt</string> </key>
    120 <value> <string>form_view</string> </value>
    134 <value> <string>form_list</string> </value>
    • @romain Romain Courteaud
      @romain commented 2019-11-06 09:59:40 UTC
      Owner

      This also breaks erp5_project behaviour.

  • Images
    Toggle discussion
    Romain Courteaud
    @romain started a discussion on an outdated diff 2019-11-06 10:01:34 UTC
    Last updated by Roque 2019-11-06 10:05:09 UTC
    bt5/erp5_web_project_ui/SkinTemplateItem/portal_skins/erp5_web_project/Project_getRenderJSExtraInfoParameterList.py 0 → 100644
    1 """
    2 ================================================================================
    3 Return parameters to correctly display the RenderJS gadget
    4 ================================================================================
    5 """
    6
    7 return [('project_title', context.getTitle()), ('jio_key', context.getRelativeUrl()), ('project_reference', context.getReference())]
    • @romain Romain Courteaud
      @romain commented 2019-11-06 10:01:34 UTC
      Owner

      do you really need a new script? Isn't it possible to set the list in the TALES expression?

    • @rporchetto Roque
      @rporchetto commented 2019-11-06 10:05:09 UTC
      Developer

      It was a more complex script at the beginning, then I moved most of the code into jio requests in js side, so now there isn't need of this script. I'll move it to TALES tab in the form.

  • Images
    Toggle discussion
    Romain Courteaud
    @romain started a discussion on an outdated diff 2019-11-06 10:02:46 UTC
    bt5/erp5_web_project_ui/SkinTemplateItem/portal_skins/erp5_web_project/gadget_project_info.html.html 0 → 100644
    15 <p>
    16 <a id="milestone_link" class="first-line-buttons ui-disabled" data-i18n="[value]Milestones" disabled >Milestones</a>
    17 <a id="support_request_link" class="first-line-buttons ui-disabled" data-i18n="[value]Support Requests" disabled >Support requests</a>
    18 <a id="bug_link" class="first-line-buttons ui-disabled" data-i18n="[value]Bugs" disabled >Opened Bugs</a>
    19 <a id="closed_bug_link" class="first-line-buttons ui-disabled" data-i18n="[value]Closed Bugs" disabled >Closed Bugs</a>
    20 </p>
    21 </div>
    22 <div class="ui-field-contain" style="top:75px;">
    23 <p>
    24 <a id="task_link" class="first-line-buttons ui-disabled" data-i18n="[value]Confirmed Tasks" disabled >Confirmed Tasks</a>
    25 <a id="not_confirmed_task_link" class="first-line-buttons ui-disabled" data-i18n="[value]Not Confirmed Tasks" disabled >Not Confirmed Tasks</a>
    26 <a id="report_link" class="first-line-buttons ui-disabled" data-i18n="[value]Task Reports" disabled >Opened Task Reports</a>
    27 <a id="closed_report_link" class="first-line-buttons ui-disabled" data-i18n="[value]Closed Task Reports" disabled >Closed Task Reports</a>
    28 </p>
    29 </div>
    30 <div class="ui-field-contain" style="top:125px;">
    • @romain Romain Courteaud
      @romain commented 2019-11-06 10:02:46 UTC
      Owner

      I would prefer to not set any style attribute in the HTML. Please update your custom CSS instead.

  • Images
    Toggle discussion
    Romain Courteaud
    @romain started a discussion on an outdated diff 2019-11-06 10:04:09 UTC
    bt5/erp5_web_project_ui/SkinTemplateItem/portal_skins/erp5_web_project/gadget_project_info.js.js 0 → 100644
    1 /*jslint nomen: true, indent: 2 */
    2 /*global window, rJS, RSVP, document, FileReader, Blob, jIO, ensureArray,
    3 lockGadgetInQueue, unlockGadgetInQueue*/
    • @romain Romain Courteaud
      @romain commented 2019-11-06 10:04:09 UTC
      Owner

      can you jslint this script? (I expect it to at least complain about the unused lockGadgetInQueue variable)

  • Images
    Toggle discussion
    Romain Courteaud
    @romain started a discussion on an outdated diff 2019-11-06 10:05:39 UTC
    Last updated by Romain Courteaud 2019-11-06 14:48:43 UTC
    bt5/erp5_web_project_ui/bt/template_path_list 0 → 100644
    1 web_page_module/project_**
    2 web_site_module/project_nexedi_net
    • @romain Romain Courteaud
      @romain commented 2019-11-06 10:05:39 UTC
      Owner

      I don't like the nexedi_net suffix, as this code is commited in erp5 repository, and so, is unrelated to any custom nexedi configuration.

      Please find a more generic name.

    • @rporchetto Roque
      @rporchetto commented 2019-11-06 11:08:46 UTC
      Developer

      do you agree with "project_management_net" ?

    • @romain Romain Courteaud
      @romain commented 2019-11-06 14:48:43 UTC
      Owner

      _net is meaningless too.

  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • b951c276 - erp5_project: undo page template change in milestone view form

    Compare with previous version

    2019-11-06 10:08:38 UTC

    added 1 commit

    • b951c276 - erp5_project: undo page template change in milestone view form

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 1d8c6e76 - erp5_web_project_ui: fix support request link

    Compare with previous version

    2019-11-06 12:34:32 UTC

    added 1 commit

    • 1d8c6e76 - erp5_web_project_ui: fix support request link

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 4aa18574 - erp5_web_project_ui: drop script and use TALES exp directly

    Compare with previous version

    2019-11-06 12:35:51 UTC

    added 1 commit

    • 4aa18574 - erp5_web_project_ui: drop script and use TALES exp directly

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 3a7ae796 - erp5_web_project_ui: code cleanup in project info gadget

    Compare with previous version

    2019-11-06 15:07:54 UTC

    added 1 commit

    • 3a7ae796 - erp5_web_project_ui: code cleanup in project info gadget

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • c48dbc13 - erp5_web_project_ui: move html-styles to css file

    Compare with previous version

    2019-11-06 15:21:42 UTC

    added 1 commit

    • c48dbc13 - erp5_web_project_ui: move html-styles to css file

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 223bd298 - erp5_web_project_ui: rename web site to project_management

    Compare with previous version

    2019-11-06 16:25:31 UTC

    added 1 commit

    • 223bd298 - erp5_web_project_ui: rename web site to project_management

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • a38381e2 - erp5_base: common script to generate domains

    Compare with previous version

    2019-11-06 17:08:27 UTC

    added 1 commit

    • a38381e2 - erp5_base: common script to generate domains

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 30ce7ab8 - erp5_project: refactor in domain scripts

    Compare with previous version

    2019-11-06 17:10:59 UTC

    added 1 commit

    • 30ce7ab8 - erp5_project: refactor in domain scripts

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • aaa80b46 - erp5_crm: refactor in domain scripts

    Compare with previous version

    2019-11-06 17:11:27 UTC

    added 1 commit

    • aaa80b46 - erp5_crm: refactor in domain scripts

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • beb13792 - erp5_forge: refactor in domain scripts

    Compare with previous version

    2019-11-06 17:12:29 UTC

    added 1 commit

    • beb13792 - erp5_forge: refactor in domain scripts

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 22223e3f - erp5_project: undo changes in project list form

    Compare with previous version

    2019-11-07 11:35:43 UTC

    added 1 commit

    • 22223e3f - erp5_project: undo changes in project list form

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • f572d2ef - erp5_web_project_ui: new form for project list

    Compare with previous version

    2019-11-07 11:37:26 UTC

    added 1 commit

    • f572d2ef - erp5_web_project_ui: new form for project list

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • f8ff4674 - erp5_web_project_ui: using new project management list form

    Compare with previous version

    2019-11-07 13:36:19 UTC

    added 1 commit

    • f8ff4674 - erp5_web_project_ui: using new project management list form

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 7 commits

    • 77e065b6 - erp5_web_project_ui: initial commit for project.nexedi.net
    • fb45e8aa - erp5_project: new portal domains, scripts and forms for project management views
    • 6116f34a - erp5_base: common script to generate domains
    • 79984524 - erp5_crm: new domain in support request list
    • 1b6bfce3 - erp5_forge: bug module domain
    • 82e18270 - erp5_web_renderjs_ui: header title link changed from display to history_previous
    • a3a20f36 - [HARDCODED] run all tests

    Compare with previous version

    2019-11-07 14:07:54 UTC

    added 7 commits

    • 77e065b6 - erp5_web_project_ui: initial commit for project.nexedi.net
    • fb45e8aa - erp5_project: new portal domains, scripts and forms for project management views
    • 6116f34a - erp5_base: common script to generate domains
    • 79984524 - erp5_crm: new domain in support request list
    • 1b6bfce3 - erp5_forge: bug module domain
    • 82e18270 - erp5_web_renderjs_ui: header title link changed from display to history_previous
    • a3a20f36 - [HARDCODED] run all tests

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 81 commits

    • a3a20f36...df0701cf - 73 commits from branch nexedi:master
    • c6ee24de - [HARDCODED] run only Project tests
    • abd21ba7 - erp5_web_project_ui: initial commit for project.nexedi.net
    • 73c5d9cd - erp5_project: new portal domains, scripts and forms for project management views
    • fc1bd901 - erp5_base: common script to generate domains
    • 5b9fe63c - erp5_crm: new domain in support request list
    • 8e24cf2c - erp5_forge: bug module domain
    • 57e32f64 - erp5_web_renderjs_ui: header title link changed from display to history_previous
    • 102f7823 - [HARDCODED] run all tests

    Compare with previous version

    2019-11-07 15:18:07 UTC

    added 81 commits

    • a3a20f36...df0701cf - 73 commits from branch nexedi:master
    • c6ee24de - [HARDCODED] run only Project tests
    • abd21ba7 - erp5_web_project_ui: initial commit for project.nexedi.net
    • 73c5d9cd - erp5_project: new portal domains, scripts and forms for project management views
    • fc1bd901 - erp5_base: common script to generate domains
    • 5b9fe63c - erp5_crm: new domain in support request list
    • 8e24cf2c - erp5_forge: bug module domain
    • 57e32f64 - erp5_web_renderjs_ui: header title link changed from display to history_previous
    • 102f7823 - [HARDCODED] run all tests

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 8 commits

    • 8f1ab296 - erp5_web_project_ui: initial commit for project.nexedi.net
    • 35490eda - erp5_project: new portal domains, scripts and forms for project management views
    • 7c6857cb - erp5_base: common script to generate domains
    • 7fc5d68a - erp5_crm: new domain in support request list
    • 0ee638ad - erp5_forge: bug module domain
    • bd828fc9 - erp5_web_renderjs_ui: header title link changed from display to history_previous
    • 06897d9b - [HARDCODED] run only Project tests
    • 2e8e11c3 - [HARDCODED] run all tests

    Compare with previous version

    2019-11-07 15:20:21 UTC

    added 8 commits

    • 8f1ab296 - erp5_web_project_ui: initial commit for project.nexedi.net
    • 35490eda - erp5_project: new portal domains, scripts and forms for project management views
    • 7c6857cb - erp5_base: common script to generate domains
    • 7fc5d68a - erp5_crm: new domain in support request list
    • 0ee638ad - erp5_forge: bug module domain
    • bd828fc9 - erp5_web_renderjs_ui: header title link changed from display to history_previous
    • 06897d9b - [HARDCODED] run only Project tests
    • 2e8e11c3 - [HARDCODED] run all tests

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • fb2f6c44 - erp5_web_project_ui_test: fix test

    Compare with previous version

    2019-11-07 15:24:25 UTC

    added 1 commit

    • fb2f6c44 - erp5_web_project_ui_test: fix test

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 87a911e1 - erp5_web_project_ui_test: fix test

    Compare with previous version

    2019-11-07 16:49:26 UTC

    added 1 commit

    • 87a911e1 - erp5_web_project_ui_test: fix test

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 8 commits

    • 3a2b5e89 - erp5_web_project_ui: initial commit for project.nexedi.net
    • b68e9ee6 - erp5_project: new portal domains, scripts and forms for project management views
    • 22cc28f3 - erp5_base: common script to generate domains
    • 6b68d772 - erp5_crm: new domain in support request list
    • f9f48681 - erp5_forge: bug module domain
    • 05d627e8 - erp5_web_renderjs_ui: header title link changed from display to history_previous
    • e74138ae - [HARDCODED] run only Project tests
    • b4a97b71 - [HARDCODED] run all tests

    Compare with previous version

    2019-11-07 16:50:50 UTC

    added 8 commits

    • 3a2b5e89 - erp5_web_project_ui: initial commit for project.nexedi.net
    • b68e9ee6 - erp5_project: new portal domains, scripts and forms for project management views
    • 22cc28f3 - erp5_base: common script to generate domains
    • 6b68d772 - erp5_crm: new domain in support request list
    • f9f48681 - erp5_forge: bug module domain
    • 05d627e8 - erp5_web_renderjs_ui: header title link changed from display to history_previous
    • e74138ae - [HARDCODED] run only Project tests
    • b4a97b71 - [HARDCODED] run all tests

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • fbfb1953 - erp5_web_project_ui: fix appcache

    Compare with previous version

    2019-11-08 09:15:22 UTC

    added 1 commit

    • fbfb1953 - erp5_web_project_ui: fix appcache

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 7156aff2 - [HARDCODED] undo change in test init

    Compare with previous version

    2019-11-08 10:48:06 UTC

    added 1 commit

    • 7156aff2 - [HARDCODED] undo change in test init

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 2 commits

    • 4d6a79ef - erp5_web_project_ui: fix appcache
    • 5bb5b425 - erp5_web_renderjs_ui: header title link changed from display to history_previous

    Compare with previous version

    2019-11-08 11:02:58 UTC

    added 2 commits

    • 4d6a79ef - erp5_web_project_ui: fix appcache
    • 5bb5b425 - erp5_web_renderjs_ui: header title link changed from display to history_previous

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • fcf5e6fb - Revert "erp5_web_renderjs_ui: header title link changed from display to history_previous"

    Compare with previous version

    2019-11-08 11:06:47 UTC

    added 1 commit

    • fcf5e6fb - Revert "erp5_web_renderjs_ui: header title link changed from display to history_previous"

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 5 commits

    • 049391fb - erp5_web_project_ui: initial commit for project.nexedi.net
    • 75a69827 - erp5_project: new portal domains, scripts and forms for project management views
    • e19243da - erp5_base: common script to generate domains
    • 2cbd438f - erp5_crm: new domain in support request list
    • e9072e43 - erp5_forge: bug module domain

    Compare with previous version

    2019-11-08 11:08:29 UTC

    added 5 commits

    • 049391fb - erp5_web_project_ui: initial commit for project.nexedi.net
    • 75a69827 - erp5_project: new portal domains, scripts and forms for project management views
    • e19243da - erp5_base: common script to generate domains
    • 2cbd438f - erp5_crm: new domain in support request list
    • e9072e43 - erp5_forge: bug module domain

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 2525ad3b - erp5_web_project_ui: rename function and form

    Compare with previous version

    2019-11-08 12:11:02 UTC

    added 1 commit

    • 2525ad3b - erp5_web_project_ui: rename function and form

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 543f0f99 - erp5_project: fix identation in domain scripts

    Compare with previous version

    2019-11-08 12:12:31 UTC

    added 1 commit

    • 543f0f99 - erp5_project: fix identation in domain scripts

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 5e39704b - erp5_crm: fix identation in domain scripts

    Compare with previous version

    2019-11-08 12:13:00 UTC

    added 1 commit

    • 5e39704b - erp5_crm: fix identation in domain scripts

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 6385496d - erp5_forge: fix identation in domain scripts

    Compare with previous version

    2019-11-08 12:13:27 UTC

    added 1 commit

    • 6385496d - erp5_forge: fix identation in domain scripts

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 5 commits

    • 79f5af69 - erp5_web_project_ui: initial commit for project.nexedi.net
    • 7687fbb2 - erp5_project: new portal domains, scripts and forms for project management views
    • bfd4ea44 - erp5_base: common script to generate domains
    • 7dced729 - erp5_crm: new domain in support request list
    • df660f4f - erp5_forge: bug module domain

    Compare with previous version

    2019-11-08 12:15:39 UTC

    added 5 commits

    • 79f5af69 - erp5_web_project_ui: initial commit for project.nexedi.net
    • 7687fbb2 - erp5_project: new portal domains, scripts and forms for project management views
    • bfd4ea44 - erp5_base: common script to generate domains
    • 7dced729 - erp5_crm: new domain in support request list
    • df660f4f - erp5_forge: bug module domain

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • e7f48335 - erp5_web_project_ui: update controller list form name

    Compare with previous version

    2019-11-08 12:19:11 UTC

    added 1 commit

    • e7f48335 - erp5_web_project_ui: update controller list form name

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 5 commits

    • 04e49f17 - erp5_web_project_ui: initial commit for project.nexedi.net
    • d5ac659d - erp5_project: new portal domains, scripts and forms for project management views
    • d3b71453 - erp5_base: common script to generate domains
    • 33836627 - erp5_crm: new domain in support request list
    • 61edeef4 - erp5_forge: bug module domain

    Compare with previous version

    2019-11-08 12:19:56 UTC

    added 5 commits

    • 04e49f17 - erp5_web_project_ui: initial commit for project.nexedi.net
    • d5ac659d - erp5_project: new portal domains, scripts and forms for project management views
    • d3b71453 - erp5_base: common script to generate domains
    • 33836627 - erp5_crm: new domain in support request list
    • 61edeef4 - erp5_forge: bug module domain

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 1 commit

    • 7ace3230 - erp5_project: undo changes on milestone form

    Compare with previous version

    2019-11-08 13:38:28 UTC

    added 1 commit

    • 7ace3230 - erp5_project: undo changes on milestone form

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    added 4 commits

    • 14287903 - erp5_project: new portal domains, scripts and forms for project management views
    • d85f96be - erp5_base: common script to generate domains
    • 7490442b - erp5_crm: new domain in support request list
    • e61d11e9 - erp5_forge: bug module domain

    Compare with previous version

    2019-11-08 13:40:23 UTC

    added 4 commits

    • 14287903 - erp5_project: new portal domains, scripts and forms for project management views
    • d85f96be - erp5_base: common script to generate domains
    • 7490442b - erp5_crm: new domain in support request list
    • e61d11e9 - erp5_forge: bug module domain

    Compare with previous version

    Toggle commit list
  • @rporchetto Roque
    @rporchetto

    merged

    2019-11-08 13:42:39 UTC

    merged

    Toggle commit list
  • @jerome Jérome Perrin
    @jerome

    mentioned in merge request !987

    2019-11-21 01:17:04 UTC

    mentioned in merge request !987

    Toggle commit list
  • Write
  • Preview
Styling with Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
  • Please register or sign in to post a comment
Romain Courteaud
Assignee
Romain Courteaud @romain
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
3
3 participants
Reference: nexedi/erp5!956
×

Revert this commit

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this commit

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备14008524号